Received-SPF: pass (google.com: domain of linux-crypto+bounces-2808-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 21 Mar 2024 19:15:32 +0200
Message-Id: <CZZLJ4ND05DX.27IUNFT505Z9R@kernel.org>
Subject: Re: [PATCH v7 04/13] crypto: ecdsa - Extend res.x mod n calculation
 for NIST P521
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Stefan Berger" <stefanb@linux.ibm.com>, <keyrings@vger.kernel.org>,
 <linux-crypto@vger.kernel.org>, <herbert@gondor.apana.org.au>,
 <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <saulo.alessandre@tse.jus.br>,
 <lukas@wunner.de>, <bbhushan2@marvell.com>
References: <20240320114725.1644921-1-stefanb@linux.ibm.com>
 <20240320114725.1644921-5-stefanb@linux.ibm.com>
In-Reply-To: <20240320114725.1644921-5-stefanb@linux.ibm.com>

On Wed Mar 20, 2024 at 1:47 PM EET, Stefan Berger wrote:
> res.x has been calculated by ecc_point_mult_shamir, which uses
> 'mod curve_prime' on res.x and therefore p > res.x with 'p' being the
> curve_prime. Further, it is true that for the NIST curves p > n with 'n'
> being the 'curve_order' and therefore the following may be true as well:
> p > res.x >=3D n.
>
> If res.x >=3D n then res.x mod n can be calculated by iteratively sub-
> tracting n from res.x until res.x < n. For NIST P192/256/384 this can be
> done in a single subtraction. This can also be done in a single
> subtraction for NIST P521.
>
> The mathematical reason why a single subtraction is sufficient is due to
> the values of 'p' and 'n' of the NIST curves where the following holds
> true:
>
>    note: max(res.x) =3D p - 1
>
>    max(res.x) - n < n
>        p - 1  - n < n
>        p - 1      < 2n  =3D> holds true for the NIST curves
>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Tested-by: Lukas Wunner <lukas@wunner.de>
> ---
>  crypto/ecdsa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
> index 64e1e69d53ba..1814f009f971 100644
> --- a/crypto/ecdsa.c
> +++ b/crypto/ecdsa.c
> @@ -122,7 +122,7 @@ static int _ecdsa_verify(struct ecc_ctx *ctx, const u=
64 *hash, const u64 *r, con
> =20
>  	/* res.x =3D res.x mod n (if res.x > order) */
>  	if (unlikely(vli_cmp(res.x, curve->n, ndigits) =3D=3D 1))
> -		/* faster alternative for NIST p384, p256 & p192 */
> +		/* faster alternative for NIST p521, p384, p256 & p192 */
>  		vli_sub(res.x, res.x, curve->n, ndigits);
> =20
>  	if (!vli_cmp(res.x, r, ndigits))


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko