Received-SPF: pass (google.com: domain of linux-crypto+bounces-2828-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 23 Mar 2024 01:27:57 +0300
From: Vitaly Chikunov <vt@altlinux.org>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	saulo.alessandre@tse.jus.br
Subject: Re: [PATCH] crypto: ecdsa - Fix module auto-load on add-key
Message-ID: <20240322222757.gsr4kto47imm5spj@altlinux.org>
References: <20240321144433.1671394-1-stefanb@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20240321144433.1671394-1-stefanb@linux.ibm.com>

On Thu, Mar 21, 2024 at 10:44:33AM -0400, Stefan Berger wrote:
> Add module alias with the algorithm cra_name similar to what we have for
> RSA-related and other algorithms.
> 
> The kernel attempts to modprobe asymmetric algorithms using the names
> "crypto-$cra_name" and "crypto-$cra_name-all." However, since these
> aliases are currently missing, the modules are not loaded. For instance,
> when using the `add_key` function, the hash algorithm is typically
> loaded automatically, but the asymmetric algorithm is not.
> 
> Steps to test:
> 
> 1. Create certificate
> 
>   openssl req -x509 -sha256 -newkey ec \
>   -pkeyopt "ec_paramgen_curve:secp384r1" -keyout key.pem -days 365 \
>   -subj '/CN=test' -nodes -outform der -out nist-p384.der
> 
> 2. Optionally, trace module requests with: trace-cmd stream -e module &
> 
> 3. Trigger add_key call for the cert:
> 
>    # keyctl padd asymmetric "" @u < nist-p384.der
>    641069229
>    # lsmod | head -2
>    Module                  Size  Used by
>    ecdsa_generic          16384  0
> 
> Fixes: c12d448ba939 ("crypto: ecdsa - Register NIST P384 and extend test suite")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Reviewed-by: Vitaly Chikunov <vt@altlinux.org>

> ---
>  crypto/ecdsa.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
> index fbd76498aba8..3f9ec273a121 100644
> --- a/crypto/ecdsa.c
> +++ b/crypto/ecdsa.c
> @@ -373,4 +373,7 @@ module_exit(ecdsa_exit);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Stefan Berger <stefanb@linux.ibm.com>");
>  MODULE_DESCRIPTION("ECDSA generic algorithm");
> +MODULE_ALIAS_CRYPTO("ecdsa-nist-p192");
> +MODULE_ALIAS_CRYPTO("ecdsa-nist-p256");
> +MODULE_ALIAS_CRYPTO("ecdsa-nist-p384");
>  MODULE_ALIAS_CRYPTO("ecdsa-generic");
> -- 
> 2.43.0