Received-SPF: pass (google.com: domain of linux-crypto+bounces-2855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 25 Mar 2024 20:18:37 +0100
From: Lukas Wunner <lukas@wunner.de>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
	bbhushan2@marvell.com, jarkko@kernel.org
Subject: Re: [PATCH v7 00/13] Add support for NIST P521 to ecdsa
Message-ID: <ZgHODQL-XLxTDO4b@wunner.de>
References: <20240320114725.1644921-1-stefanb@linux.ibm.com>
 <5c6c5f51-125b-4cc7-ac27-5a5358d514c7@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5c6c5f51-125b-4cc7-ac27-5a5358d514c7@linux.ibm.com>

On Wed, Mar 20, 2024 at 08:44:52AM -0400, Stefan Berger wrote:
> On 3/20/24 07:47, Stefan Berger wrote:
> > This series adds support for the NIST P521 curve to the ecdsa module
> > to enable signature verification with it.
> > 
> > An issue with the current code in ecdsa is that it assumes that input
> > arrays providing key coordinates for example, are arrays of digits
> > (a 'digit' is a 'u64'). This works well for all currently supported
> > curves, such as NIST P192/256/384, but does not work for NIST P521 where
> > coordinates are 8 digits + 2 bytes long. So some of the changes deal with
> > converting byte arrays to digits and adjusting tests on input byte
> > array lengths to tolerate arrays not providing multiples of 8 bytes.

I've tested the whole series successfully on v6.9-rc1 by authenticating
a PCI device with a NIST P521 certificate using my PCI/CMA development
branch: https://github.com/l1k/linux/commits/doe

Tested-by: Lukas Wunner <lukas@wunner.de>