Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp898358lqh; Thu, 28 Mar 2024 23:35:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVHp1sXNKMAFbogCgJt/tKesEDJ+XF0fQQoBeMmHhQkjM/kZ/bHYM+ewBSD+dTNG/rAP3kXyDXosS7gGzmpYbsXEfZ5MA0PgMbixyvWJQ== X-Google-Smtp-Source: AGHT+IGT0V6/bUZXyxvVLMtzsiY328Ld6Xb5Bp/xROwNce86ZxSz6ft9qSUug+7DiNC0hg8DuVPU X-Received: by 2002:a17:906:c19a:b0:a4e:279f:ab2c with SMTP id g26-20020a170906c19a00b00a4e279fab2cmr1245360ejz.12.1711694100681; Thu, 28 Mar 2024 23:35:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711694100; cv=pass; d=google.com; s=arc-20160816; b=IJyXo+XAw1QsAL1e/gJv1kBFnv8zjpc+qJGdgddx5y/kKzeN/Hvn9o6KEMLC86tdOD Mogjm8v5upqSrOpRegBlARLP4QBrgtR4bRSZJiXlATZIgri1QTMo7CdKdROnOi/exA5d 0ZLLen2eUzSZsb7W7nmzyqFisewxhpmKmlB0hE6KTqgOsESKVZksRlUzInOgpwe363dz cGAasM1tSVlIx4chz1NQWHPu9qJ9MK74LrSYQqSm0j7r7PunMnkwfgi1OxrboH11NVnm k6tBMZ+vmXeNIF6lhGNE7KpCpLPdE6SnUN/HqHPnbJc1pa0ZM31x0v82CbIFymIB7BYR xrHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jk+OH9l4lg4Zq+xZmgAWHUkwS1Zs4VUG3TdRsiYbidU=; fh=UA8cKkHE5GBi8ygiQRzSFFTCowHAwhse+UkUTlm1RJU=; b=lIcn9M6aHZbdfDRGyfmgk0p9u2exZaAhVjaSGSUD+zeedhRZqq81M8xf1+bQDVZDw8 DKGzk3sB8NXBn7mRfc3XKOUAD3ir4LBGE1hR5B/EMvS7Y8aynAStvaRayjWnTnG0E9mK rLBN91Ubo1OHEtQYhBSJQZOjZXNn9AwJqZzgCLr04XdLkjBSWHPw62pZFb46DFsW/x+P BDNblqBVBiv1WJMiXdJfUnTgN4Hnp52WekB7YX4UJfyuwSsB4uBDXziBt0j6n2eTpXVW xTk+pdSqO0h6aFYyKhdElBvPWLSyQh/NenPcY2KE7cUzipxuWv0v+5bJsmRugHYA2BvC foMg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YSWhuXv2; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-crypto+bounces-3056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3056-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ck8-20020a170906c44800b00a4e360631b8si352207ejb.1022.2024.03.28.23.35.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 23:35:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YSWhuXv2; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-crypto+bounces-3056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3056-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 69E991F22DF9 for ; Fri, 29 Mar 2024 06:35:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B73FE3FBB3; Fri, 29 Mar 2024 06:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YSWhuXv2" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B27F3FB83; Fri, 29 Mar 2024 06:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711694094; cv=none; b=MkSCaBtcmgsHI2oSjn1gSEyFSh+C4jQ+VlPF1FbVu9HYy3XW40i8MCFXbbMzHNkUI19YjtOOoCh194xxjZWk5u268Wol8QdHf1TBsIX3VdSz6xSrUjOIBYsqo7yl0FDQC3Ig051YjoscDnxZE9cSAL52MBfTKKafXjczY3LjLII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711694094; c=relaxed/simple; bh=JZDd4vTOWg91ZZZdlKhj2Iuf8kbXcTkZgWQyBW9M9bA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oG05Lt7UFFjvGGjjZCdd2A+iM3mxYOoPKNwfmKTphuai+jM+eSzUz4HvdtjG/J6P35fKOxeAFe76VGN3LhX2p6cLM+wn0jQyPNLoU+xWlu6xuAha+PSerTZcNk1xO18qIeQdw//K+j2baL2sWKpoRGMcct43CjESPO804KoJMI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YSWhuXv2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CA35C433C7; Fri, 29 Mar 2024 06:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711694094; bh=JZDd4vTOWg91ZZZdlKhj2Iuf8kbXcTkZgWQyBW9M9bA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YSWhuXv21YBYdVAQHEohit7APVPxdrYw1NjCJ/Q589Zmt9RI8JDhrsn28T0KOF+uL 1VKff0pavugkCoc6CwstGTCfET0pSJ8RJhbAVAXfLKjGhIwhXPVCcC1rU3iHJa2/nE x08+MIDtIIBgVeRQekeRZRA5hvQI/KW4goeipNSs= Date: Fri, 29 Mar 2024 07:34:50 +0100 From: Greg KH To: Chenghai Huang Cc: zhangfei.gao@linaro.org, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, fanghao11@huawei.com, shenyang39@huawei.com, liulongfang@huawei.com, qianweili@huawei.com Subject: Re: [PATCH] misc: uacce - add the null check for the input pointer and its pointer members Message-ID: <2024032946-supernova-unstaffed-63ec@gregkh> References: <20240329062655.3055646-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240329062655.3055646-1-huangchenghai2@huawei.com> On Fri, Mar 29, 2024 at 02:26:55PM +0800, Chenghai Huang wrote: > The uacce_alloc() is the member of the EXPORT_SYMBOL_GPL. Therefore, null > pointer verification is added on the pointer type input parameter and its > pointer members. I do not understand, why does the export type matter? Just fix any callers to use this properly and send proper parameters. What in-tree caller needs this? thanks, greg k-h