Received-SPF: pass (google.com: domain of linux-crypto+bounces-3075-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 29 Mar 2024 11:55:25 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Alexey Romanov <avromanov@salutedevices.com>
CC: Conor Dooley <conor@kernel.org>, "neil.armstrong@linaro.org"
	<neil.armstrong@linaro.org>, "clabbe@baylibre.com" <clabbe@baylibre.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>, "robh+dt@kernel.org"
	<robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "khilman@baylibre.com" <khilman@baylibre.com>,
	"jbrunet@baylibre.com" <jbrunet@baylibre.com>,
	"martin.blumenstingl@googlemail.com" <martin.blumenstingl@googlemail.com>,
	"vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-amlogic@lists.infradead.org" <linux-amlogic@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v6 17/23] dt-bindings: crypto: meson: remove clk and
 second interrupt line for GXL
Message-ID: <20240329-dotted-illusive-9f0593805a05@wendy>
References: <20240326153219.2915080-1-avromanov@salutedevices.com>
 <20240326153219.2915080-18-avromanov@salutedevices.com>
 <20240326-obscurity-angriness-d7bb48bc9eaa@spud>
 <20240329111424.i2zp2coznqpnibk4@cab-wsm-0029881>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="OWDxAKnoP5FbCqUI"
Content-Disposition: inline
In-Reply-To: <20240329111424.i2zp2coznqpnibk4@cab-wsm-0029881>

--OWDxAKnoP5FbCqUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2024 at 11:14:29AM +0000, Alexey Romanov wrote:
> Hi Conor,
>=20
> On Tue, Mar 26, 2024 at 06:09:37PM +0000, Conor Dooley wrote:
> > On Tue, Mar 26, 2024 at 06:32:13PM +0300, Alexey Romanov wrote:
> > > GXL crypto IP uses DMA engine, which doesn't require clk input
> > > and second interrupt line.
> > >=20
> > > Fixes: c4a0457eb858 ("ARM64: dts: amlogic: adds crypto hardware node")
> >=20
> > How does this fix a commit that only modifies a dts? The commit cited
> > here should be a dt-bindings commit.
>=20
> Yep, my bad. Will fix it in next series.
>=20
> >=20
> > However, your commit message says "require" but you do more than remove
> > these as required, you remove them entirely. What am I missing?
>=20
> Crypto HW isn't connected to clk / 2nd interrput line, so we must remove
> them from dt. I will reformulate commit message.

Yeah, please do. Be clear about the hardware not actually having these
things. And hopefully Corentin can chime in as to why he thought it did.


--OWDxAKnoP5FbCqUI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgasLQAKCRB4tDGHoIJi
0nngAPsFHgCeAZUB7PIObsvIZP/P+DvGPq/PYOyGwboFETQrjAEAtkASonmxY4qS
yt5TD7EbgaRPDqo9W4bjTUgkIn49Xws=
=MGQH
-----END PGP SIGNATURE-----

--OWDxAKnoP5FbCqUI--