Received-SPF: pass (google.com: domain of linux-crypto+bounces-3261-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 2 Apr 2024 17:21:18 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
CC: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller"
	<davem@davemloft.net>, <qat-linux@intel.com>, <linux-crypto@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH][next] crypto: qat - Avoid -Wflex-array-member-not-at-end
 warnings
Message-ID: <ZgwwfrrnFhG9jmo0@gcabiddu-mobl.ger.corp.intel.com>
References: <ZgHiR7j2NYl5M4mW@neat>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZgHiR7j2NYl5M4mW@neat>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RXkMCBGP/55nlm0Em2s6T1p6Z8HS/F+o+DgO8z40qN4LISoUC5JTVFCUFikY?=
 =?us-ascii?Q?73rKrzyanbSDJiU3PFjsnANdjb3zsD76HIE1zs8EF0t/Hmq6zNLKKUH+i36I?=
 =?us-ascii?Q?xcZ3Ci4YTZ8k2NkAXOGwPfnJKrs3NlgO+Wb3Wz/Z1hGQdFkjoVKWn+u+pyaB?=
 =?us-ascii?Q?y2OkzOBBV7Uh5YEqxRv1RXqUe5gKtoA6JKCHDHh2HKTaM+m2e8KtiF2U5hS8?=
 =?us-ascii?Q?spcoWXRJ7wlomoGXv5jrp7nqPYwu/WJ2BC+LufNaovye8r/c5Sg6qAxa8ulF?=
 =?us-ascii?Q?H3ltL7JPQ0AjkVE2wsHdgGmiBywiXB26V4JhcOIyZ2Zd69HLMjTIXAAOhFta?=
 =?us-ascii?Q?hsCokeE/x9MH/vRuRi/kOpZ1hfX4Sj/ROj+aOpDDVK1QJQiIeDoctryuEvoS?=
 =?us-ascii?Q?9N1www+BIs9SyeLmZqSOOQW7DDb4wJjEFMrM5Hd2f0a6R7RRf3H4/9Wb6riA?=
 =?us-ascii?Q?jLfB0mMDt/RdLPpfUtY2t1USazzhQMJDT1AImpCH6monwvCK3XXJrAA7N4m5?=
 =?us-ascii?Q?JuIHkGxjDUCTBgWwZd1k0/3+aq35ZIfHRmI3vcNRjoZIQIAtuhljgPpgt+SK?=
 =?us-ascii?Q?vEtERYcvavTv6OBAtP7HUp6IjbKZMxEzcbMmFz377kLYpQDhRyGfNZParjRQ?=
 =?us-ascii?Q?20pol0hb82XNZjo1peage247SI6P09nECDOq7W8J70lcd3GUIQXAqMeVY8Dn?=
 =?us-ascii?Q?qDkksXPnLPjmLpnshKKDUyWvk87OBLKoXGngyrRimvcj9aw4Q9C9rBkAYB+n?=
 =?us-ascii?Q?YYk++0tdc2fKFT9CHuZPc+buT2WxcIt/yotLIUaTXGTSyIaNxjeiX/96olP9?=
 =?us-ascii?Q?/I7gon4gMKE5vj+i2VldWxrsUvLhr3+AZjnmuydL506aAXLlFxA7sjAvJ+dQ?=
 =?us-ascii?Q?trQ2+YxcR6eHoDWAfXYJyVDeiveftcilQF2/+UUPbqi1U5ybTHmAk55Qum1k?=
 =?us-ascii?Q?ah6cEZnx9hyFNdSR6nv50+W+ADMlE4unNawYcs7rdF9YzrqZa5VoxjIAOeAD?=
 =?us-ascii?Q?ccOp94bzO8WlL6E0CFSEZZIO0qsNSSQqUacViB0sgatg+XRKo86Twm+N1J4S?=
 =?us-ascii?Q?/fbhh0FLUzyRmh5aZu9CUJukvBv4sL+Ug4ZqxKyub9w6mDIAOd8Pmn53CwN3?=
 =?us-ascii?Q?rTL7sqll7BjgbxdGyeyZCBl2oMDdkS8M+goSwSlzsReGfAhXSIgMWtKPVwFx?=
 =?us-ascii?Q?B/gpE5h+fsi0jl+fq+132QLsdEMPtaeKtr6B3uDmogpnJJlHvTwD87bR/NZJ?=
 =?us-ascii?Q?QJs2E6AZwOXADsIHVslqNH9V8CQIMlycB2z5MGyBwpbnwW7igRE9ckdahZDC?=
 =?us-ascii?Q?7M14YAyhGqY3ZkhZk4FP/oBhPEFQ++TMwd/8oJCzjSEf1MXkWBl6/FKbxrTz?=
 =?us-ascii?Q?uoW8RsnTv5TNB2d4K7PeplD6302Oum7BOKzHE8Dca1qWo6GBQF4Cf8NB5wcP?=
 =?us-ascii?Q?O+e4r1L8jLLC/Hwk0euWk2cwOIyjKOvHwISfERJm3IHqSEFVlIz4ATsbrviu?=
 =?us-ascii?Q?XaGFCIQqkinfgkJFsCV8vgN4s1Kbw07bYS38IIdPe4mcDNjaXItCdZPETG9J?=
 =?us-ascii?Q?6na1bAnvdjYgNXDRmWwSEpZaIK8qSZYubp5jAyjygUqALPmcSedodIqF9lJl?=
 =?us-ascii?Q?jQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2dde7f7-3575-4cdc-8449-08dc533132d5
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 16:23:15.2406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j9uBcSw/Y1RAqfLyYPG8HVZCrlf4chxeRV5SmJCGSCyVeepBY0Muj8aUT4WI0J+YYWdC7NkXQt/ZUPhiGrRpqvNisYXbALamGqgEjwDh6Jk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5180
X-OriginatorOrg: intel.com

On Mon, Mar 25, 2024 at 02:44:55PM -0600, Gustavo A. R. Silva wrote:
> -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting
> ready to enable it globally.
> 
> Use the `__struct_group()` helper to separate the flexible array
> from the rest of the members in flexible `struct qat_alg_buf_list`,
> through tagged `struct qat_alg_buf_list_hdr`, and avoid embedding the
> flexible-array member in the middle of `struct qat_alg_fixed_buf_list`.
> 
> Also, use `container_of()` whenever we need to retrieve a pointer to
> the flexible structure.
> 
> So, with these changes, fix the following warnings:
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/crypto/intel/qat/qat_common/qat_bl.h:25:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Link: https://github.com/KSPP/linux/issues/202
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Regards,

-- 
Giovanni