Received-SPF: pass (google.com: domain of linux-crypto+bounces-3305-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-Id: <ac96323b-80f7-43c0-b99e-b7772eb26802@app.fastmail.com>
In-Reply-To: <dd7977b9-bdd2-f36f-36bd-a383a2588f6e@amd.com>
References: <20240403080702.3509288-1-arnd@kernel.org>
 <20240403080702.3509288-25-arnd@kernel.org>
 <dd7977b9-bdd2-f36f-36bd-a383a2588f6e@amd.com>
Date: Wed, 03 Apr 2024 17:50:23 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tom Lendacky" <thomas.lendacky@amd.com>,
 "Arnd Bergmann" <arnd@kernel.org>, linux-kernel@vger.kernel.org,
 "John Allen" <john.allen@amd.com>,
 "Herbert Xu" <herbert@gondor.apana.org.au>,
 "David S . Miller" <davem@davemloft.net>
Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 linux-crypto@vger.kernel.org
Subject: Re: [PATCH 24/34] crypto: ccp - drop platform ifdef checks
Content-Type: text/plain

On Wed, Apr 3, 2024, at 17:17, Tom Lendacky wrote:
> On 4/3/24 03:06, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> When both ACPI and OF are disabled, the dev_vdata variable is unused:
>> 
>> drivers/crypto/ccp/sp-platform.c:33:34: error: unused variable 'dev_vdata' [-Werror,-Wunused-const-variable]
>> 
>> This is not a useful configuration, and there is not much point in saving
>> a few bytes when only one of the two is enabled, so just remove all
>> these ifdef checks and rely on of_match_node() and acpi_match_device()
>> returning NULL when these subsystems are disabled.
>> 
>> Fixes: 6c5063434098 ("crypto: ccp - Add ACPI support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Would using __maybe_unused on dev_vdata be the safer, easier choice?

It's a simpler change, but leaves the extra complexity that
is not needed here.

      Arnd