Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp298305lqp; Thu, 4 Apr 2024 13:34:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUwh8/xEsFBLngPbD2w6mPeKEKv0XC+iBPHyoYcNB/JneFck3tmg3LULq8baaBUD0dld1qm4V9ovqkf5Ol48gcF59VOaN9KU47fuXbDcg== X-Google-Smtp-Source: AGHT+IHy7AT0Q6OA4DNvppXAxCRTUJLNPmYze5BlkJwwMBt1uroqwQwd5PTMmeRg5aZn9rPwiMql X-Received: by 2002:a05:6808:4493:b0:3c3:ebba:2cdc with SMTP id eq19-20020a056808449300b003c3ebba2cdcmr5228404oib.17.1712262855213; Thu, 04 Apr 2024 13:34:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712262855; cv=pass; d=google.com; s=arc-20160816; b=S8ORJWoh6ktogZXZUgTwerpKOGVkIttnAl+rpkN4Cb2vfVURBTyqWuug1bRSIidX1u ooGpScQTvVuwHt8hE1M9GPT46D15/cHdDHbxBmJmwXdB1F/YZo93QMX30o/98hYkyoWq bre51KwwbYlJSZWO3ldWM0aIyrn1u3Nkk9GZjWAmbIrrCB3CKFFzBKiyVUi4udLoNEuU EAPdsBZ05BBGTr16K/TjIivq6+1uqBWI7Pslv2OJN/Eu0ltkT9HxWS9f3P4AaP4bkoqg /dzDSpwQomWpreOebr6KPZTdYMA0qsmgzrqc5bzOc8YwTL/q9LydMZ9UV9HH4kkJA7tx OjHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Tm8h4eSHetodbXdC+g3r7jOcRrhXL+nxVQ0QgoIN79A=; fh=Sywb1AGb5zHvr5+19mjveuibi5yQyiNhHVFTTpD583w=; b=05T2S/CgYgKn5K0SMHKzvTHCj5nffstUod+9Asttrbu1TRPYmCVzfIV35Em9FTWJn2 TybkH2ZZjAUeggkYRDLbzBvvEbbOcFknurGQOMBa0fVW3TyXtlUv+bomNxnyuYPSmxyV vJ5MoEAgB1gRFUiBl+GoE/BToqUURMZOX/YrKBYb5ppDOHd89g1SqMwgFFy5XRlw54Ig oSzPrsDvDq2Ys7RjXLRKc4sbKaY7Jez6BLD+9ulbGCI6hvQalLlZFv7Ms8XLyzRbqA4w nsbofRWKwlONlTELYFQYYaVQH8wbl6RaJghUAZvNj3Ts5mbAzYUnro83+rs6Sa38UMcH miRw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dnT5fYUA; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-crypto+bounces-3338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f9-20020ac87f09000000b00432b2fa441asi131525qtk.525.2024.04.04.13.34.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 13:34:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dnT5fYUA; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-crypto+bounces-3338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B026C1C2255C for ; Thu, 4 Apr 2024 20:34:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38137136660; Thu, 4 Apr 2024 20:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dnT5fYUA" X-Original-To: linux-crypto@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA8A56FE26; Thu, 4 Apr 2024 20:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712262850; cv=none; b=IN2Xs1d+1szxnnF7YlTebExkcv2EpVhizNyb1ThV/ZF5d6k1jfc6jHMSN0Zgpzmj+9Wm6WOVnoNhP2jqjBVnWEaQQQOeV/y6oXrp89I57v8EVTikZau0EGB9pFFq3QR0yU9cVfwpHuRvjmomLjfLoS3aAepXCmXP4RaiikiAWJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712262850; c=relaxed/simple; bh=EfISDVvrAaKxrRUH0h9JaJqMOAiLpYXNI9NkfNWfA/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EAr70+v52qSt044Ke8TDCJ9Wv8PK4VtykdkMwPyhh6CqxBuW03OgHEulWFG3PFdCxNmDR28yR1Md+0s14MKfkpUHeC8fPYZ0h9bR9SOVpQVgnff4SL89Zd+MHSY+T2tzNoT2gQ5yQE7NefOI4huDq/uJ55b8FrythSQVR91fCvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dnT5fYUA; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712262848; x=1743798848; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EfISDVvrAaKxrRUH0h9JaJqMOAiLpYXNI9NkfNWfA/w=; b=dnT5fYUAYaBluIx0UkZSA1gnQwBr1CYlqNR3nnf2TffD6AEtubtnuNm+ Jkqcue2750WGGl15Tns3Z2LWMHYAckXpzSEtZYrGGFB7RpYZw+HHSxa/H 1itnR+DG1HvUJ8PqhqN3Fx8oJBHv8b4ei0mfr4yJarpKcGl+3fD3oKfVr OEIyu/EabHkwlItVqolPxDC2e8trfbGDKkAqtzwmNuNHB3KDgKvgsLl3S EiqS2jPJiw2jWv77O76EEgNU0Pm3VvleyGoppNci9rKghNUrA10HjWfQ0 9jlMZSPUoCqz6jISuUAmi+RvJE/FmherbPYdfLWKEH91qMH7FQ8NnXMz5 Q==; X-CSE-ConnectionGUID: iXqkrLizRFap9X21oj/pFA== X-CSE-MsgGUID: nwsMoVznRuy5A60RNVqOqA== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="18310019" X-IronPort-AV: E=Sophos;i="6.07,180,1708416000"; d="scan'208";a="18310019" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 13:34:05 -0700 X-CSE-ConnectionGUID: gZGUdyeJRJqS3ui3x4jFJg== X-CSE-MsgGUID: DFsuHmQ0RrCVC3o8umdx/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,180,1708416000"; d="scan'208";a="19509026" Received: from vzaharie-mobl.amr.corp.intel.com (HELO [10.209.26.243]) ([10.209.26.243]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 13:34:04 -0700 Message-ID: Date: Thu, 4 Apr 2024 13:34:04 -0700 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] crypto: x86/aes-xts - wire up VAES + AVX10/512 implementation To: Eric Biggers , linux-crypto@vger.kernel.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel , Andy Lutomirski , "Chang S . Bae" References: <20240329080355.2871-1-ebiggers@kernel.org> <20240329080355.2871-7-ebiggers@kernel.org> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240329080355.2871-7-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/29/24 01:03, Eric Biggers wrote: > +static const struct x86_cpu_id zmm_exclusion_list[] = { > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_SKYLAKE_X }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_ICELAKE_X }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_ICELAKE_D }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_ICELAKE }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_ICELAKE_L }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_ICELAKE_NNPI }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_TIGERLAKE_L }, > + { .vendor = X86_VENDOR_INTEL, .family = 6, .model = INTEL_FAM6_TIGERLAKE }, > + /* Allow Rocket Lake and later, and Sapphire Rapids and later. */ > + /* Also allow AMD CPUs (starting with Zen 4, the first with AVX-512). */ > + {}, > +}; A hard-coded model/family exclusion list is not great. It'll break when running in guests on newer CPUs that fake any of these models. Some folks will also surely disagree with the kernel policy implemented here. Is there no way to implement this other than a hard-coded kernel policy?