Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp170381lqe; Fri, 5 Apr 2024 17:28:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUNgHyuHUI8NwC92i3ymvOrEvHj6hgj2G17ehvQEYt02HvC+h0YfnQJ2pGdMkI+5hFzYVWppWB6uNMv+/d2mgtlczXEtw/OfT2GCPrlRg== X-Google-Smtp-Source: AGHT+IHJf3b06a2wkefHDEtBkRWqzUUzdOfR5xixsOV/h6eEg/Q4hzJVk+CwYZDTJVD6iajxI++f X-Received: by 2002:a5d:4a90:0:b0:341:d33e:da1b with SMTP id o16-20020a5d4a90000000b00341d33eda1bmr2924138wrq.31.1712363292663; Fri, 05 Apr 2024 17:28:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712363292; cv=pass; d=google.com; s=arc-20160816; b=KvzfjV3As8X0TrUwW2a5cyCpnASDKIt99K81qRXs7TihnQT0EvwH+Y0GEBFbdh7O9Z ezaw5cDFmqyScruCh5108ypuB5zjH9Cbh9rMXmCqSmLit696H8BnlFwr++6D1GHPxYq1 L7pOHK25OX1Oiz6yBuR+7pwoUomR0FKhdsQ3txVnCPUgivb0qj1kC4OlYkJAnCL4ZVo+ R6+eHH9p8FgBVHliAwSMGPNiQXTdeNXUsVqGawMUynMJR4oG5aNIy92Jh5yNkvJ0xQXz 7QXBFgfVpVNgCm8vFWJ1bV3OwYa54aHY3NkPHlxUmbk0lQo0NFPyDb1FpZdtFx4V/Dh5 elqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=vPyQi7z2oiN98voAn2goagGaU/MO0Dy4NoYTGF05XgU=; fh=Ro/QMgJsQnRI4UuaykA1+gPPzl3VNBmgnYASK7fsKkk=; b=0AD8gFaEZLqyeTgXlzoY6oPvqD404H0Gh3movLteGFFC8f1E3VuORDBHpRIEEPKUHj LqsGxrC4GEj860o3qCP56jIapXyTXk3LbFlDBFB0gu8dtbYTApt/HdausxnU7fn5d8QB 8ab36xv1SnSgGI+920too6Y2ec9yANrkSm51tA19Q1z2y+a5yR7lvM+LN68IefxWw7fj V8cVNMPREiSpdfQ+Hp7/A+//oqGgZaofBR7hkQt8jkeC/eFVumfb144Y7J4zGWQ1sjoq +Q+nX2a1r9+UDL2tqKLWpk09gaOMmYhNul66MMoVzSUcqKjFDZjQ6AUmRHSIHDMTgUhk SFJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cTO2WAk3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qf4-20020a1709077f0400b00a46636b0819si1233715ejc.894.2024.04.05.17.28.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 17:28:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cTO2WAk3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 649711F231E3 for ; Sat, 6 Apr 2024 00:28:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29C0117C2; Sat, 6 Apr 2024 00:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cTO2WAk3" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0CFA50 for ; Sat, 6 Apr 2024 00:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712363285; cv=none; b=TGrKkONuldE+bHR6+t2N1SIOTfmSJLZbBUxMM/N6ekhfUuuAXE1bYqDD+oeLTRM1jc5h4MS8v2m4WUm9bB9Ut0vLrLMI1JlTk7eVI4JGYWPfo0kkiiWyL8vF3EnDP9FqpX2SdcFtPmws0gpcs6EICoe5BMGA6dKFwGPbnhMBvrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712363285; c=relaxed/simple; bh=aOzuonNLlnJXwWBEwSgEzvclltWB5nPogY4JWBW1pH8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dWU/hGMcQ5uHBkHkAXA4X6KJJulTTViJvG5oSEgaVdlIcllkErMoM6fZbqzt22szpQZI3zE37+EW8VqGSpdF4SzILj81j2/MKXs9WGVFg0UoSpwhTq6gIv/DVIfEYx6tY+UXtWfYC4aRDXEYRUhXOuhO7HEOaHDV0taO/ES6Ha4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cTO2WAk3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DA4C43394; Sat, 6 Apr 2024 00:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712363285; bh=aOzuonNLlnJXwWBEwSgEzvclltWB5nPogY4JWBW1pH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cTO2WAk3em3FSnaF/wPo3bwxFCVaGIMotrc++Bz1leL1NRLreOSWgEwnlER2UcLhq vHvZfeW18oheooXKChi38rRZulctSlB/aTdyJnExSBSkqCsOxmDfsR9kqTDfJTJL2g uZX86oLFhPb0QLHFgct1BYd2nLyny/Rnq+8bEWDYOueF/x6MUFRbfWhOicr2qHCvIU pv6C7+LhWO5OAUzzEtDeMQhV++UJJhNqxL6kvWuNLaIYJkwV+NuXuUxHeQRgfvEMyz ke3BC8MmSbO3i7CrtMMsYKUwRloooaA9Tum4Bgi6IyUat02coQXLXB3ceWjZtqr9pR VDU5PjWZhxf9w== From: Eric Biggers To: linux-crypto@vger.kernel.org Cc: x86@kernel.org, Tim Chen Subject: [PATCH 1/3] crypto: x86/nh-avx2 - add missing vzeroupper Date: Fri, 5 Apr 2024 20:26:08 -0400 Message-ID: <20240406002610.37202-2-ebiggers@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240406002610.37202-1-ebiggers@kernel.org> References: <20240406002610.37202-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Eric Biggers Since nh_avx2() uses ymm registers, execute vzeroupper before returning from it. This is necessary to avoid reducing the performance of SSE code. Fixes: 0f961f9f670e ("crypto: x86/nhpoly1305 - add AVX2 accelerated NHPoly1305") Signed-off-by: Eric Biggers --- arch/x86/crypto/nh-avx2-x86_64.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/crypto/nh-avx2-x86_64.S b/arch/x86/crypto/nh-avx2-x86_64.S index ef73a3ab8726..791386d9a83a 100644 --- a/arch/x86/crypto/nh-avx2-x86_64.S +++ b/arch/x86/crypto/nh-avx2-x86_64.S @@ -152,7 +152,8 @@ SYM_TYPED_FUNC_START(nh_avx2) vpaddq T5, T4, T4 vpaddq T1, T0, T0 vpaddq T4, T0, T0 vmovdqu T0, (HASH) + vzeroupper RET SYM_FUNC_END(nh_avx2) -- 2.44.0