Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1309864lqe; Mon, 8 Apr 2024 05:37:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWCcQJPQi8QUjvQyCzgq3gPbHg/nR6F2LltBh5egcxSqK1Bhival7Qg4clqYJbKpCYncKzqIrdphB0IK129/A4ogFIqPqJ41lOXq7t39Q== X-Google-Smtp-Source: AGHT+IFHQLEmPHzpRri0OElQ3LDUTFE1slnfJ58f8xyncRYWI+YslEI2ykETPw5XjfrRTbuht3yF X-Received: by 2002:a25:7e41:0:b0:dcc:8e02:a6b6 with SMTP id z62-20020a257e41000000b00dcc8e02a6b6mr6761145ybc.2.1712579870844; Mon, 08 Apr 2024 05:37:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712579870; cv=pass; d=google.com; s=arc-20160816; b=WWnV2jdkXY0rl0sa77NiGpMlAac/UFqK9ZD3vbdleGbzotm8isIgCTRSoZjZIaMcde kc4u6tzGn9Rp9AGXi+L4sl5Xys8dSVPmaMqmEvfGEpWvH2FILMXmBvsoyI3H1b/F2L84 EsOAVmS6jdzAD9dTIG8sN/z27rLVxGVTjL+L7S42s5yjA12XMcqisVNyYNxLh1UVzIUu SMSSHvuJ21dinoFVR2J2jNdyPwQCtSRB12cgfgWwVSpMaAP9f/NpsyeX9+GY6dyLSpHU KDu4RzwuwiBRqsxrfOHBoj/kBFcahpuwAbN8jR9kd83XHcp5WdQKaGarz46eO0kQjSJk 1qzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WGWLd0+jShEMqamKKIGP09d0KBoL7mk6mTTG8kNTb74=; fh=ad2OA34kW9lx5OokKR1Mp02R0ChuE5QaHwb8xE4nF7s=; b=Cj9XxK0uunylSdGxb5eHbOeyQd6pzPxoTbBl3+TY+FoFLdWOxWeiJxYekyM78+hCOC AxPAvUZnh+8oUmkLaPx9S/h89iaolussw/9y2zCOsQSNNXfEjFFqnUJTB0RtyWSgvGZ2 n7k9Cu4GrBY/cUPbq36JTgTmBQsHV2Zp4C7TWZ08xpoaLogDNobnJBANGT7mk0d10UiO o7n4uBXlk7A8STj1O+ERyAzxBxmbbVK+ZnvK3cHTG9/Yc7gtlRS59B+TLNMn5nIJKIG7 s1Si3ecPOm9zxiX0GMh1TnaeZXeBXZfZRBbCJW0ulSLEFiL3b31aphhANugkt4CJVELW bp2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oh3RBVdr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n21-20020a05622a11d500b0043476f3eed7si5106240qtk.669.2024.04.08.05.37.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 05:37:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oh3RBVdr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3404-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 922241C20F0B for ; Mon, 8 Apr 2024 12:37:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 758926E61E; Mon, 8 Apr 2024 12:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Oh3RBVdr" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2CA6D1CC; Mon, 8 Apr 2024 12:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712579857; cv=none; b=CzU9YRrJUtI7GTpM5quDbCNj4X9gPXi89JHnx7s+iRCEAovIuDqlIhLCarvbqsrDUYrrWFs5QU8ba9MN41ZyoDD+FrQTyxigZ34Lzh9scLbnqf6nobFmiU29vOg+eMLFkP99mDoOirI/a3kmAUWq73KmWQjNOY2mAiJjgYzicg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712579857; c=relaxed/simple; bh=eKyMOCTmzVpas0Ku4p4aIG2DFODmyGN4nePJuS4aVi4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ez138fxixe8afbqi2LcXnsIia5O/nwN9Kpu9g+iuA3HQXlV5TjceHh1y0PL83x+gi1FIsliJb47SGbM4c3rxTSo5SsE2Ry013gy/lcZIdhJmnPWPT3nwQCitZEmzPIq5IOtu5BKUmAKh0F4XtHMOP3N8M16EpzHLz35L7rSZckM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Oh3RBVdr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AF87C43330; Mon, 8 Apr 2024 12:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712579856; bh=eKyMOCTmzVpas0Ku4p4aIG2DFODmyGN4nePJuS4aVi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oh3RBVdrQUr0HMr7a6y+Rg3f9nttVQFy1Q16vLI3P/3flHrCAI5uw9qF8pmkzecAa brNKRKJBx7iFo+WzQ8EsitaTQaQZauWSZiEYzsbxIRo8E6E6nDFa0OtQ7Ft45XJM2p 5ld8UnVNfTcs6T61SlF/AxllTzz6Ya4vlBVm/5jk5Pcf26wpusITKcIej73GuZbi89 CSIxAtA8dqfz2wPo6z1mVtGb6Q6dhQA0PiuQts4LvYFcVQZodZBIbRSnLyLvYHSVQ6 Vk/5TcYcsOO3g1a1ilIy4fndG7dx8W1AKKgdMJv0vrMJua/SeKrvFTqAf0l6F5Qc9w oeYc1WlYHNyYg== Date: Mon, 8 Apr 2024 08:37:34 -0400 From: Eric Biggers To: Stefan Kanthak Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, tim.c.chen@linux.intel.com, sean.m.gulley@intel.com Subject: Re: [PATCH 1/2] crypto: s(h)aving 40+ bytes off arch/x86/crypto/sha256_ni_asm.S Message-ID: <20240408123734.GB732@quark.localdomain> References: <5EEE09A9021540A5AAD8BFEEE915512D@H270> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5EEE09A9021540A5AAD8BFEEE915512D@H270> On Mon, Apr 08, 2024 at 11:26:52AM +0200, Stefan Kanthak wrote: > Use shorter SSE2 instructions instead of some SSE4.1 > use short displacements into K256 > > --- -/arch/x86/crypto/sha256_ni_asm.S > +++ +/arch/x86/crypto/sha256_ni_asm.S Thanks! I'd like to benchmark this to see how it affects performance, but unfortunately this patch doesn't apply. It looks your email client corrupted your patch by replacing tabs with spaces. Can you please use 'git send-email' to send patches? - Eric