Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1989957lqe; Tue, 9 Apr 2024 06:47:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXnPxfvd/vauW0oHXqRzgetpRlF2tyto7q+FXEzmbCxctCoc1wD+NRwN7J9bH3mBUkPxKs+sKV1zmrRzX0tY3VSYfcP8JtKEbSWHnxxGQ== X-Google-Smtp-Source: AGHT+IHg5x8LCTk2lUBzJuMMxp5AMKzqxZa0pk8IQNifLBFxSGHeKEhkRy4aore530Wh7utRdLD2 X-Received: by 2002:a05:620a:470e:b0:78d:6ba0:47d4 with SMTP id bs14-20020a05620a470e00b0078d6ba047d4mr3447468qkb.74.1712670448696; Tue, 09 Apr 2024 06:47:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712670448; cv=pass; d=google.com; s=arc-20160816; b=QGCbg45QB68CEpBUt3B4JyNHk6aydm1xvh26cpT8SMMlVN1ZNy4bCwoSzGYWF58qwP ETRFxttbU+vVRDzdnJYrtvANBQxPgFGS3cS8/hJQdLRSoGlPo4P/IwQVaOHsqNd7Fjjx VrnWWDGfbCps7FUw/cte1IIWL/7QMneyL8xx9SlKbMqY3eMXqQHCLy9T5fcDXgRFJNDJ 6IXVH4FTImx/Tf/11mYqfPFeHsS0zi/4aLibtnj+2B+v3uZ218MLMjggsXH4gAmgiJsg dpdCbRaE8GzNa+98TxOGSl81Qg2I4exWTyqme3fZlCBtb3Te83dLoYQ54LwICXbqwbOd 05Uw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:date:subject:cc:to :from:dkim-signature; bh=EqPE8k2XuYVTtDepIsOZ9NsJpR3M/yKeP15J7IxBfJU=; fh=wXTqhI4uuRFRAXBybgx+FOtlQ63Ips+Q8L7FRJ2w3gM=; b=yFTsjo15lwhSt0VQS67lni9NdvVmYzrWleO/jumNMxo+Y/OfFduXdo11K5D15cOR/A Eyo4C4xnslv3DJuB/AxtmRCorh44Ko5iJ2rZ4vwFdSunY1gbR5lnDJh1geCeqVC6S6/Z vIAJDbXQ3yEGfdEMBfxUKI+6Hjswk3VKiMtQIo2veCEHHX9aC1E3zCBLKa2r7w/R9+jy Cvn2Pty4EaFVt5MM9J+040651X6n5QPQUfCKpN1IYLeoZljxvl+DhgODtk2cLqeQ0foA oeKtko/LUQaye3Zj99AKAvI1CiDStdTnt+SOJcQlwkjjyfeBGxPCfwBlYF2AWSFOE3iC weag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nexgo.de header.s=vfde-mb-mr2-23sep header.b=OshMzrSd; arc=pass (i=1 spf=pass spfdomain=nexgo.de dkim=pass dkdomain=nexgo.de); spf=pass (google.com: domain of linux-crypto+bounces-3407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3407-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bi24-20020a05620a319800b0078a025958fdsi11207132qkb.275.2024.04.09.06.47.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 06:47:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@nexgo.de header.s=vfde-mb-mr2-23sep header.b=OshMzrSd; arc=pass (i=1 spf=pass spfdomain=nexgo.de dkim=pass dkdomain=nexgo.de); spf=pass (google.com: domain of linux-crypto+bounces-3407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3407-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 141151C2217B for ; Mon, 8 Apr 2024 14:18:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C65EA86240; Mon, 8 Apr 2024 14:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nexgo.de header.i=@nexgo.de header.b="OshMzrSd" X-Original-To: linux-crypto@vger.kernel.org Received: from mr3.vodafonemail.de (mr3.vodafonemail.de [145.253.228.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB6912837C; Mon, 8 Apr 2024 14:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=145.253.228.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585897; cv=none; b=G/dG1MruRzwlgTmiva/0+i6ZJ7UM/iugfj7YT/Pjo9Fs9pzJtBdQuVcVS9Jl3W3tyPyxCAHM6x/clAe+3ZVWqI4kAydc66s0dKL2y5dXeWLFXDBGQkWad2dA53qjWJM2S3J4xd9AbowYj/HJcL+6ChzGaeW8QzacCXgVXQNjY8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712585897; c=relaxed/simple; bh=irgPcGQf2zed/zi+Zrwi80XgAyLN2AyMzpIrIbtSQE4=; h=From:To:Cc:Subject:Date:MIME-Version:Content-Type; b=AkJTqrWEfTWm8X7cp9gKftIqH6rIQXpSirMuPAxKI8FJZjSdeJviZ2f3pgNLh2/kRYAlqpXzGQkOlSsNlFonwNSdJfAtlwxUY9RAjuhsIrikmk4zV5Nu9gPplYLc0ge8j4xc9cdXc5SgsvyPE2dvl5WUjZBY0fh/RSoYtKhzwxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexgo.de; spf=pass smtp.mailfrom=nexgo.de; dkim=pass (1024-bit key) header.d=nexgo.de header.i=@nexgo.de header.b=OshMzrSd; arc=none smtp.client-ip=145.253.228.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexgo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexgo.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexgo.de; s=vfde-mb-mr2-23sep; t=1712585894; bh=EqPE8k2XuYVTtDepIsOZ9NsJpR3M/yKeP15J7IxBfJU=; h=From:To:Subject:Date:Content-Type:From; b=OshMzrSdvWGepEERjICWAnDNdMgEGg9erQFxL0W7p9k4rHL2ooehPhSX3pSBS/Dr/ Tks9PdY9KdTGSa6pR9a+kTwknWY8WSlkgE4faDpwchnPSLI9gLW5i0fFXZaI7TjeoZ wzWbGFN5TAOjZuVURdE/2JrzG4UmP6jRZQEWGQEI= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4VCrm60SJxz2Fmq; Mon, 8 Apr 2024 14:18:14 +0000 (UTC) Received: from sha1_ni_asm.patch (p5de6d4c4.dip0.t-ipconnect.de [93.230.212.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4VCrln1qV6z9thx; Mon, 8 Apr 2024 14:17:54 +0000 (UTC) From: "Stefan Kanthak" To: , Cc: , "Eric Biggers" Subject: [PATCH v2 1/2] crypto: s(h)aving 16 byte constant off arch/x86/crypto/sha1_ni_asm.S Date: Mon, 8 Apr 2024 16:08:52 +0200 Organization: Me, myself & IT Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 734 X-purgate-ID: 155817::1712585889-6FFFDA4B-A983EAB5/0/0 Message-Id: <20240408141817.C65EA86240@smtp.subspace.kernel.org> Get rid of 16 byte constant, use shift instead of mask --- -/arch/x86/crypto/sha1_ni_asm.S +++ +/arch/x86/crypto/sha1_ni_asm.S @@ -104,9 +104,9 @@ add DATA_PTR, NUM_BLKS /* pointer to end of data */ /* load initial hash values */ - pinsrd $3, 1*16(DIGEST_PTR), E0 + pinsrd $0, 1*16(DIGEST_PTR), E0 movdqu 0*16(DIGEST_PTR), ABCD - pand UPPER_WORD_MASK(%rip), E0 + pslldq $12, E0 pshufd $0x1B, ABCD, ABCD movdqa PSHUFFLE_BYTE_FLIP_MASK(%rip), SHUF_MASK @@ -297,8 +297,3 @@ .align 16 PSHUFFLE_BYTE_FLIP_MASK: .octa 0x000102030405060708090a0b0c0d0e0f - -.section .rodata.cst16.UPPER_WORD_MASK, "aM", @progbits, 16 -.align 16 -UPPER_WORD_MASK: - .octa 0xFFFFFFFF000000000000000000000000