Received-SPF: pass (google.com: domain of linux-crypto+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7143e83261b20f281fcb5913a23c785199ade357.camel@linux.intel.com>
Subject: Re: [PATCH 3/3] crypto: x86/sha512-avx2 - add missing vzeroupper
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Eric Biggers <ebiggers@kernel.org>, linux-crypto@vger.kernel.org
Cc: x86@kernel.org
Date: Tue, 09 Apr 2024 15:38:44 -0700
In-Reply-To: <20240406002610.37202-4-ebiggers@kernel.org>
References: <20240406002610.37202-1-ebiggers@kernel.org>
	 <20240406002610.37202-4-ebiggers@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-04-05 at 20:26 -0400, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>=20
> Since sha512_transform_rorx() uses ymm registers, execute vzeroupper
> before returning from it.  This is necessary to avoid reducing the
> performance of SSE code.
>=20
> Fixes: e01d69cb0195 ("crypto: sha512 - Optimized SHA512 x86_64 assembly r=
outine using AVX instructions.")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  arch/x86/crypto/sha512-avx2-asm.S | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-a=
vx2-asm.S
> index f08496cd6870..24973f42c43f 100644
> --- a/arch/x86/crypto/sha512-avx2-asm.S
> +++ b/arch/x86/crypto/sha512-avx2-asm.S
> @@ -678,10 +678,11 @@ SYM_TYPED_FUNC_START(sha512_transform_rorx)
>  	pop	%r14
>  	pop	%r13
>  	pop	%r12
>  	pop	%rbx
> =20
> +	vzeroupper
>  	RET
>  SYM_FUNC_END(sha512_transform_rorx)
> =20
>  ########################################################################
>  ### Binary Data

Acked-by: Tim Chen <tim.c.chen@linux.intel.com>