Received-SPF: pass (google.com: domain of linux-crypto+bounces-3443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Gaurav Jain <gaurav.jain@nxp.com>
To: Pankaj Gupta <pankaj.gupta@nxp.com>, Horia Geanta <horia.geanta@nxp.com>,
	Varun Sethi <V.Sethi@nxp.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, "davem@davemloft.net" <davem@davemloft.net>,
	Iuliana Prodan <iuliana.prodan@nxp.com>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v2] caam: init-clk based on caam-page0-access
Thread-Topic: [PATCH v2] caam: init-clk based on caam-page0-access
Thread-Index: AQHaix0ngiIpygDrSUiyyhiPAYwZZrFhXRsA
Date: Wed, 10 Apr 2024 11:25:41 +0000
Message-ID:
 <AM0PR04MB6004F1C5AC6CE78447FF555BE7062@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <20240410075815.4030570-1-pankaj.gupta@nxp.com>
In-Reply-To: <20240410075815.4030570-1-pankaj.gupta@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?TcEdoe6MnejzuQklJ3BDvJ3xSYxBdgVNTxN/NIMZuIG2aM+kL8br4St96n0M?=
 =?us-ascii?Q?O8kygaHmvc8xz0ICBCartAu8uXQU2IehHOPr+AjfKRiU8tCQYLDIrImAL05i?=
 =?us-ascii?Q?uBChSl6DkTMKrcjq/cUc+dC+VJquUYWqk+E44Z8yK9A8IRNx7tLumlRb+CfE?=
 =?us-ascii?Q?yED6+UoUsp0KO2MW4LtE4NYNYQuniZRAiMMOQg+Iy2ZW/+shHYnCln31in3+?=
 =?us-ascii?Q?decPmGCJMy5REeWV03ck3f+wzanSm1JgjC27Bah7q8WcCtdoEY7itqLuB6T2?=
 =?us-ascii?Q?XMhYGmYvRaFalnTLXefDEIkedU7qbgfkkD8ixqGFKub+lw/rY/7d76HifmXP?=
 =?us-ascii?Q?2E89SaqSi5D57WN+hZoQu1ogf2yTaGYd2fnlI8SexJ71Q4dRUDsxdb3IXtUw?=
 =?us-ascii?Q?YmmfGyVrD3jq4mMenMkOxijoRELC1JoCZ306BJlemZLhEDwdOxFo588Phn0p?=
 =?us-ascii?Q?q42mMaCcg7pTEBOkBQZ9OUK0Y9IudJcv8WQ+Mxr9mb5cqPcf47hqWRmV2KaG?=
 =?us-ascii?Q?z/gBDd+I/c/hMmmPMyvxT8k+WYjLltgyKFFZiQZVmcnj18WLjjARBFljWFv7?=
 =?us-ascii?Q?VxdMJweirCxnLiS7bZwklDw7dg5g6JLsVlPR+ZKERNrjFQrvPECApekYfel9?=
 =?us-ascii?Q?rLkd/Z0GZ25FL+PPHfiEicXCntgcslJLGJEBkWY+Ak+8VzYITxDKx64r3Wxs?=
 =?us-ascii?Q?JhkwZXrapy1gM3jOtvrm9gowS0RPzP0KVRWNTrbJYD3orHFnTqbbqei7ur+0?=
 =?us-ascii?Q?rmIrZ5Gg/sufKITmVl7UqUrXaeDbU1yY+XAqn6gSZXcDIDCfRZrU7SrLtuhU?=
 =?us-ascii?Q?W/r+/03567u20qTaoBCiPMedz8LIypxp81jJMBtnqGd/uDEt4bSmKwd6r4Gj?=
 =?us-ascii?Q?m+0vI6qk06Q3sJBksEwF9fcQb8Wj94Ivhhu12kTwH+I+ZBkg318zxKNz0G+s?=
 =?us-ascii?Q?SZm7gqKUF/6oX+b6CNkBcj49vFT1Y7wr0ZK4DIAEuDpxkEeVb+gHFH1I29o9?=
 =?us-ascii?Q?YcFFjBwhTNj/hCLF0g6bpGKxIxyV9JjDOzdHT+j7EZdMvtVDqwkGrB4jFcRL?=
 =?us-ascii?Q?zEvMP3pydrWbgkQDssmvhOcRwaZklHwWsfpWGYvE7dKcZO19V5P54m9kziN7?=
 =?us-ascii?Q?4akIY3cJdZNInoudXQMX0C0Vsa8zbGDyuidId2sF6V9QuMr3mkW+UtJrki95?=
 =?us-ascii?Q?iLphD2w3ON5r9ovzsbmEMwGfxza7C5Ssb4tDQBAOg27rgPMhl58hSA2RYMeP?=
 =?us-ascii?Q?rajlzrGwI+VMvPrOA4GzyFHlucp/CdyGuwmAS1bXF4mh9zBKtudnnAv0V7xM?=
 =?us-ascii?Q?NwtmjoR3+T5ropM230wG4m+/EyHCW7viAKA2dQVGbUuGgooY9ZIijVv7W4ns?=
 =?us-ascii?Q?zSeQjJapGQVGiKOYLoXsEz29tbK2Ht63m4J8zAbyRMXmEp5vy5gJR51pER5a?=
 =?us-ascii?Q?qREkRlEM2VJ+jt0aqJkemAOVXeSCeWMysUIgFuiUNYtVWmgUBCarT4BxVrGW?=
 =?us-ascii?Q?qBBnpP4kLQvnkq9weU6aC3fLuaaJWHvTX5PnQLU431cqGomyEt9WWfsBdD70?=
 =?us-ascii?Q?9howI0ri/b8n6RaSUze033fLghklBH7lMUh6xpom?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5cb7e23-da0d-4872-98ba-08dc5950f4b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2024 11:25:41.6849
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dPHGx+/6APXhvfNkf7FNQWTZRDN5XsfMBLJm3AXdAFTIpKyC3L2VeXBOZ2YQAft4H0AkuSWVnLzvAUjbnOLVnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8444

Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Pankaj Gupta <pankaj.gupta@nxp.com>
> Sent: Wednesday, April 10, 2024 1:28 PM
> To: Gaurav Jain <gaurav.jain@nxp.com>; Horia Geanta <horia.geanta@nxp.com=
>;
> Varun Sethi <V.Sethi@nxp.com>; herbert@gondor.apana.org.au;
> davem@davemloft.net; Iuliana Prodan <iuliana.prodan@nxp.com>; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx <linux=
-
> imx@nxp.com>
> Cc: Pankaj Gupta <pankaj.gupta@nxp.com>
> Subject: [PATCH v2] caam: init-clk based on caam-page0-access
>=20
> CAAM clock initialization to be done based on, soc specific info stored i=
n struct
> caam_imx_data:
> - caam-page0-access flag
> - num_clks
>=20
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> ---
> v2:
>  - Considering the OPTEE enablement check too, for setting the
>    variable 'reg_access'.
>=20
>  drivers/crypto/caam/ctrl.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c inde=
x
> bdf367f3f679..355ff92f4549 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -512,6 +512,7 @@ static const struct of_device_id caam_match[] =3D
> {  MODULE_DEVICE_TABLE(of, caam_match);
>=20
>  struct caam_imx_data {
> +	bool page0_access;
>  	const struct clk_bulk_data *clks;
>  	int num_clks;
>  };
> @@ -524,6 +525,7 @@ static const struct clk_bulk_data caam_imx6_clks[] =
=3D {  };
>=20
>  static const struct caam_imx_data caam_imx6_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx6_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx6_clks),  }; @@ -534,6 +536,7 @@
> static const struct clk_bulk_data caam_imx7_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_imx7_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx7_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx7_clks),  }; @@ -545,6 +548,7 @@
> static const struct clk_bulk_data caam_imx6ul_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_imx6ul_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx6ul_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx6ul_clks),  }; @@ -554,15 +558,23
> @@ static const struct clk_bulk_data caam_vf610_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_vf610_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_vf610_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_vf610_clks),  };
>=20
> +static const struct caam_imx_data caam_imx8ulp_data =3D {
> +	.page0_access =3D false,
> +	.clks =3D NULL,
> +	.num_clks =3D 0,
> +};
> +
>  static const struct soc_device_attribute caam_imx_soc_table[] =3D {
>  	{ .soc_id =3D "i.MX6UL", .data =3D &caam_imx6ul_data },
>  	{ .soc_id =3D "i.MX6*",  .data =3D &caam_imx6_data },
>  	{ .soc_id =3D "i.MX7*",  .data =3D &caam_imx7_data },
>  	{ .soc_id =3D "i.MX8M*", .data =3D &caam_imx7_data },
> +	{ .soc_id =3D "i.MX8ULP", .data =3D &caam_imx8ulp_data },
>  	{ .soc_id =3D "VF*",     .data =3D &caam_vf610_data },
>  	{ .family =3D "Freescale i.MX" },
>  	{ /* sentinel */ }
> @@ -860,6 +872,7 @@ static int caam_probe(struct platform_device *pdev)
>  	int pg_size;
>  	int BLOCK_OFFSET =3D 0;
>  	bool reg_access =3D true;
> +	const struct caam_imx_data *imx_soc_data;
>=20
>  	ctrlpriv =3D devm_kzalloc(&pdev->dev, sizeof(*ctrlpriv), GFP_KERNEL);
>  	if (!ctrlpriv)
> @@ -889,7 +902,15 @@ static int caam_probe(struct platform_device *pdev)
>=20
>  		reg_access =3D !ctrlpriv->optee_en;
>=20
> -		if (!imx_soc_match->data) {
> +		if (imx_soc_match->data) {
> +			imx_soc_data =3D imx_soc_match->data;
> +			reg_access =3D reg_access && imx_soc_data-
> >page0_access;
> +			/*
> +			 * CAAM clocks cannot be controlled from kernel.
> +			 */
> +			if (!imx_soc_data->num_clks)
> +				goto iomap_ctrl;
> +		} else {
>  			dev_err(dev, "No clock data provided for i.MX SoC");
>  			return -EINVAL;
>  		}
> @@ -899,7 +920,7 @@ static int caam_probe(struct platform_device *pdev)
>  			return ret;
>  	}
>=20
> -
> +iomap_ctrl:
>  	/* Get configuration properties from device tree */
>  	/* First, get register page */
>  	ctrl =3D devm_of_iomap(dev, nprop, 0, NULL);
> --
> 2.34.1