Received-SPF: pass (google.com: domain of linux-crypto+bounces-3360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 5 Apr 2024 15:57:16 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Joachim Vandersmissen <git@jvdsn.com>
Cc: linux-crypto@vger.kernel.org,
	Salvator Benedetto <salvatore.benedetto@intel.com>
Subject: Re: [PATCH v2] crypto: ecdh - explicitly zeroize private_key
Message-ID: <Zg+u3J1urW0z0C4L@gondor.apana.org.au>
References: <20240328162430.28657-1-git@jvdsn.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240328162430.28657-1-git@jvdsn.com>

On Thu, Mar 28, 2024 at 11:24:30AM -0500, Joachim Vandersmissen wrote:
> private_key is overwritten with the key parameter passed in by the
> caller (if present), or alternatively a newly generated private key.
> However, it is possible that the caller provides a key (or the newly
> generated key) which is shorter than the previous key. In that
> scenario, some key material from the previous key would not be
> overwritten. The easiest solution is to explicitly zeroize the entire
> private_key array first.
> 
> Note that this patch slightly changes the behavior of this function:
> previously, if the ecc_gen_privkey failed, the old private_key would
> remain. Now, the private_key is always zeroized. This behavior is
> consistent with the case where params.key is set and ecc_is_key_valid
> fails.
> 
> Signed-off-by: Joachim Vandersmissen <git@jvdsn.com>
> ---
>  crypto/ecdh.c | 2 ++
>  1 file changed, 2 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt