Received-SPF: pass (google.com: domain of linux-crypto+bounces-3507-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.7\))
Subject: Re: [PATCH v3 05/10] crypto: riscv - add vector crypto accelerated
 ChaCha20
From: Jerry Shih <jerry.shih@sifive.com>
In-Reply-To: <tencent_C7B10C572AA62E84ABF1818F52904DFBCA05@qq.com>
Date: Fri, 12 Apr 2024 16:07:26 +0800
Cc: Eric Biggers <ebiggers@kernel.org>,
 Andy Chiu <andy.chiu@sifive.com>,
 Albert Ou <aou@eecs.berkeley.edu>,
 ardb@kernel.org,
 christoph.muellner@vrull.eu,
 heiko@sntech.de,
 hongrong.hsu@sifive.com,
 linux-crypto@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 linux-riscv@lists.infradead.org,
 palmer@dabbelt.com,
 paul.walmsley@sifive.com,
 phoebe.chen@sifive.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <36AECE24-69F7-4A95-A9C5-E1EFBE05DE9B@sifive.com>
References: <20240122002024.27477-6-ebiggers@kernel.org>
 <tencent_C7B10C572AA62E84ABF1818F52904DFBCA05@qq.com>
To: Yangyu Chen <cyy@cyyself.name>

On Apr 12, 2024, at 15:59, Yangyu Chen <cyy@cyyself.name> wrote:
> On 2024/1/22 08:19, Eric Biggers wrote:> From: Jerry Shih =
<jerry.shih@sifive.com>
>>=20
>> Add an implementation of ChaCha20 using the Zvkb extension.  The
>> assembly code is derived from OpenSSL code (openssl/openssl#21923) =
that
>> was dual-licensed so that it could be reused in the kernel.
>> Nevertheless, the assembly has been significantly reworked for
>> integration with the kernel, for example by using a regular .S file
>> instead of the so-called perlasm, using the assembler instead of bare
>> '.inst', and reducing code duplication.
>>=20
>> Signed-off-by: Jerry Shih <jerry.shih@sifive.com>
>> Co-developed-by: Eric Biggers <ebiggers@google.com>
>> Signed-off-by: Eric Biggers <ebiggers@google.com>
>> ---
>=20
> Hi, Jerry Shih and Eric Biggers,
>=20
> Since this implementation is derived from OpenSSL, I have an issue on
> OpenSSL about this chacha20 implementation using Zvkb [1] and see a =
fixes
> PR by Jerry Shih [2].
>=20
> I wonder will kernel need to port those fixes to handle the =
non-multiple
> block length of the chacha20 cipher? If yes, we should port it =
immediately
> to catch up with the v6.9 release if we can.
>=20
> [1] https://github.com/openssl/openssl/issues/24070
> [2] https://github.com/openssl/openssl/pull/24097
>=20
> Thanks,
> Yangyu Chen
>=20

There is no non-multiple block size issue here. It's already handled by =
the gluing part.

=
https://github.com/torvalds/linux/blob/586b5dfb51b962c1b6c06495715e4c4f76a=
7fc5a/arch/riscv/crypto/chacha-riscv64-glue.c#L45-L53

-Jerry=