Received-SPF: pass (google.com: domain of linux-crypto+bounces-3560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8fbab9e8-a2fc-4fb2-a9c3-e7336fa50118@intel.com>
Date: Mon, 15 Apr 2024 15:16:18 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 00/14] x86: Support Key Locker
To: Eric Biggers <ebiggers@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
	<dm-devel@redhat.com>, <luto@kernel.org>, <dave.hansen@linux.intel.com>,
	<tglx@linutronix.de>, <bp@alien8.de>, <mingo@kernel.org>, <x86@kernel.org>,
	<herbert@gondor.apana.org.au>, <ardb@kernel.org>, <elliott@hpe.com>,
	<dan.j.williams@intel.com>, <bernie.keany@intel.com>,
	<charishma1.gairuboyina@intel.com>
References: <20230603152227.12335-1-chang.seok.bae@intel.com>
 <20240329015346.635933-1-chang.seok.bae@intel.com>
 <13bb2f0f-5894-4366-be53-44658144a23d@intel.com>
 <20240408014806.GA965@quark.localdomain>
Content-Language: en-US
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240408014806.GA965@quark.localdomain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzg4RDhocVBZRzNVeEl6dWFuNFZBNkpYcUxOVm1pcDdlaFpjem84cXdua2tn?=
 =?utf-8?B?VXdCS3J1LzkzWTRvdVV0TTRiTmoxTWtDZ0dGbjUzTlEzbVYxR2YyMGVPK25i?=
 =?utf-8?B?VnA5OFdyVXFFVzlhK2FXR3VOL0tJYWJ1Ym8xcDVRdWd2WlRtWThuZXZ0R3Y1?=
 =?utf-8?B?dGdWU1MvWXYxeTdpYkdSK2xHajFGZ0RZUmVEZXI1SnBOZDA3NXBYZFV4S25h?=
 =?utf-8?B?ZkhvR0ZMUHRaMHQ5WWpKVTRHY2g0S2IzZlNqd004dzdkbHJ3YnN4dExBbVBE?=
 =?utf-8?B?UEIwY2o4dGFpZDNSakl4b0s0VlRaVzRFcUpKQnVVVkNQT2JUaTk5U1JtMmRI?=
 =?utf-8?B?TFc0T3pPUXdjb1U0Vy9mNzJKWXJ3VTJGUzdjSEt2KytoRGN5NU9RTTFhRERs?=
 =?utf-8?B?WDhFNWdtSmNxY2s1T0E5UloxRExiSytWMmw0d1FldFUwVlpwSHUvZ2hkU1VJ?=
 =?utf-8?B?SCthYWdTTmw2TGNIWlRNN2ZtSGpMVmFLYVU0ZnZyUGgwdm9DbkVmaDBNempp?=
 =?utf-8?B?bWxqWnpVSnREWStiQVhqYnAycEltd1BRM3VjVmozUHZuS3RIZHhIb25tNnBy?=
 =?utf-8?B?QWlrVzJqbWFCekRqblpMUDRkTXZVNHdiU3F5SEpDS29NZi9qVldobDFGeHRa?=
 =?utf-8?B?VTdJMldZZ3ZnUkR6d1NYREs3ZFlOU3J0MVN2OGNoaGx1Z2gvSjY4RHF0dnZT?=
 =?utf-8?B?TFB2VURLeEl5bE5jMVV4dVVudUltZ3I4ZTU2dUR0aVlTTWdkZDhqSXhzUTMx?=
 =?utf-8?B?UkZZbWM5OFdWWXIxR1Q1Rml4UkJ2OWZ2T1BoWW9zT3VzM0JSbk5hRmNmWlFB?=
 =?utf-8?B?VjlRMWRRdkRhbWN4bUNhR0VRZDNPOEZGQUNuelpScGxzbnU0eHZlQWdYeERE?=
 =?utf-8?B?bURyVFVOYi9rTmJKZ2JkTFZiemhIT0hHZy9FeWM4OXZTU1M4MFRZVVRLclFD?=
 =?utf-8?B?eW9KRU5sclJ3bzRRWTA5ZVY1cnFMOFpCUVlWUWFYK1lSaWV1eE16UG8wN0lV?=
 =?utf-8?B?Vk5vK2hkaTZrdmhBczk5WlpBR3lGV3FBRWVVUGhnR0ZSYUNTS0cvTjhvSUV5?=
 =?utf-8?B?MGhHdVRQVEZpTVR6SE1yQTljNG9SUlVZQnRvUEU0cjB1QW5nVmVtSWFSU3ZY?=
 =?utf-8?B?S05HNlFwSUdqZncwZkFPT2V6SmE3MGpiVk92NTEyUHVMaUZxcUZiME9WNWZX?=
 =?utf-8?B?R0F6bEJpemV2OUZQZE9ocnNaanorVGplWUQxN3BkTDBQQkErZ3NoSVlERlB2?=
 =?utf-8?B?clBxa3F4OXFSbDQzNC9uWEdsd3N3ZENEY2lCZ2tYMUtiaWxBT3ZlMGhqdzha?=
 =?utf-8?B?WGltQXhHYS9MVDd5NUZBS2ZsdEdNM1VNTjNJbHk3VkJrd1ZhYVUyTEZIYWZv?=
 =?utf-8?B?NHVPcnNuTzU4NE82WnNObFhtOVQrQ1BxaWpORExBWWVIUXJpd1podzRBMzJj?=
 =?utf-8?B?N2hHV0pFcncrcElGZThnV29tbVRUZ1BsbEZQZGJuWkpzb1dKVUEvR1JrZnk4?=
 =?utf-8?B?Y3hnSEFJWldyalllOEluRlhpNVNKRUZobnRPUkhKOWtlWEtPYmkvbFUweEpY?=
 =?utf-8?B?M2lTaG42OGZTMHdnbHNQeitOMWprV1M3RUk5d29LS2Nzc1lvM28yN2s4Vk1M?=
 =?utf-8?B?NnU4M2U3MCtRSE5XcEx3dmJCcFBKNk9pQmxQTUFvd21IUjE5eXpEVlVuck5q?=
 =?utf-8?B?UVVNcFhnS3pZL1kxd1VTeWdEZWs0OE5wNUZDaXkzY0VPMzhVT1hKenVrMGQ4?=
 =?utf-8?B?TDM3YWNwVkkxbUd5eFBBY3NqWkRHczZWUE1OcmNOd2tRS2FVM3Fta3lmeDdZ?=
 =?utf-8?B?SkJaV1liNWkzOWRlMCtzNlBFZFQvSmprWmN1WFAzMXUzQmhkSlhjSDVTeHFQ?=
 =?utf-8?B?OWdSZG9vbEJnMzA2K1ZaaGpFWndLeUgzSlV4TC9hN05iUWxZMUY0a0d0UU9E?=
 =?utf-8?B?Z1J3eUdmMVdlTnF1NW9JdHFJbUR1ZmtEaVJibHl0OWJDMnpYaWtOUzVpZDNt?=
 =?utf-8?B?cUJ5VFBNVTJvc3hIZ2RqM3J0ZE5ZSzNRVUw3YlZ5Ulg2QmJnUUVaTmtHbFVw?=
 =?utf-8?B?SnZ5TDFjVERhSVlqeVRPMzVZWG9wUTJyUERDS2YvRVRSMXhLb2ZDQWp4WnJT?=
 =?utf-8?B?b1gxdUhyczljeVpQbGVucjlYeHhMWnd4bjgzY2VOdFBkTGJWaVhMbUJxOFc1?=
 =?utf-8?B?TVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a41cfffc-1ecd-4b88-5b26-08dc5d99ae92
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 22:16:22.2116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5TCvwmZMlTYMEy4uNbxocDH4BtCE7JPpXajyjpyIgXoRmSQBss8pHCwVRIYDioYvRJXdL79aBueDcAM3V0zPMlr2keJ2D9AG2KZp85lQG+s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983
X-OriginatorOrg: intel.com

Hi Eric,

Sorry for my delay. I just found your message in my cluttered junk 
folder today after returning from my week off.

On 4/7/2024 6:48 PM, Eric Biggers wrote:
> 
> Do you have a plan for how this will be merged?  Which trees will the patches go
> through?  I think that the actual AES-XTS implementation could still use a bit
> more polishing; see my comments below.  However, patches 1-12 don't need to wait
> for that.  Perhaps the x86 maintainers would like to take patches 1-12 for
> v6.10?  Then the AES-XTS support can go through the crypto tree afterwards.

Yeah, this series spans both x86 code and the crypto driver. I believe 
the decision should be made by maintainers. But, I suspect they'll want 
to see a well-established use case code before moving forward.

> As you noticed, this cycle I've been optimizing AES-XTS for x86_64 by adding new
> VAES and AES-NI + AVX implementations.  I have some ideas for the Key Locker
> based implementation of AES-XTS:

Thanks for the effort! I agree that the code could be beneficial for 
daily disk encryption needs.

> First, surely it's the case that in practice, all CPUs that support Key Locker
> also support AVX?  If so, then there's no need for the Key Locker assembly to
> use legacy SSE instructions.  It should instead target AVX and use VEX-coded
> instructions.  This would save some instructions and improve performance.

Unfortunately, the Key Locker instructions using the AVX states were 
never implemented.

> Since the Key Locker assembly only supports 64-bit mode, it should also feel
> free to use registers xmm8-xmm15 for purposes such as caching the XTS tweaks.
> This would improve performance.
> 
> Since the Key Locker assembly advances a large number of XTS tweaks at a time
> (8), I'm also wondering if it would be faster to multiply by x^8 directly
> instead of multiplying by x sequentially eight times.  This can be done using
> the pclmulqdq instruction; see aes-xts-avx-x86_64.S which implements this
> optimization.  Probably all CPUs that support Key Locker also support PCLMULQDQ.

I'll revisit the assembly code to incorporate your suggestions.

> I'm also trying to think of the best way to organize the Key Locker AES-XTS glue
> code.  I see that you're proposing to share the glue code with the existing
> AES-XTS implementations.  Unfortunately I don't think this ends up working very
> well, due to the facts that the Key Locker code can return errors and uses a
> different key type.  I think that for now, I'd prefer that you simply copied the
> XTS glue code into aeskl-intel_glue.c and modified it as needed.  (But make sure
> to use the new version of the glue code, which is faster.)

I agree; the proposed glue code looks messy due to the different return 
errors and key types. Ard made a point earlier about establishing a 
shared common code as they're logically quite similar. But I suppose it 
is more practical to pursue a separate glue code at this point.

> For falling back to AES-NI, I think the cleanest solution is to call the
> top-level setkey, encrypt, and decrypt functions (the ones that are set in the
> xts-aes-aesni skcipher_alg), instead of calling lower-level functions as your
> current patchset does.

Yes, falling back is indeed one of the ugly parts of this series. Let me 
retry this as you suggested.

> If you could keep the Key Locker assembly roughly stylistically consistent with
> the new aes-xts-avx-x86_64.S, that would be great too.

Okay.

> Do you happen to know if there's any way to test the Key Locker AES-XTS code
> without having access to a bare metal machine with a CPU that supports Key
> Locker?  I tried a Sapphire Rapids based VM in Google Compute Engine, but it
> doesn't enumerate Key Locker.  I also don't see anything in QEMU related to Key
> Locker.  So I don't currently have an easy way to test this patchset.

No, there isn't currently an emulation option available to the public 
that I'm aware of. this feature has been available on client systems 
since the Tiger Lake generation.

> Finally, a high level question.  Key Locker has been reported to be
> substantially slower than AES-NI.  At the same time, VAES has recently doubled
> performance over AES-NI.  I'd guess this leaves Key Locker even further behind.
> Given that, how useful is this patchset?  I'm a bit concerned that this might be
> something that sounds good in theory but won't be used in practice.  Are
> performance improvements for Key Locker on the horizon?  (Well, there are the
> improvements I suggested above, which should help, but it sounds like main issue
> is the Key Locker instructions themselves which are just fundamentally slower.)

On our latest implementations, we've observed the Key Locker performance 
on cryptsetup seems to be roughly the same as what we posted earlier 
[2]. Yes, this sounds like a fair analogy to me, especially given your 
vAES code.

Thanks,
Chang

[1] 
https://lore.kernel.org/lkml/CAMj1kXGa4f21eH0mdxd1pQsZMUjUr1Btq+Dgw-gC=O-yYft7xw@mail.gmail.com/
[2] 
https://lore.kernel.org/lkml/20230410225936.8940-1-chang.seok.bae@intel.com/