Received-SPF: pass (google.com: domain of linux-crypto+bounces-3614-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 17 Apr 2024 14:42:14 +0200
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Babis Chalios <bchalios@amazon.es>
Cc: Alexander Graf <graf@amazon.de>, tytso@mit.edu, olivia@selenic.com,
	herbert@gondor.apana.org.au, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	sudanl@amazon.com, xmarcalx@amazon.co.uk, dwmw@amazon.co.uk
Subject: Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review
 easier
Message-ID: <Zh_Dpi630-LXJkJm@zx2c4.com>
References: <20240417081212.99657-1-bchalios@amazon.es>
 <20240417081212.99657-2-bchalios@amazon.es>
 <10d41e7e-87b1-4036-a740-da36270a4325@amazon.de>
 <2838b126-ad87-4642-9223-e24f3fdb2c63@amazon.es>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2838b126-ad87-4642-9223-e24f3fdb2c63@amazon.es>

On Wed, Apr 17, 2024 at 11:05:27AM +0200, Babis Chalios wrote:
> 
> 
> On 17/4/24 10:35, Alexander Graf wrote:
> >
> > On 17.04.24 10:12, Babis Chalios wrote:
> >> From: Sudan Landge <sudanl@amazon.com>
> >>
> >> Rearrage the functions of vmgenid to make the next commit,
> >> which re-implements vmgenid as a platform driver, easier to review.
> >>
> >> Signed-off-by: Sudan Landge <sudanl@amazon.com>
> >
> >
> > You can't sign off on behalf of someone else. The SoB here needs to be 
> > yours. If you are taking over this code from Sudan, I'd suggest to 
> > take over full ownership of it and put your own name as author and SoB 
> > in all patches.
> >
> 
> I thought about it and it seemed weird to me that I take over SoB and 
> authorship since I only touched one line in one of
> the patches, but I will be taking over the patches, so I can do that if 
> that's the way we things are done.
> 
> Does it make sense to at least add "Co-authored-by Sudan Landge 
> <sudanl@amazon.com>" here?

Wait, what? No. If you didn't write these patches, you're not the
author. Sudan is the author. However, if they passed through you, it's
fine to add your S-o-b. You can even mention the trivial change you made
between Sudan's S-o-b and your own.

Anyway, if there doesn't wind up being a need for another patchset, I
can fix this up upon committing to the tree.

Jason