Received-SPF: pass (google.com: domain of linux-crypto+bounces-3629-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240417104046.27253-1-bchalios@amazon.es> <20240417104046.27253-6-bchalios@amazon.es>
 <CAHmME9qHY_1JGDMyvEGB7XDu2DKaYQcPE3UfSfb4aVZkgC8Q=g@mail.gmail.com> <1fe62eb1-8ad5-4ced-9349-258cee9de663@kernel.org>
In-Reply-To: <1fe62eb1-8ad5-4ced-9349-258cee9de663@kernel.org>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Wed, 17 Apr 2024 18:11:05 +0200
Message-ID: <CAHmME9rtwMEBL-F5mQLuQREr=TqpuYChYn1rxpfGYqX11x-Efg@mail.gmail.com>
Subject: Re: [PATCH v6 5/5] virt: vmgenid: add support for devicetree bindings
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: sudanl@amazon.com, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, tytso@mit.edu, 
	olivia@selenic.com, herbert@gondor.apana.org.au, robh@kernel.org, 
	krzk+dt@kernel.org, conor+dt@kernel.org, linux-crypto@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, graf@amazon.de, 
	xmarcalx@amazon.co.uk, dwmw@amazon.co.uk, Alexander Graf <graf@amazon.com>, 
	Babis Chalios <bchalios@amazon.es>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Krzysztof,

On Wed, Apr 17, 2024 at 6:02=E2=80=AFPM Krzysztof Kozlowski <krzk@kernel.or=
g> wrote:
> Usually we do not recommend hiding code behind !CONFIG_OF because this
> limits possible usage on ACPI systems via PRP0001. Not sure if it is
> applicable here, because there is already ACPI matching.
>
> I would suggest choose whatever makes code simpler... Or just mark some
> pieces with __maybe_unused if they are really not used? That would avoid
> ifdeffery.

Interesting about PRP0001. Alright. It looks like I can't quite do
without ifdefs because the code dereferences ->handle in a acpi_device
struct, but I can minimize it all to just a single ifdef.

Jason