Received-SPF: pass (google.com: domain of linux-crypto+bounces-3637-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2698d178-a5b5-4f6a-80ae-e1d1d17495c2@nvidia.com>
Date: Wed, 17 Apr 2024 20:40:08 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] crypto: tegra - Fix some error codes
To: Dan Carpenter <dan.carpenter@linaro.org>, Akhil R <akhilrajeev@nvidia.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
 "David S. Miller" <davem@davemloft.net>,
 Thierry Reding <thierry.reding@gmail.com>, linux-crypto@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
References: <ec425896-49eb-4099-9898-ac9509f6ab8f@moroto.mountain>
From: Jon Hunter <jonathanh@nvidia.com>
Content-Language: en-US
In-Reply-To: <ec425896-49eb-4099-9898-ac9509f6ab8f@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZEE5ZW1uOTArNU95dmhwTFBqK0lmMDEzcHZ3ajZxQlpmVVdHSHlBUzZpLzVJ?=
 =?utf-8?B?TmhreWUvRHd5bHd1aVNoNWQyQzUrNzloL3QvMjk1cUFHYS90Z3hFRTZlbDd6?=
 =?utf-8?B?czlzR2ozV0N3UFdLbXJjU25kQ29XV3czQ0hMbUpqMThQRDBNQUNWMCt4OTlr?=
 =?utf-8?B?bWpHbndYR3czdW9USk9RUmVDRG9LNmFtSE5UV0sxQkNXTUFOSHVxMTBjZ0FH?=
 =?utf-8?B?OHh1YWhXbmRRMkZhd25LTlNRc0lONlU5VmFHZDcxQ0xZT1VmR2pBN2FpaTF2?=
 =?utf-8?B?Y0g0K0tSMkx5N0NELzR0SzJURDFJbVVGNHNsZG05aG9DMVpiUDhpNlcyeWMw?=
 =?utf-8?B?bURBcWY0ME5qY3FWNFNocWhPRENwdG1EVzJ4eWg2UCtneWtiOThURUNqT3VR?=
 =?utf-8?B?akN2dDJ2bVZsNUdCZ3FlZ1k4Q09IQ2VFOG5ESVZHblM1UEJsblVtd00wUEpt?=
 =?utf-8?B?NFVNODZTWHNmSjVzeFR0Nk5VVXc2akRDbEJnekxxTHErdEY2TGhoYys0L2VE?=
 =?utf-8?B?VmV1UmpVcUVYSmU5dUREdllZa3pPVmR2cHpzRnRSaWUyU2cxQXg1UENUWVlZ?=
 =?utf-8?B?NmN1VFZLaXBRcWFzK2EvUDdaY3ZWTWVvcE84dktqbnBScmpnUGNiOGtEai9r?=
 =?utf-8?B?d1Y1aTdmRjBMS2F3MjlCYVVOeFJaYTdlb0xFZjZsY1FaYURac09nWGZ3V01U?=
 =?utf-8?B?WlRwYVZHRXhXbnV0cGMwUEx3bUNUcEFJaGduODZvWExKc0c2VWxhdmtueHBQ?=
 =?utf-8?B?YVR5eTlqaFltZnBjVWhnUVI3MHFnS0hZUHhSOVl6ZlRxcFBoVk5mSHZVNkg4?=
 =?utf-8?B?Nnk5T2Z1d09BNGdFaXhxdDdjV212b0RaY010a0cwTVpEbm1CWWN2UlA3ZTV3?=
 =?utf-8?B?Wk1LUm02d2Rsa3dMWVU4cU9JZ2ZzOFNxNHEramZpUDZLUWlGcFVrRE5Hc2NM?=
 =?utf-8?B?UEdSeGlSWWxtMnZoRUNhNFlHTU1kNDYwVE1INkVNU0RFeXpQYUIwS1pkTkxW?=
 =?utf-8?B?VmpsNlYySDZNNWxSMVhGSVRCYkdrYit2RjVEanQ0Nmd5RjBpQ2RmRmw4SXdL?=
 =?utf-8?B?b05maFZXTS9YQkJuQ0NZREZvUlhUV2ZkV0daUzFibURGNlBmS3VQQ1Z3ZlpR?=
 =?utf-8?B?bC96N1lmcnMxSnZRUk5TVzBHRjNTSHpPZW5aK0RQc3FIVVRJMCtzai9hdHJ3?=
 =?utf-8?B?STBMbGNHT1QrNndSY3RoYUhXZUpZOXlaMHRqK3c0ODcyY1VFekpDVG1oN2Qz?=
 =?utf-8?B?aTltQ2E5bDA5YWU1KzFyaElhTlh3anRSYmlmTVMwc2F5MkFYSGVnZitLeUkx?=
 =?utf-8?B?TWpNUmF2NUVHMW1qeWxnWVcyYnhkUkNNU2svby9OUm9pSVF3UkdxTTE4M3ov?=
 =?utf-8?B?YzAvZHhKMktCTmVqMkVwd0U2NzFseTljdjVjbERSUjFLcmlJMHM2cW15L2Vi?=
 =?utf-8?B?M01lTTNyeDJrcEREZ1JsZ0tQRU8vbFFMbWZrdG82NjdvSXliTXFhbnVLNFVV?=
 =?utf-8?B?aXdPU204MFRLWGwvN2FPVDZ2TWJPWEJWTUQ3RlNTZUhLeTVZeVBManBITEc1?=
 =?utf-8?B?L3kwdUg5RWIyMUlzV0UvSWNtU0FSSWgwM2dHS3RKMXl2OWRrK2pNeEw2SVZ1?=
 =?utf-8?B?Z1NkNWR0bjl3MjI1aDdXVXFmL1V1cVZiek50TnowbjY0cTVZTmcxK0gvZXR5?=
 =?utf-8?B?dS9OTDBuaGlUbURJVnhxeU5iODB1WUhrbHQxOHN6NjRGUit2cEM5NGZxOE8z?=
 =?utf-8?B?S2xxOGpEdnJ0aVF0azdQNG1iTU9tckRVNUZXNE0zYTdqUHpyYnBkdVhCV1ZQ?=
 =?utf-8?B?NWFSeXNENnFNdW1oVmdZUVJ2ZWxVNWFSOSs4UzJhS3lTczBRWlh4dXA0QU9C?=
 =?utf-8?B?TVNrcjVrVjdVeGZiNzBDM1ZXV0MwQlFEcTVKazdQY3NlRmhaRFJ4UjJ6dTl0?=
 =?utf-8?B?L2VpQS9LaU94M0FNaTRPQmV2TEtLbkNaT3QrTjNVNUM4TzUyUS9DS3E0M0Vk?=
 =?utf-8?B?NVJZbyt1L1NVYkVoelgwSFhHU1RlMkpmcmdmNTFYS0pnTndSNklaQ3dqRmhB?=
 =?utf-8?B?T0lDbitkaXkyUUxrMHY5YlBUS0dtQzBDUDl3SW5BbkZqMWJIWXFKMk92R0Fm?=
 =?utf-8?B?a2dhN3hydHZvVm1UVmlpWEdPRFpnTUpsb1N3M1NkNk84am5vSmxHai9qR2xO?=
 =?utf-8?Q?5FYSBQDoyTKbRWhtAmB+BDaR08vzDsn5bpvTT0AkdWzf?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f81523bd-6b01-493a-210b-08dc5f16336d
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 19:40:13.8783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 30o5zfLEI/blb7TqtPYjMHfeoslWEwcvP4FovD1FHG6nY5WGDD7SiKnBsQk44A0rEJh/MzzJ37oXZmg/xFsxMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9027


On 17/04/2024 19:12, Dan Carpenter wrote:
> Return negative -ENOMEM, instead of positive ENOMEM.
> 
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/crypto/tegra/tegra-se-aes.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-aes.c
> index adc6cdab389e..ae7a0f8435fc 100644
> --- a/drivers/crypto/tegra/tegra-se-aes.c
> +++ b/drivers/crypto/tegra/tegra-se-aes.c
> @@ -1156,7 +1156,7 @@ static int tegra_ccm_do_one_req(struct crypto_engine *engine, void *areq)
>   	rctx->outbuf.buf = dma_alloc_coherent(ctx->se->dev, SE_AES_BUFLEN,
>   					      &rctx->outbuf.addr, GFP_KERNEL);
>   	if (!rctx->outbuf.buf) {
> -		ret = ENOMEM;
> +		ret = -ENOMEM;
>   		goto outbuf_err;
>   	}
>   
> @@ -1226,7 +1226,7 @@ static int tegra_gcm_do_one_req(struct crypto_engine *engine, void *areq)
>   	rctx->outbuf.buf = dma_alloc_coherent(ctx->se->dev, SE_AES_BUFLEN,
>   					      &rctx->outbuf.addr, GFP_KERNEL);
>   	if (!rctx->outbuf.buf) {
> -		ret = ENOMEM;
> +		ret = -ENOMEM;
>   		goto outbuf_err;
>   	}
>   

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks for fixing!

Jon

-- 
nvpublic