Received-SPF: pass (google.com: domain of linux-crypto+bounces-3641-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b3d0c784-9a5a-4224-89bf-782b6ffc7331@intel.com>
Date: Thu, 18 Apr 2024 09:36:34 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/1] vfio/qat: Add vfio_pci driver for Intel QAT SR-IOV
 VF device
Content-Language: en-US
To: Xin Zeng <xin.zeng@intel.com>, <herbert@gondor.apana.org.au>,
	<alex.williamson@redhat.com>, <jgg@nvidia.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>
CC: <linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>,
	<qat-linux@intel.com>
References: <20240417143141.1909824-1-xin.zeng@intel.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20240417143141.1909824-1-xin.zeng@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGVZOUYyajhLcjVxdStnSzVLcnh5UTdSblZjemNCR0YycW5wejBBTXNsZmhK?=
 =?utf-8?B?bm1RVnFSSmFjNnYvUzhmalJpTW9Yd1Y1eHVkWFg0QjBJZUFrU0NYUFpGdUNu?=
 =?utf-8?B?cFk0cWRiakg0TVJJV1NBTXo4M1h0WTk3cm9SdUI1NjN3N09oTXR4RitYUkIz?=
 =?utf-8?B?V01RUnRmSFY3dFN1bndNcE9BblJlSFVCMUlid0M2VnpCaysxTFFkTXNzWE4v?=
 =?utf-8?B?Q2pSNmdHa2dwd1FSci9VdzhXMUtBNmFYbm1JUFhZOXpWSnNJV1hlT2JYSExX?=
 =?utf-8?B?K0E5eSs3dGt0Z1FyRVQ3QlRtRjRDdGlKeDIxaVNFcXpmdEJZbDRpMzI5YllB?=
 =?utf-8?B?cllFVS9SekxsbmtvY1dvbWJKS0xESjA4dmhyYkU5cjdQWHd2M3RiclpiSlI1?=
 =?utf-8?B?d1FCZ3FPSmF1bWFkWC9pRVhzU1hhUDBpQjcrL3JvMkx5L0lnbGNXYzlYV3o0?=
 =?utf-8?B?MW1IQmlFOHZUT1c5bjlKRktodER3ZlpVdGo5UUJFTnVOQ0ZpQm9yek5JMnZl?=
 =?utf-8?B?RDhhSkxvbW00US84QUFKSDlRc1BIUWE4elJtUlNNVzNOc1BnYVZWWFFDbVhH?=
 =?utf-8?B?ZHlNNm5yZ2dEZHhDK1QrTTlqY1ZIcGd1akh0c0VpSnFZbDhKTE1RN1ZPY0tu?=
 =?utf-8?B?WjJKQit3THZTV1FYbUprT1poazZTOUUwNU1oREdVc1Q2bnU2cklxeGdBNEIr?=
 =?utf-8?B?ekYzQ2l2QXBCYmpLNUtyZGtEeEdmVTR5OGZYYXNFSnVVWFpxQ2tmZnlUVzVF?=
 =?utf-8?B?VVlDdHZkRDE2bWxRbW5sS3ZYQmtqVXRhSW1iUitrbDlLOXUrZHBEdWhxUkJs?=
 =?utf-8?B?WG5MYzNZNXR0K3JyeUNjUFVma3NRVkY2WDNHaGtZd0l4WDFCa28vNHprWis2?=
 =?utf-8?B?cE55blQ0eGFKdFpSdzY4OElFcmVyZ3MwQ2ZHbHUzL3J1cmFPeDZBZzhlcEcv?=
 =?utf-8?B?MWN2Y3BiUi82UTlZcWtzQTRzU3hNMGp5NjVzMG4zWkVCUGY2TUZ4VGhkY04y?=
 =?utf-8?B?SnoxQXRXeWNlcm9pV0hnbTBFRjJWWEZ0TWhGVGFidzZFTFJiVFZaaWd6aXVV?=
 =?utf-8?B?TFg2WjEvYjlSSHo0SjhUVFkrNERpRkI4QVBsYS8zWXh4b0o1UDZFeUFLQmNp?=
 =?utf-8?B?Y28rdzh5VVQ2ZU9USGFYcGYzQ0JYNHdMWHVJdXhOYW1vL2luNnFFem1zcmFz?=
 =?utf-8?B?enl2d1pXNzlQQkRUdHJSd09aelc0VDFYck5ML05jaDBKWDFQUzlDU1NRK1cv?=
 =?utf-8?B?WnRYNXhNdmdzMzlWVkg1WU4yYVJFNkJuZUQvWmZTcEZ3eE9NU1R0MFJ3Nnpz?=
 =?utf-8?B?WXo1bmwzQ1J3RFhEaE1IR0ZudUZDbzd1WmJJNytvWDE2bVJoWnVUYmhjZUk0?=
 =?utf-8?B?UExhcXZQZktYaEQ2UHFGajV0eVplZ3FBY1BWcDBpVHhNbktVemFZZEp1SDJl?=
 =?utf-8?B?YVNlMDl1QkFyVlJKR3diWlI2Q21WbkdDZFhsTWIySk1SQjJacEkyWjFZMk9q?=
 =?utf-8?B?M3ZMa2tKTGo4ZVg4NG56bmFkK3lDbUQ3QjBBVk4rb1hBNitiQVExMEJqWk5X?=
 =?utf-8?B?UWxVN09lTzFKRFFqYng2MTlhMjVCRXh3Yy9HVFAyanNEVWgxRnFSUlQwbnlP?=
 =?utf-8?B?NzdQNWNpN3JaN1BJKy9xcUFQS0FmRDBNYmNvOU9HQmtXRk9uOUdLd3IyWnpM?=
 =?utf-8?B?aE9oT1hWdGpJeTA2K3Y5V2hYS1BWSVZlcHJzdm5GODZWSUg2NXRzUDE5cFdr?=
 =?utf-8?B?OXpEQ2g0NmFvbklxaFpaTUg2RXhpeFBCUnRNcGlRN256TUNOQ2ozT1pxSWdt?=
 =?utf-8?B?VVFvaXdzM1ZLSFY3QjEwSXREeEF3aUVManZ0cFZTNEt5VE9JUThzTDVkRWcy?=
 =?utf-8?B?M3BlRGwzSHFWM3lrV1l2QnpoM2ovWm9TMFRsZGJRUHE3dU1oWktUZTNieHU1?=
 =?utf-8?B?RndsczFLRHBJcmxCWWtaWTdCTVk1c1czN0J1RWVJMktmdVI0NEw2c1pkZXJY?=
 =?utf-8?B?dmJxSlVhYUlKZldQRmZ5RlBGQ0htbGI1ZDJjVnExc2N4L2t5TFRRd0RTMXI2?=
 =?utf-8?B?R1hKMjhkSzMwQVhldjRWNnJxUmFiejBWNklCTnc1U3JTcFZxVS8vNlNpQ0ht?=
 =?utf-8?Q?hHXBtdY+LPkH+iXxc+t/+jSD9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cdfda35-7539-4f2b-ac6a-08dc5f477c9d
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 01:33:01.9113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G5EAjgrdLheg2b7bxsyqXmTbCwv00g2cQWm3Dt3QC5jR2bHLIynCeOnxY2v/tz9ABrX7njoRiWhD2ZKnePnuLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8683
X-OriginatorOrg: intel.com

Just a nit. :) For a single patch series, no need to have a cover-letter.
You can include the change log after the s-o-b line and prior to the file
list. Like below:

Signed-off-by: Xin Zeng <xin.zeng@intel.com>
---
Change log:
blabla
---
  MAINTAINERS                   |   8 +
  drivers/vfio/pci/Kconfig      |   2 +
  drivers/vfio/pci/Makefile     |   2 +
  drivers/vfio/pci/qat/Kconfig  |  12 +
  drivers/vfio/pci/qat/Makefile |   3 +
  drivers/vfio/pci/qat/main.c   | 679 ++++++++++++++++++++++++++++++++++
  6 files changed, 706 insertions(+)
  create mode 100644 drivers/vfio/pci/qat/Kconfig
  create mode 100644 drivers/vfio/pci/qat/Makefile
  create mode 100644 drivers/vfio/pci/qat/main.c


On 2024/4/17 22:31, Xin Zeng wrote:
> This patch is the last one of set "crypto: qat - enable QAT GEN4 SR-IOV
> VF live migration" [1].
> 
> The first 1~9 patches of this set introduce the helpers in QAT PF driver
> to support the live migration of Intel QAT SR-IOV VF device and have
> been merged into Herbert's tree [2].
> 
> This one adds a vfio pci extension specific for QAT which intercepts the
> vfio device operations for a QAT VF to allow live migration.
> 
> Changes in v6 since v5 [1]:
> - Introduce more QAT device specific information around migration in the
>    commit message and comments in driver (Alex)
> 
> [1]: https://lore.kernel.org/kvm/20240306135855.4123535-1-xin.zeng@intel.com/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=f0bbfc391aa7eaa796f09ee40dd1cd78c6c81960
> 
> Xin Zeng (1):
>    vfio/qat: Add vfio_pci driver for Intel QAT SR-IOV VF devices
> 
>   MAINTAINERS                   |   8 +
>   drivers/vfio/pci/Kconfig      |   2 +
>   drivers/vfio/pci/Makefile     |   2 +
>   drivers/vfio/pci/qat/Kconfig  |  12 +
>   drivers/vfio/pci/qat/Makefile |   3 +
>   drivers/vfio/pci/qat/main.c   | 679 ++++++++++++++++++++++++++++++++++
>   6 files changed, 706 insertions(+)
>   create mode 100644 drivers/vfio/pci/qat/Kconfig
>   create mode 100644 drivers/vfio/pci/qat/Makefile
>   create mode 100644 drivers/vfio/pci/qat/main.c
> 
> 
> base-commit: f0bbfc391aa7eaa796f09ee40dd1cd78c6c81960

-- 
Regards,
Yi Liu