Received-SPF: pass (google.com: domain of linux-crypto+bounces-3644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Akhil R <akhilrajeev@nvidia.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller"
	<davem@davemloft.net>, Thierry Reding <thierry.reding@gmail.com>, Jon Hunter
	<jonathanh@nvidia.com>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 1/2] crypto: tegra - Fix some error codes
Thread-Topic: [PATCH 1/2] crypto: tegra - Fix some error codes
Thread-Index: AQHakPLXFgrOV8qeM0eYRC1RnpmShLFtaBwg
Date: Thu, 18 Apr 2024 04:02:59 +0000
Message-ID:
 <SJ1PR12MB63391314C4D644EBA8A5E77FC00E2@SJ1PR12MB6339.namprd12.prod.outlook.com>
References: <ec425896-49eb-4099-9898-ac9509f6ab8f@moroto.mountain>
In-Reply-To: <ec425896-49eb-4099-9898-ac9509f6ab8f@moroto.mountain>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?JXKgDgnq3sqhT8Fx6Sw0FyUWwDFu/Jrp4i+pe/yqYeig5D++HnFZ42zIDWim?=
 =?us-ascii?Q?K/2T5lXeqP4mPrSA0AA0uIXig++IFyA7BO7azNqHOMUrVYNxb1iRqkS5lzd2?=
 =?us-ascii?Q?rp51Smt5umSCTXZ/8Xe8xNwNDDy5RNVsEym/aENb5FQ/myDHHZtZCjocypaR?=
 =?us-ascii?Q?i070tXtanRPdTUTu1BHXKYrn7TzOo8mPpZQrHjWmLV2PweO6hBU80QK4wbzw?=
 =?us-ascii?Q?6erMGx8iW6KqrnUYgV2V7O8A4LPgx8g/g3EBUPXul6TIKjylsWUIGRzpTYEr?=
 =?us-ascii?Q?L0W67pPLrzR1/58CVY94AKABWkWeK2Z6LxZr9hMs5AxlKUSsa9aQN/G/Lz29?=
 =?us-ascii?Q?fhb2fXTJpDqjv1/VqIz8uRL3s9oecnW5gnd9widlqhZSLPVjT0CMZ9aFa/EW?=
 =?us-ascii?Q?tkMGAxJibgx36H0VGm+i20F98szK1GlutfBaSIxKgcoeEck589W96K5nRsZh?=
 =?us-ascii?Q?r0vkNtv5lAHaWMAkhdoiGCZIAcONg1f/TFr4+3k05w1SeCAwIx/mw0Gk4NnB?=
 =?us-ascii?Q?LURyAGol2J8x9e87L9JRjf3DWZt49ybZszr2SrHlyfSptrE9NU+XORTEXJR9?=
 =?us-ascii?Q?dA7MICO2rD2rAP3lpIQcrnhPbmUPimOS2Aq/lBHQScQesNXCLJ08hNp3wVor?=
 =?us-ascii?Q?s5h7v9Hm70119Xpd+BnFBxYj4DmVzsw1dHz+V+PV/CBx/5LQv/Ccvbv05aji?=
 =?us-ascii?Q?WrreZS79du90II/pfe7h56Tlihmm+duNOtpuqrEYpkGwMjcQ4lchGWXNx40o?=
 =?us-ascii?Q?kzuyyYMkVpCRNeGCyH9i//YXXEaQJnEj4HAWS6eMsH3SzrbKa6SWlgCqKa6K?=
 =?us-ascii?Q?uaoPFHT7orNNeV/rkdc/hKxWGGj/02F88N4KpSTKQQaaBpMsIi7XOm4HI9GO?=
 =?us-ascii?Q?b9fZgaQpjGG+1s5tx0DdnctpKtlHN+9KPICuSD0dBnElZcrcMUChI5az1B2x?=
 =?us-ascii?Q?D+8k2y1ulp4hi7aqCfhleIOReA8Xqg2soZaJADxUGK0ZTzj/qpArTQCLZVur?=
 =?us-ascii?Q?477ulk0h/AFIyCSGLGBl9xttFoOmUmFRKxYyHXYTums7gqJ489HPmP/aM1rF?=
 =?us-ascii?Q?d6YYh/P3gf0Z5dvkzkgXKjJWkO7Mvu1P8vlC8SEDe4Ph4LhXO8ECiYy+cLZ4?=
 =?us-ascii?Q?FxI6O7yovuMTOs9m2ewEMju9XoQgdU6J3hu+jxMMUf7MZcGBWuzeR0XmIeWV?=
 =?us-ascii?Q?aaIXlA364+EyxH5FDJpao/XCJtMiecdgl2gvw+WLP6+QhVi9lST7Iv0hGTFM?=
 =?us-ascii?Q?gP+1J06PojljFe7yU51mUvvVdq3bCgHk0ESIapueK/YVOesjp/oAJPQXsbcv?=
 =?us-ascii?Q?pPQv6rLbwtV2peEqyLSiV+2ukLC8C27shOBmA5OgQ+55exQSSoDEQkt+Dpri?=
 =?us-ascii?Q?CUqurIyD14YJj4FACMZHCv57fRcU3nTRKR0NoTdgB//XS1ryIuPhL5aIYacM?=
 =?us-ascii?Q?idBtiQe1QGCLdoxKCg3tIooQFRjJWf++4iPoWKuOUrhXEhZjJ422BdU/lTbu?=
 =?us-ascii?Q?vTLTG+zqG9ZNsTmYP3QUzuJEBhkKy7yIQs+k/JYnP6cQsDOacjWrEXe/fbjy?=
 =?us-ascii?Q?deoFyjY/C4bnwuSu84koz4aXOmjtmMBH3vIneG2b?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0b71a11-301d-4100-99c9-08dc5f5c6fc9
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 04:02:59.6862
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aXaEQJ2az1DBNJ/5OTeJunNf8xBfemozOdM/go1JY+g1IXLWHsH1Pj3ipRphLEz6JJdpLsEY6iXxwnGWu8dScw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6613

> Return negative -ENOMEM, instead of positive ENOMEM.
>=20
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/crypto/tegra/tegra-se-aes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/t=
egra-se-
> aes.c
> index adc6cdab389e..ae7a0f8435fc 100644
> --- a/drivers/crypto/tegra/tegra-se-aes.c
> +++ b/drivers/crypto/tegra/tegra-se-aes.c
> @@ -1156,7 +1156,7 @@ static int tegra_ccm_do_one_req(struct crypto_engin=
e
> *engine, void *areq)
>         rctx->outbuf.buf =3D dma_alloc_coherent(ctx->se->dev, SE_AES_BUFL=
EN,
>                                               &rctx->outbuf.addr, GFP_KER=
NEL);
>         if (!rctx->outbuf.buf) {
> -               ret =3D ENOMEM;
> +               ret =3D -ENOMEM;
>                 goto outbuf_err;
>         }
>=20
> @@ -1226,7 +1226,7 @@ static int tegra_gcm_do_one_req(struct crypto_engin=
e
> *engine, void *areq)
>         rctx->outbuf.buf =3D dma_alloc_coherent(ctx->se->dev, SE_AES_BUFL=
EN,
>                                               &rctx->outbuf.addr, GFP_KER=
NEL);
>         if (!rctx->outbuf.buf) {
> -               ret =3D ENOMEM;
> +               ret =3D -ENOMEM;
>                 goto outbuf_err;
>         }
>=20
Thanks for the fix.

Acked-by: Akhil R <akhilrajeev@nvidia.com>