Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp583239lqt; Fri, 19 Apr 2024 05:01:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZmzGUECzXfZaAAEKM28317qo1phw3RQgIrcnhbk0Payjlt2H+yO+YobI11nr69rs/s8zd0oFpOsyKWF44oFXfBLG0Y6D9eZ+QgvgmwQ== X-Google-Smtp-Source: AGHT+IHz4tsCoA6o5yHB20m4R4sx8WOZTar3OneZcyaoTN3wrtWp2WPWXZGUdPMZqcWfLXwZAS0p X-Received: by 2002:aca:2406:0:b0:3c7:4608:efb8 with SMTP id n6-20020aca2406000000b003c74608efb8mr1803470oic.20.1713528110908; Fri, 19 Apr 2024 05:01:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713528110; cv=pass; d=google.com; s=arc-20160816; b=PZ3mpkyZPATdJCZSit2fUDkmJpuOZZawEGFSj9DQwHcGTa5EGiDTG4HTOEk2YEGoje tBsndq3UfwOoNB7xYQKj1bfyRYD5mLHGE5OcIeP6Qr6ZxdqpeaRtLG7d0Kgx2QfHTEOw malNf3GylfnNAtsaWsVsoN8Gfo2qpdsu2z9EVMQW7W9zqLotl+hRo5hvF6cjYMEO18AJ e28fKPT2EbAzSBT77AKsGyS0ca8JpRIg9WICTUkGpz5/OWbMcqCybhDZTJR4uL8QBMbi rV59cb/47ddGfsoq9F3TiiniaRG6GhDKzbGL/fMFoG57Unh6J4Cll1FiCSC0vLwVx5p8 cB5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; fh=SibclJ/CRdrb3/fZZOsegPqfMtJOd7KnpAeSIYGmBik=; b=GJWvWQacDlhJb3KqDT36seL0pCQUyXoNjofXykKLO6WoSsRmnLjdDfcD1NPB2Y+r4K s/W7v3cxO6X5gD9/h8cV2VnTU9a2EMikDRbxGVIg54garDCbU339Qx7AtCHhe23VOTQA YlhxtG7NH5+ioxKZgmBnle/4vReZqEPkqtOikF/+pKKPQEHYhcFVda2XG6xvLvNxy+d5 At8rGP0wHHlppGXZCjldtjgtiESRKFbeld1LBXd93WVgzgmsk1mSRBfSzsb1Ue2XMvkC akDzYA9QDvolKbR9tejXlkOBg84fOprrIhnI+HHiLLYR5FZ1ZqipggUMQjlxqnyoNRiJ W/3Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Akw+r+IT; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-crypto+bounces-3710-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3710-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id hf25-20020a05622a609900b004366340b380si3743048qtb.270.2024.04.19.05.01.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 05:01:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3710-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Akw+r+IT; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-crypto+bounces-3710-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3710-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9D5CB1C20C3E for ; Fri, 19 Apr 2024 12:01:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6995F83CB0; Fri, 19 Apr 2024 12:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Akw+r+IT" X-Original-To: linux-crypto@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F05B77EF0A for ; Fri, 19 Apr 2024 12:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528106; cv=none; b=SDPa9SRhJ1rfGyCtCHJYUuGNACENocetXshh+vmcc34MU/3JDGM4T3h/IhZabXSdwdnsuNbQ2LUp8PAh9Uo9NaNNOmlv1LvrnkN051xyWV9dTaiugLRxBnI29YFVDPX0PkyIZ6jvuwXTDeXEta4l1XQ7SwRK9qOCKICvFkEDuAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528106; c=relaxed/simple; bh=acN4eXWZt8iLvqysCB2S2Dc6auK2r1UT70yxAxadgbw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hBiVTUVek1ugXqfCM9i71Fy6SrDzsYsYuFAkD5FnK7kHW2HtWPzNu/4xUNCvs1/rJTnGj603AorftnDuF2ibJvNOXM5rbpm2zyw6TXZ1miAsOjVNAz88NwvDCcsp1Cbtjq2T8D7ywA4j/oPqVCNTb56W136SG1F8ckQYEgLko9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Akw+r+IT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713528104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; b=Akw+r+ITtB6jgATaNf+mskwcKMUt3m4QXf/7JL+1hd09iQ5PHq5rQXrX7dnOXhSuRl3mFj /aIHEa/JxbuZfgCKM4urVzCW5K1QcHziyzYv1fpSx/jxey70qhHOQj8AlWanPXL3sgf7M1 VNlofBOtP56Y9kWFuTP0tWPDr72JY70= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-R3QzBV_sNPOe4dUEeSyjMA-1; Fri, 19 Apr 2024 08:01:42 -0400 X-MC-Unique: R3QzBV_sNPOe4dUEeSyjMA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-418f6585034so6524105e9.2 for ; Fri, 19 Apr 2024 05:01:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713528101; x=1714132901; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; b=weYETloNJxQh6xnZvDZpJnDG6xEGUVEE5Enfq10KLUrO7YHWxpbwIAyHoTv1EOAWsC c700Q8ib2m99yBO99ZB++/PiklB2S0/uz4Vc22LQYbZwbk0OAKZWKSZPPl+Os7DXmsTM tbbr/H/Qo1i956jOyoq7+xHOjao6HG2gYUOfCNMfUIyk1bb6wlf42Ha7OTaOvA2+TCvo BO1+C7tNpGcQwBtr9SJ/C/iQj15oZCIIBMVGl+b12YpqrRKAp85cveo+rcmpFuqyVe4v cXKo/S1iiVwTrH2t3deXCaU/bgYTQI7rROXIYYSBRnlwv/gewfE/ALBzKTYlN659271c 4MAA== X-Forwarded-Encrypted: i=1; AJvYcCUZntikwGJQMWZxVXDQcJob8GPp/AvYHc7FHK4nstvrrY5rO2JlqHseyVnPR5wCbtqSOsjr/gyZuJzWl4x5DoxbJgavUxaWhXb+aeTe X-Gm-Message-State: AOJu0YzKY/T4Hv3fsi7u/1W7QPoC9L/EV4HUxWcZFW6HGcBHGdT1tGc/ VXHgawlMDLLbAih8ca3Df/67YCkBnl2mURHI6jrezbO6UsD2KBw4E4miGAeCnvG9BPv2zUuhtkI S8XBYa9xfNDgW0fPBns1POxHAyUqfOHEIU/rrjC5Osev/sa0UmnBf01XqS3ZZua91LQP5IAqNU8 +JR/poycHV/mN206H4M3bfARzFYtFceM7F/7Lw X-Received: by 2002:a05:600c:45cd:b0:418:9ba3:ee76 with SMTP id s13-20020a05600c45cd00b004189ba3ee76mr1378070wmo.4.1713528101569; Fri, 19 Apr 2024 05:01:41 -0700 (PDT) X-Received: by 2002:a05:600c:45cd:b0:418:9ba3:ee76 with SMTP id s13-20020a05600c45cd00b004189ba3ee76mr1378024wmo.4.1713528101121; Fri, 19 Apr 2024 05:01:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-17-michael.roth@amd.com> In-Reply-To: <20240418194133.1452059-17-michael.roth@amd.com> From: Paolo Bonzini Date: Fri, 19 Apr 2024 14:01:29 +0200 Message-ID: Subject: Re: [PATCH v13 16/26] KVM: SEV: Support SEV-SNP AP Creation NAE event To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 9:45=E2=80=AFPM Michael Roth = wrote: > * the VMSA will be NULL if this vCPU is the destination for intr= ahost > * migration, and will be copied later. > */ > - if (svm->sev_es.vmsa) > + if (!svm->sev_es.snp_has_guest_vmsa) > svm->vmcb->control.vmsa_pa =3D __pa(svm->sev_es.vmsa); > > /* Can't intercept CR register access, HV can't modify CR registe= rs */ This needs to be svm->sev_es.vmsa && ... (see existing comment above the "i= f"). Paolo