Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp748465lqt; Fri, 19 Apr 2024 09:13:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgJm4sJ/fz3ChY6pjBQWiqflvy0Y/XhUV+WBa+K/0uO2gAlsMrD1RtCiEmO7JIcHGZl/K/at9e6PfqtpQ3R5DyC7qAjgkcCSQdvjcQyw== X-Google-Smtp-Source: AGHT+IGnBFIkDca0oeYkeWSAN3Tu5jcdGU3dToxlWERkXcvBs4AG4P5ZCXZBFQv8PuU07P6yR3xk X-Received: by 2002:a05:6a20:978b:b0:1a9:9cbc:4daf with SMTP id hx11-20020a056a20978b00b001a99cbc4dafmr2654657pzc.27.1713543239518; Fri, 19 Apr 2024 09:13:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713543239; cv=pass; d=google.com; s=arc-20160816; b=HDOkYLGaOfgKubfC8QPmEn7s5rrHfuIYWCgXN5f+Fyazk50xdKS7ntsh9mgTH+gG7N vOTG3NdoivuXZT/KozDqStFbhTG9GtuLLxSQMruP9Ka/Ls+2U0hs9VrfpQED+gKu7W3l 07wudcKVSlflUi+E9LIU6GMsgGlW7nB2qeawbiAwPvep2Jus47xZZVIukwo8WV9S24z3 20bjadb7P4uoZXC4I6JsOJymFZYOb4LKO4Rh3CccR2nv8xhHPO+WIN3FXs49AaVqTCBb LU2GgBcDZjwFyxzDMdOwSoP0X9LPFoGJzC8bojw0OFUndVzOlXucYsuCtyzEx0S5e1jC 2g0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; fh=clr3SN+BUcp5KSssMGlny+KFQ9io6hZ0YSLcSWMBsBA=; b=u/FQf/BZQLtPdWdjM+q5lezopfYAiJragnYGqQi6BD50xYtRTo0ZW2wbJAbdsHGU8I RIjP0amuhkl8Q7RaQy4Yg2FuCJ0vyEtFd0mFop/kz1hUo+dnPtc5e78z+T+cVTNC/LWJ zoWW57ZsoDQV6fUVB+gwNsnu6IQsoFtxvGujp3XF79pTGuz0PpFaZeA7fAiYLlS4akJo xxWvDpl+/MUpfgx+1L5blAoBYd1FMq27NKMMFm+ptkcyBimMc2GHqqqC7MykPfCcroft +nFnuTExVDIEd2LiH43cRja/ciPYK3UYb4gq/O5F4voyVDIjMGdb/VC5neMyXEWFdfQD /8vA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIZVcVIu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-crypto+bounces-3717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i185-20020a6387c2000000b005f7fc08160csi1669952pge.438.2024.04.19.09.13.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 09:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIZVcVIu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-crypto+bounces-3717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 95520281C55 for ; Fri, 19 Apr 2024 16:13:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C222F130A72; Fri, 19 Apr 2024 16:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIZVcVIu" X-Original-To: linux-crypto@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A70477F13 for ; Fri, 19 Apr 2024 16:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713543226; cv=none; b=bZav1OORGKzj7XNEqvB137JzClinpui++Ebu5eC+2ZsELUeGmjgySvEdmrc8jt4Y2HTjIBXWJhtZ4eceQawbw/2KeoHI/mEvPPoT7CVxItoR002zwQhDNB1bADSBE6rDWy1RH5OUflpJDOzBeoE/kc6CGPD54Q7FboPKbOI0NHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713543226; c=relaxed/simple; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EYFzRtdjPF5qSCUvkoLPDDe7Es3jtuF7XhNuQK/0oi1M2pz7pahpLTTCFdg4tYKCfJ+jRvJmknOKGRqG7fHvGYLoYX2M6VUOs2BXRAQufcaW0tb1SYxETHBDt3t9grP+nlg9ZlknZPR0VlQNIZSxJQbn1BEo7al69cT/U1IrffI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HIZVcVIu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713543224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=HIZVcVIu5JU7nFfDo41kCjTnm+RMgxeVliRcaRd/FHxUsqySdBFjsazv93AKd2dyKUQzCF Arbfbhudwhq6HnC0OoX0Y9vT3x2OlDjW/dbJYJRPAp93LRxgfDj6DtACBbmZK6yPzzJTrt k03tIz8HxfSLX6T3jnboMr9pXrM7uwc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-H7_h92qUOSKXZ9uNw6biHA-1; Fri, 19 Apr 2024 12:13:42 -0400 X-MC-Unique: H7_h92qUOSKXZ9uNw6biHA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-346772358easo1358423f8f.3 for ; Fri, 19 Apr 2024 09:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713543221; x=1714148021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=JcUc3PylGXJrJcWC62FHf4df1MHM/mExrqXjbtCc6UTL8YRdVovrCeBk8YTC25RZ18 bWKpNysQ+5/zsW3x8/iBlMXhccQ20LKRILCUkD19iiSGgTC+mx2wht+DQNyfNW1xXe0l uqFTedT6PoCilQo4d/0hSIEkmGa1VazGMMo7Y1IUkwKyWjUKSlXbTVxcmgtQT5V+1bK6 YU9biDS7BFGYA6CuC5UZEjtQHHZFk7/4SS1UxDXZ7rbhhZRD4nBMgphgEL8L2n1MB2ns MG7c1PKdc1M19EYCbrqo3I5m95FkKWk8jDuX9BhtVDxsVy1S47kqCXlf4ktrtqcLd6D/ TYIg== X-Forwarded-Encrypted: i=1; AJvYcCUmbfHi4PyfpPW17pv3WzCI2dAvKUO18vAIBTKbebnM+tr1fQrU6kq9cVpM8nt4/wUYh5QHG3OF1EIEvNnhswFg0dnOYy9JJUbpXry/ X-Gm-Message-State: AOJu0YzDG4JcP0gencFKzX/sp/32mo74I8JY4UHPZs0PbQv7dmmV+jyc xDDSf60fRouPpCqbPQT7OywHHYgjUfgb6jS8169dOUczkPzcjLacKlCdlwSUsreOYz9kAiWrbB7 GxxaPanLgwZpMdU1CDl2bbSLD/3uZxF79tyRrT6IQB4DNbTBcV7aa1TtcgGZ7QtRc3cXaMxmMrz 2sVKIhCkKVWI120iUlxyp/BS6jCYts9T3VKXav X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596267wrc.0.1713543221701; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596246wrc.0.1713543221365; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-10-michael.roth@amd.com> <20240419141920.2djcy6ag3peiiufn@amd.com> In-Reply-To: <20240419141920.2djcy6ag3peiiufn@amd.com> From: Paolo Bonzini Date: Fri, 19 Apr 2024 18:13:30 +0200 Message-ID: Subject: Re: [PATCH v13 09/26] KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 4:19=E2=80=AFPM Michael Roth = wrote: > So my current leaning is to send a v14 that backs out the major/minor > policy enforcement and let firmware handle that aspect. (and also > address your other comments). Sounds good to me! In the meanwhile I guess you can also update to have PFERR_PRIVATE_ACCESS. Paolo