Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1359651lqt; Sat, 20 Apr 2024 11:19:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHeovOAoAn8r+KSskUBMAnjLx0EYmSMtBmwdZNCpPxN6jD6QziEoLik+2Xdp3h0rvc+sZ4bqp8YPOHUSwGHbF9YpLmAZ1EY3Zj2aJ4FQ== X-Google-Smtp-Source: AGHT+IFN4MIehhzka9GfGRZJnO4OdLJSYidyuRF3ujnecs7jF/1Mjh3EaNo/cGz+g6osnew49kBG X-Received: by 2002:a17:906:35c9:b0:a52:2b39:879b with SMTP id p9-20020a17090635c900b00a522b39879bmr3131818ejb.46.1713637189208; Sat, 20 Apr 2024 11:19:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713637189; cv=pass; d=google.com; s=arc-20160816; b=mUpY7e/DEU4EcRGPktpmUOSi4nXmSbId9VAB7a3hOXnSF58YPRuHrQLHEql89Txf8i LGofrUmxg7euwvWIEdk9fMNC5pAmRdBsIaXYGGU6UyZ/rftYP0cFhvkl6dkt4UF3EgyL MHgvAuEe1qbRv3aiutgWQcByamS1ZLRCa9gP3nWiCkB1M3v3gCVFktbzDdbBrJhMaiWF Z82rGS1XfJt6QOm7iCiwVNIJre7tctUcqQCKMC2YxEvq9lkhDMgJwO3EWd0KgNLADK93 kZL1oh/VigJvRY4umR+z9ziW+LIwfy0F1gmQKqC4hxtiDWXi/jbp0/cwLWhjpyuT5EWL bKDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xSib9DbWfg27BbIkq+VJOkMZqxdPJFrj4YhYx3wEx50=; fh=Lug2gC1H4H+8fcBw+nZBVEmAqkXnHiXUuu9mnC9ge+k=; b=z5EDf7rE5HcQWRqqi6CVBA4nsHbSttqOeNxx/btB0I0iJ0n8ruRB/05Jnpa5PuaxPw SNZMLLOTmudORDUod0EfQtvP6ijCSJ/igGwgtLTvE/fAqU+gTRulPFx1YTeRax2Rzwtp DkUI9tMpw569lJzQNmB4mBbTD42x3ZG9e9g7rvL09VQ7VPjTWjFLWokcXXdEOyL8WRok 2if6Vk4h60v+rPZ4adW2ipflOlvgpwfMLw1TN+0jLAldMPeLF+PseHyl61zxADDaPig8 /Wy3obQnSSTqxCcfJRUm3rls79eA5nq3beeyLuF6KhWCGWTzqVEart4DQDCyMFyDyBOi 0qwA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CZEiAfcU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3731-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3731-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i26-20020a170906251a00b00a46e9f5a524si1419411ejb.957.2024.04.20.11.19.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 11:19:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3731-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CZEiAfcU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3731-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3731-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ABC101F213CD for ; Sat, 20 Apr 2024 18:19:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6B083B185; Sat, 20 Apr 2024 18:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CZEiAfcU" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6528A1DFDE for ; Sat, 20 Apr 2024 18:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713637184; cv=none; b=ht8K4lPfueUizjixiRrnX3qIjh4Ac1L8q2N+1grabXaBVvhACAjECgoFmxyiM4VnsrYi8LmqBJMD1sdQxPZBaiWtg9xaCdRJIcynZk9fa3hyjXUZMTszYuOcmWT1ZjkqJf0hc3or7VNg7Y/IjYaKmjZH7I6MehN1i4TnuxSPQdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713637184; c=relaxed/simple; bh=BMdXnEOYanaJkv2dxl2IwISChgysH2clKbvNEy1v2qg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=meDxxxf+1uoYmum8DV64MQcgjbZGuplrksQg00FaZbIfAWPDO9bp0S3bivmqW2ftExFoXCLze1wR6W/rshz+1J+4a9Dhz6bwP2VF4t7ZKFHYa+9mTJq1uYpdOUahdhPn1CbXoE2QKsz5GqvXIKuYHSwTjJ0H5Fqy7Q8PX+TVTk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CZEiAfcU; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B320EC072AA; Sat, 20 Apr 2024 18:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713637183; bh=BMdXnEOYanaJkv2dxl2IwISChgysH2clKbvNEy1v2qg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CZEiAfcUC/Qss7ofvzfw/TDwHHGSUGkwTkxQdsflFyD0a3/E2hxsNHQs56XKZduyH j+LispvCW+0+/6ZNqXSQaED4is/QWjUyn95GtGiiNum4dkqSrAwg8vHH+RI/40Uj97 Qk39OsvTbIIgLOFqOH1JZumJH/vYcCI0YUfsleUyWxIZhnOCZ0TIHS0NY4l92iDu/w 74nFZZUCxpVu0qNzLI1qOs3wsSsOUc+slB52dY5XaGKJTb4QqnkD1yUsjuXQ6lkK/h 9BXuRm9Db1BTdMY3bdtBqEy6OBgRYw5vRJiqIWe1M/yxIK+ZrNEXhhsIgJtXeTnRTw aeMz+0ays89ng== Date: Sat, 20 Apr 2024 11:19:42 -0700 From: Eric Biggers To: linux-crypto@vger.kernel.org Cc: x86@kernel.org Subject: Re: [PATCH] crypto: x86/aes-gcm - simplify GCM hash subkey derivation Message-ID: <20240420181942.GA786@quark.localdomain> References: <20240420060037.26014-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240420060037.26014-1-ebiggers@kernel.org> On Fri, Apr 19, 2024 at 11:00:37PM -0700, Eric Biggers wrote: > + aes_encrypt(aes_key, hash_subkey, page_address(ZERO_PAGE(0))); Actually, page_address(ZERO_PAGE(0)) expands into a surprisingly large number of instructions. Using empty_zero_page directly would avoid this, but there's little precedent for doing that. For now, I think just using something like 'static const u8 zeroes[16]' is the way to go for small buffers like this. - Eric