Received-SPF: pass (google.com: domain of linux-crypto+bounces-3759-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <05ce2bb1-46c2-48af-83c3-911f00f290d9@intel.com>
Date: Mon, 22 Apr 2024 00:49:33 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9a 10/14] x86/cpu/keylocker: Check Gather Data Sampling
 mitigation
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
CC: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
	<ebiggers@kernel.org>, <luto@kernel.org>, <dave.hansen@linux.intel.com>,
	<tglx@linutronix.de>, <bp@alien8.de>, <mingo@kernel.org>, <x86@kernel.org>,
	<herbert@gondor.apana.org.au>, <ardb@kernel.org>, <elliott@hpe.com>,
	<dan.j.williams@intel.com>, <bernie.keany@intel.com>,
	<charishma1.gairuboyina@intel.com>, Dave Hansen <dave.hansen@intel.com>
References: <20240329065742.fc5of75e776y2g4b@desk>
 <20240407230432.912290-1-chang.seok.bae@intel.com>
 <20240419000113.2tjvyigx7nlyymrw@desk>
Content-Language: en-US
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240419000113.2tjvyigx7nlyymrw@desk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uzg0dVFxdnh3S3pxc1RYWUVHVVd3SlFlNmtROFBlYW5MRTlhTElGU3k2N3Rj?=
 =?utf-8?B?MVd0SWJ2UDlJQkFYNUl1dnpQOFFROWNxNFF2aVlxb3VKR3ZyNnhhVTlUVVY0?=
 =?utf-8?B?N1BIRTdIUlpGWDliYmZ1bis3Ny8zaTFMNlhKTTdOQTByekVhK21rdHZGanUv?=
 =?utf-8?B?RHlJczYxUS9vOTQzVFZZSE0yN2xMeU1MUkVWdm43TXh1VlcrTXR2L2Z1YW1h?=
 =?utf-8?B?dkNTTTdnQ3Vka1dobU1ZblpKcWRhMndaZ3o5TEhpTFJhOHhQVEltckJkWGZv?=
 =?utf-8?B?UkxQNlpWUmZYNmRVQ1c5WEFmOTJwTFJ3cjR0WTV1TVgvb2ZDelJKaWlvdHdT?=
 =?utf-8?B?ay9USnliTENVTjRxM2ZBRWRQUE1KeWR5UW5TcUlRTkpSUnZaK0J1U01ZejNV?=
 =?utf-8?B?dzBWcGRTNlhibHhrVytVZUo2WlMxN011c3NBRzQyN2N2VDg1eTlRQnBhNHNr?=
 =?utf-8?B?MDRHMHBNUkxnSWZyVkFSNnRHUXFDVzhGa2ZNS1k2YlBIcGVFUmdQN0FGbHVZ?=
 =?utf-8?B?M2xzRUxtWnY2VlZLTjg2TlVsVWdMVmtBZnNzc1IxZzdXQ1VCWUNyR1p6aEY2?=
 =?utf-8?B?SENuRm5kRXAzUGxFckEraS8xTy9BRE1tNUE1Qm9qMWxJUzNoU09ZM04yMGoz?=
 =?utf-8?B?K0hqeU5qUFdJQjlJRkU3N2JNa2ZKNkU3eXlnTGFtVlFVRUhWTWdoOEJCcVZv?=
 =?utf-8?B?YWRSS0FFSjRTL20zVXdTYlY0NVJyYkowU3czVEVEZjRGa090VFB6aFBBOXJm?=
 =?utf-8?B?NDE5dkkrMUROZWRNdlBzcFh2cllKNEp5anFHRERwTkdjRnM3QXpJZHM3YXlp?=
 =?utf-8?B?RkxiVzEwMTBMbzRXQzhIZVlJd3FCUG5CUDBVbDJQMXMzak9ZQmVOK3pCZk5F?=
 =?utf-8?B?a29odHE1MytJRXAxSVBCVTZLNmxxc1Z2YUZmZnY1aU5XQUV3em5wRmJ5SEY2?=
 =?utf-8?B?S1RncUhBMEJ0SUoybWw5eXplRXUxbGJBUUw4bXRuZ3ZYSzcwNnFBTDJ4OHJV?=
 =?utf-8?B?RzlIeVo3cE9PaHVUeFcwcnJaRmUzaytRMzE0Nm1BeWFacUdwZTV1YVN1UExN?=
 =?utf-8?B?QU5FRVkrZG1ZUElDVU5sc0VjM0xoQlpieVNCc2FETUhGL1c4VmR1VTBMK1VM?=
 =?utf-8?B?VStJbGE1ZXJHVE9jUFd2Y1JnWDc4Skt2SHlWZDVzSldUTC85bkhZUUFtd3FG?=
 =?utf-8?B?eE5HNkxCNkIzcVd0ZE5Ha24xQnRQc1Zlcmpyd29YMVVWWnB2WFFjNkVaRXVu?=
 =?utf-8?B?Qk9wclB0Zi9RbExCMDZzZzZwa2E0TVNQVm41eXAwdmFFZmpOV1dSY1ljNDBm?=
 =?utf-8?B?ajhaUEt4YWxLNGsvR0xUOUpQa3JLa2F2d1FaVWVWWm5JTTRQM0dQKzgwamV0?=
 =?utf-8?B?Ujh4MmRvLzNBcE96ZURQZEhJenRENjhMMGlSd1EzUllNYjl0czllUmhpSWMz?=
 =?utf-8?B?dDV3TWp2NGlMcUVkdk5wb3BtOFV3QUNlaU9lQWMzWm9TSjFSS05ldmljMmgr?=
 =?utf-8?B?TDJ4cEFXVXFZN2NJalJXeEFoOVFreXFtd1FCakZEV3plN2g2R0ErN0xWUDZZ?=
 =?utf-8?B?UG1BdUNaV2pCVEdsQ203ZlhhMkhBbStiTTAyV3hXdHlyZGhSOTQ3ZFBhM1NX?=
 =?utf-8?B?bzZKUDA5cHNjSk8zMXNPMTNqd1VsSU5VRGM1dTNNZVhKb2x6dW9oRENRaEZ2?=
 =?utf-8?B?akVGMllOZzg3N3ZiaWxmRFpCMGJkSmVZV2wrNXpDSWhOYlFibEcvQ2E5cFpv?=
 =?utf-8?B?UTRZVU1IeEsyQnR4c0FFS2QvTkowdnJJVmh5dTcrK080V3M3aEZNTndCclJ0?=
 =?utf-8?B?Z0duVzJibUlLU2pNbjBueWxyWGpEQUY1Vi82eHJZNFJTeDB1ekNMT2lSV0Zp?=
 =?utf-8?B?S3JTOEIwaDI3RGNadFRDdUgwSklqbG5VbnRDdUg0MVFDdnFoYTQxb3h1dlcr?=
 =?utf-8?B?Qzh4ZlZMbGxHaWFDQm1HY0kwVk1XUkhLUDEyLzdDU0t1QkFzVklIb0JENytv?=
 =?utf-8?B?ZVgwM0JaYlVhanNRRExjVjByS2VXdGk1U3p3d2lYYTJFcENkbGd2QVBDbXlC?=
 =?utf-8?B?RUFGc1dKZHRvZ0R5OWwxSVMrd0tXc2lhZXU5aStTdGJTeENuOWRweHVpMkRH?=
 =?utf-8?B?d2lneU02YXVwMXc4eFB6OUFWaStXYlMyKzlVUjFvcDFBUnp3Z1d6TVg2aEtV?=
 =?utf-8?B?dFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a032c475-ea4e-46f5-51ff-08dc62a0c11e
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 07:49:35.5748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ukSxAxHMSXtZE03M3okyP4KORiMxfECjNElvwsLfJhI4n5DmhnUWdAf6loUUwrZYlg3IoolVIXXDw/uZIfH8d3Xb/5h3TliGep9aSC9CjdU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5135
X-OriginatorOrg: intel.com

On 4/18/2024 5:01 PM, Pawan Gupta wrote:
> 
> Repurposing gds_ucode_mitigated() to check for the locked state is
> adding a bit of a churn. We can introduce gds_mitigation_locked()
> instead.

I thought this option but I was less convinced about adding a new 
function for every new but slightly different check.

Thanks,
Chang