Received-SPF: pass (google.com: domain of linux-crypto+bounces-3811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 24 Apr 2024 00:49:42 +0300
Message-Id: <D0RU10Q41UA3.XC5J8UBJUEM4@kernel.org>
Cc: <stable@vger.kernel.org>
Subject: Re: [PATCH] KEYS: asymmetric: Add missing dependency on CRYPTO_SIG
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>, <keyrings@vger.kernel.org>,
 <linux-crypto@vger.kernel.org>
References: <20240422210845.319819-1-ebiggers@kernel.org>
In-Reply-To: <20240422210845.319819-1-ebiggers@kernel.org>

On Tue Apr 23, 2024 at 12:08 AM EEST, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Make ASYMMETRIC_PUBLIC_KEY_SUBTYPE select CRYPTO_SIG to avoid build
> errors like the following, which were possible with
> CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=3Dy && CONFIG_CRYPTO_SIG=3Dn:
>
>     ld: vmlinux.o: in function `public_key_verify_signature':
>     (.text+0x306280): undefined reference to `crypto_alloc_sig'
>     ld: (.text+0x306300): undefined reference to `crypto_sig_set_pubkey'
>     ld: (.text+0x306324): undefined reference to `crypto_sig_verify'
>     ld: (.text+0x30636c): undefined reference to `crypto_sig_set_privkey'
>
> Fixes: 63ba4d67594a ("KEYS: asymmetric: Use new crypto interface without =
scatterlists")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  crypto/asymmetric_keys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kcon=
fig
> index 59ec726b7c77..3f089abd6fc9 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -13,10 +13,11 @@ if ASYMMETRIC_KEY_TYPE
>  config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
>  	tristate "Asymmetric public-key crypto algorithm subtype"
>  	select MPILIB
>  	select CRYPTO_HASH_INFO
>  	select CRYPTO_AKCIPHER
> +	select CRYPTO_SIG
>  	select CRYPTO_HASH
>  	help
>  	  This option provides support for asymmetric public key type handling.
>  	  If signature generation and/or verification are to be used,
>  	  appropriate hash algorithms (such as SHA-1) must be available.
>
> base-commit: ed30a4a51bb196781c8058073ea720133a65596f

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

BR, Jarkko