Received-SPF: pass (google.com: domain of linux-crypto+bounces-3814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 24 Apr 2024 00:56:21 +0300
Message-Id: <D0RU64GRK26M.3TH8TUG9PCKPT@kernel.org>
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Joachim Vandersmissen" <git@jvdsn.com>, "Eric Biggers"
 <ebiggers@kernel.org>
Cc: <linux-crypto@vger.kernel.org>, <keyrings@vger.kernel.org>,
 <stable@vger.kernel.org>, "Simo Sorce" <simo@redhat.com>, "David Howells"
 <dhowells@redhat.com>, "kernel test robot" <oliver.sang@intel.com>
Subject: Re: [PATCH] KEYS: asymmetric: Add missing dependencies of
 FIPS_SIGNATURE_SELFTEST
References: <20240422211041.322370-1-ebiggers@kernel.org>
 <908bc808-f8bd-4cc2-8644-c6c84e8cd4ea@jvdsn.com>
In-Reply-To: <908bc808-f8bd-4cc2-8644-c6c84e8cd4ea@jvdsn.com>

On Tue Apr 23, 2024 at 7:02 AM EEST, Joachim Vandersmissen wrote:
> Hi Eric,
>
> On 4/22/24 4:10 PM, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Since the signature self-test uses RSA and SHA-256, it must only be
> > enabled when those algorithms are enabled.  Otherwise it fails and
> > panics the kernel on boot-up.
>
> I actually submitted two related patch recently which change the=20
> structure of the PKCS#7 self-tests and add an ECDSA self-test. See=20
> "[PATCH v2 1/2] certs: Move RSA self-test data to separate file" and=20
> "[PATCH v2 2/2] certs: Add ECDSA signature verification self-test" on=20
> 2024-04-20. The explicit dependency on CRYPTO_RSA shouldn't be necessary=
=20
> with those patches (I think).
>
> However, I didn't consider CRYPTO_SHA256 there. I think it can remain=20
> since both the RSA and proposed ECDSA self-tests use SHA-256.

Their how in my master branch, I'll mirror them to linux-next in day
or two.

BR, Jarkko