Received-SPF: pass (google.com: domain of linux-crypto+bounces-3820-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 24 Apr 2024 18:55:47 +0200
From: Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>, Arnd Bergmann
 <arnd@arndb.de>, soc@kernel.org, Olivia Mackall <olivia@selenic.com>,
 Herbert Xu <herbert@gondor.apana.org.au>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, arm@kernel.org
Subject: Re: [PATCH v6 07/11] platform: cznic: turris-omnia-mcu: Add support
 for MCU provided TRNG
Message-ID: <20240424185547.4cf20408@dellmb>
In-Reply-To: <Zifu-l2o9ADkhMlW@smile.fi.intel.com>
References: <20240418121116.22184-1-kabel@kernel.org>
	<20240418121116.22184-8-kabel@kernel.org>
	<Zifamxfa18yjD_VS@smile.fi.intel.com>
	<20240423183225.6e4f90a7@thinkpad>
	<CAHp75VcfmTeG+G1DkteR6GN96y3+h_Mz1YQ8U5asHJ7oTq+KbQ@mail.gmail.com>
	<20240423185704.2237bc65@thinkpad>
	<Zifu-l2o9ADkhMlW@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 23 Apr 2024 20:25:14 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Tue, Apr 23, 2024 at 06:57:04PM +0200, Marek Beh=C3=BAn wrote:
> > On Tue, 23 Apr 2024 19:43:41 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote: =20
> > > On Tue, Apr 23, 2024 at 7:32=E2=80=AFPM Marek Beh=C3=BAn <kabel@kerne=
l.org> wrote: =20
> > > > On Tue, 23 Apr 2024 18:58:19 +0300
> > > > Andy Shevchenko <andy@kernel.org> wrote:   =20
> > > > > On Thu, Apr 18, 2024 at 02:11:12PM +0200, Marek Beh=C3=BAn wrote:=
   =20
>=20
> ...
>=20
> > > > > > +   irq_idx =3D omnia_int_to_gpio_idx[__bf_shf(INT_TRNG)];
> > > > > > +   irq =3D devm_irq_create_mapping(dev, mcu->gc.irq.domain, ir=
q_idx);
> > > > > > +   if (irq < 0)
> > > > > > +           return dev_err_probe(dev, irq, "Cannot map TRNG IRQ=
\n");   =20
> > > > >
> > > > > This looks like some workaround against existing gpiod_to_irq(). =
Why do you
> > > > > need this?   =20
> > > >
> > > > Hmmm, I thought that would not work because that line is only valid
> > > > as an IRQ, not as a GPIO (this is enforced via the valid_mask membe=
r of
> > > > gpio_chip and gpio_irq_chip).
> > > >
> > > > But looking at the code of gpiolib, if I do
> > > >   irq =3D gpiod_to_irq(gpiochip_get_desc(gc, irq_idx));
> > > > the valid_mask is not enforced anywhere.   =20
> > >=20
> > > Which one? GPIO has two: one per GPIO realm and one for IRQ domain. =
=20
> >=20
> > The GPIO line validity is not enforced. The IRQ line validity is
> > enforced in the gpiochip_to_irq() method. =20
>=20
> Okay, but does it work for you as expected then?
>=20
> If not, we should fix GPIO library to have gpiod_to_irq() to work as expe=
cted.

Yes, it does. I am going to send a new version in a few minutes.

Marek