Received-SPF: pass (google.com: domain of linux-crypto+bounces-3834-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <caa03909-267e-4f57-8e61-d64d20dbd305@linux.dev>
Date: Thu, 25 Apr 2024 00:00:11 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH bpf-next v10 4/4] selftests: bpf: crypto: add benchmark
 for crypto functions
To: Martin KaFai Lau <martin.lau@linux.dev>, Vadim Fedorenko <vadfed@meta.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
 Alexei Starovoitov <ast@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
 Herbert Xu <herbert@gondor.apana.org.au>, netdev@vger.kernel.org,
 linux-crypto@vger.kernel.org, bpf@vger.kernel.org
References: <20240422225024.2847039-1-vadfed@meta.com>
 <20240422225024.2847039-5-vadfed@meta.com>
 <54ff0e5d-1089-4370-913a-d4fdf2fd8ad1@linux.dev>
Content-Language: en-US
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
In-Reply-To: <54ff0e5d-1089-4370-913a-d4fdf2fd8ad1@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 24/04/2024 23:43, Martin KaFai Lau wrote:
> On 4/22/24 3:50 PM, Vadim Fedorenko wrote:
>> diff --git a/tools/testing/selftests/bpf/benchs/bench_bpf_crypto.c 
>> b/tools/testing/selftests/bpf/benchs/bench_bpf_crypto.c
>> new file mode 100644
>> index 000000000000..0b8c1f2fe7e6
>> --- /dev/null
>> +++ b/tools/testing/selftests/bpf/benchs/bench_bpf_crypto.c
>> @@ -0,0 +1,185 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/* Copyright (c) 2024 Meta Platforms, Inc. and affiliates. */
>> +
>> +#include <argp.h>
>> +#include "bench.h"
>> +#include "crypto_bench.skel.h"
>> +
>> +#define MAX_CIPHER_LEN 32
>> +static char *input;
> 
> [ ... ]
> 
>> +static void *crypto_producer(void *input)
> 
> The bench result has all 0s in the output:
> 
> $> ./bench -p 4 crypto-decrypt
> Setting up benchmark 'crypto-decrypt'...
> Benchmark 'crypto-decrypt' started.
> Iter   0 (209.082us): hits    0.000M/s (  0.000M/prod), drops    
> 0.000M/s, total operations    0.000M/s
> Iter   1 (154.618us): hits    0.000M/s (  0.000M/prod), drops    
> 0.000M/s, total operations    0.000M/s
> Iter   2 (-36.658us): hits    0.000M/s (  0.000M/prod), drops    
> 0.000M/s, total operations    0.000M/s
> 
> This "void *input" arg shadowed the global variable.
> 

Got it. Will do re-spin then...

>> +{
>> +    LIBBPF_OPTS(bpf_test_run_opts, opts,
>> +        .repeat = 64,
>> +        .data_in = input,
>> +        .data_size_in = args.crypto_len,
>> +    );
>> +
>> +    while (true)
>> +        (void)bpf_prog_test_run_opts(ctx.pfd, &opts);
>> +    return NULL;
>> +}
>