Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp1207846lqd; Thu, 25 Apr 2024 08:45:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWSFMOdWTsSD+AMGm8qqdxMOvMjfEz5RnT3PSOtVZ3euYNsl+3nFfw1VQY9OEOpml1Bs6z9LrKdJMHU+Ks1PCnQYqq49HToaeWE51YNmw== X-Google-Smtp-Source: AGHT+IFU0KtRpF4iB7peEspytexBnamyvyuD6v9x7Qg6kEku+nLc6YQmXvHWBMJn97eOvLBUHIac X-Received: by 2002:a05:6830:602:b0:6eb:7ce0:7728 with SMTP id w2-20020a056830060200b006eb7ce07728mr6599115oti.36.1714059948929; Thu, 25 Apr 2024 08:45:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714059948; cv=pass; d=google.com; s=arc-20160816; b=GjHga+yriKF8wL+aLROYtZUTyHRJB0PbRfAcGaaW7C4w/9QCyjrvHMtP6G57WaG/Nt TMRilFoV1lHSBkJFaaAsb76omqPXLWl04Rwrebz7I6XzcgFr6TRLz9fw9u5TyBar+NCX O3YZsjsYQX9fYpb4iuYrLf7yBigi+ghrBhWE2Wf6a12tYhXdGH53W154T16oL6VCiWtE qGfVivzJnoaYei+r0uGWtpRuG8wk1D8IVq018d4T/cGsIOg+W7goirFKIKFWsIy7s6FK gS/IQnJtOzfDkAdBjPVoovtNYFhSbgelj+5Y/p3J8EMsMoToMFO5qQHAKWMPmPkuLWD+ bctw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=ivTRNNRVsf/5/k0lJkiiGxW01LVY2QvpE5H4WN6G1fc=; fh=OztAHqlgMwuJW+TINLqanayM4gN+C1sNOdO7W4jppNY=; b=j4u0oHzzI4N6hNOtr2EuZ1U46WAbkhpt19tpdcBu/gCcB6z0hYkHhZviEr2wIQloIC ufTFBqVRxFdo3JvyLWbBNkw3YQbgX8h1jZhW5VrP7ICrX00b98iGOuXNoxIOFIjf16bk +urW9GkXeh/nIr6lhz9DpWerUrhcip/mR3w70znZ/TO9APuDnx7qDjQEXTSw9TtQdO7J tQoZHHvlx+OX3IUxM0jGYz2YzcRl0FfgqlwGUEjAcWIBq9h840Z8OVegc8b1js/sHy4z toaQfywThVBAv8It3b4Jdx2uC2FawLmdmXd9o1gJPJhzhUwVdpjgfWzz4nukcJ9ZBlRy U6Cw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZWYGpdSr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id wj12-20020a05620a574c00b0078f1a23c6acsi15219772qkn.88.2024.04.25.08.45.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:45:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-3849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZWYGpdSr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-3849-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-crypto+bounces-3849-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F9AC1C21128 for ; Thu, 25 Apr 2024 15:45:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83D5E14BFB0; Thu, 25 Apr 2024 15:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZWYGpdSr" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0921494BF; Thu, 25 Apr 2024 15:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714059940; cv=none; b=iu5cpeyhTdF2fiwKPzDRipXtcxK7VO3AmIbTZtFwL/zPFlbvxbSgS4HfVPbKl8hXj+hFBsYg6AlucgfpDDXIYzkvdfOs2mitxEvAffB4VfnU1msnq1CGyWUZZQV7rPckSBTbAgffZW5kbU8fpNziSIKXxY1MDXfRf5ckmZp676A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714059940; c=relaxed/simple; bh=ivTRNNRVsf/5/k0lJkiiGxW01LVY2QvpE5H4WN6G1fc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QGLJg61VIH/fDRUa78o63dS04yHaImkIqjZlPSLHO1yRXm5zCeKurO4UhPKDHAMtohJLA0gb2wCj95DiCctgvb65L5f4SSKTAUPsZj/hh0pv5I8ZX588TXN0ynI2+Q8iuDddhj6UZKEaDD0xsg2D92ZIoJnoCrOhnrM6UlMKCpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZWYGpdSr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BFF0C113CC; Thu, 25 Apr 2024 15:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714059939; bh=ivTRNNRVsf/5/k0lJkiiGxW01LVY2QvpE5H4WN6G1fc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZWYGpdSrAGjApXVhM4YNwmnftEX8T5ZI8SYKxHx3hfLV9REa9rZXCh8pzr0psmlJW 3C6kep7M2PElbnjoDNXVIApiXuE/RMEIeJu2KHzRfd/+mFlQMGDyaLzTUHOpw0zDB/ 4IAIPyYB0Gmo5Px/Nf+h6sZJqAmSlwi+oA6KFLL8/9qstq95AwZobl0HddXZwKCHOL YJWd2ApjvYBR/5j6XFrFD3OGnf9RqVHRJ/7XByFHlVTOFT0/yb8K4V4JEKOwHCgvvv P1yRt0aGQ/JHzqXdfgPKkRu1qNKTYltSBc9k9rzSCHbnQL8zwihaFfO+a9AEIsfBAL 4Lt8gUNhZIzTg== Date: Thu, 25 Apr 2024 08:45:37 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Jeff Layton , Steve French , Herbert Xu , "David S. Miller" , Eric Dumazet , Paolo Abeni , netfs@lists.linux.dev, linux-crypto@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] Fix a potential infinite loop in extract_user_to_sg() Message-ID: <20240425084537.6e406d86@kernel.org> In-Reply-To: <1967121.1714034372@warthog.procyon.org.uk> References: <1967121.1714034372@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Apr 2024 09:39:32 +0100 David Howells wrote: > Fix extract_user_to_sg() so that it will break out of the loop if > iov_iter_extract_pages() returns 0 rather than looping around forever. Is "goto fail" the right way to break out here? My intuition would be "break". On a quick read it seems like res = 0 may occur if we run out of iterator, is passing maxsize > iter->count illegal?