Received-SPF: pass (google.com: domain of linux-crypto+bounces-3913-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH -next 2/4] crypto: starfive: Skip unneeded fallback allocation
Date: Mon, 29 Apr 2024 14:06:38 +0800
Message-Id: <20240429060640.2451685-3-jiajie.ho@starfivetech.com>
In-Reply-To: <20240429060640.2451685-1-jiajie.ho@starfivetech.com>
References: <20240429060640.2451685-1-jiajie.ho@starfivetech.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YSnluGdoPgc6KGtgPcuO8kbvOYrx5X9IW1X57dbW9D//ZEfavR+Fkv5gdB9T?=
 =?us-ascii?Q?ndRXbRDIeaMO3Nats6vlNGQeYEa5aieVeHaU9QGE61w650Z0Q7pSwjpoFG4V?=
 =?us-ascii?Q?W2+pTELK5S1a/0/vXjTIYDo3RQ/3kgnwsSdG4u3jlRPJBwys82HrKLB/PFqR?=
 =?us-ascii?Q?sC2ynPd1FKNVhwJ37v3u27SXCKGn38kdQ5PJFutfbEvP/Yt4C1WU5VAkwyaG?=
 =?us-ascii?Q?sgfo3INzswrX3p3IgAwWvemQdv0jhv3K4qr3exOrctq0ELtMrQnAGR+x9A6e?=
 =?us-ascii?Q?eBhFK1c+rN7x3CTZC8+BbJLo2xrniou4pN948fdteULCgMpNZ02i3k7RGUPm?=
 =?us-ascii?Q?5smFbhIOihIOHuX998LK4TFCqtTzzpMKCqgm6SSxtZXWVlnxPEWMR7mM8g72?=
 =?us-ascii?Q?BrOYZh3RBbcSXqbVb+xrScy8ILF/YnxstMPxkHsiJnxnLxE6cjyci6U32pMS?=
 =?us-ascii?Q?HtWV63rQFqjeh1P2fGWdxaswgRMDQ92SDnEBHfvjIlJBqIN1g9yInDDEpoKt?=
 =?us-ascii?Q?42W3E1CWhimaY+3bTJlOb48UpAgBLXFUcP8XvUxqmlRXHBuEcHXDa5mzz+ya?=
 =?us-ascii?Q?jJloLrTScoT1UbqOUdDwBz/i7xhLI/yo8KbcpEIZGdcPmv8iX75A8Oo0wFqd?=
 =?us-ascii?Q?sQUwsH3dRLbSS09Ec5c0dg2PIxsX/axAemla4s0Zr4z+22R9yT4RVA+bXeII?=
 =?us-ascii?Q?JjzC7fHnq/fZM3Dg7WzJs/IItsdp/fhMQoDAc3XXwFu9POmxo4fg+6dWJ1MS?=
 =?us-ascii?Q?9Uh+vBuU3t5ehKgZZVhzmFZeGGDAcRUbByc9BqtYsHuIlDEDjE9FKjBbgahl?=
 =?us-ascii?Q?E/HIrK4bz4ayxzQ/hl3rAHB09C62eG/jMSr6QzyajVD8Wdjw7bEX22esqw2H?=
 =?us-ascii?Q?LoNyeip5KBAoxpoosJzM0Y6X2yrlTVe+e6uzpuxf5YpZHJYshOFXgftGnd5k?=
 =?us-ascii?Q?kXIDHhH70EWu6N+aX/KJ3bvB+tGTFun942MHtkl29eRk6IlTf/uV9yl5cLDd?=
 =?us-ascii?Q?QkjBRk8p87Ql95ZVoPJ7lUZBGfwmNXhgR/4JykmQ3gkSisLa/cuk7AdyiOmx?=
 =?us-ascii?Q?oizU+UuUl7gX2fDxQP5Q/GsNVhg4moBz9J6kQM77eoaLywT5sQvH3y5c6b00?=
 =?us-ascii?Q?yuKVtYbpgiONneylBzTknWI4YXreDzHMI5Fe6PLdi05WMXsYO8DRbRDiQPcR?=
 =?us-ascii?Q?9B0rd349aPKAnGo+nL/4IxXQbCesfFr/ibcuo1tpDKQHxgwiiba36ISacJ47?=
 =?us-ascii?Q?THqQd+cUAw0Jk3L5zgna8FUwGJWhd7QYv123vHh5o3YyI1LMBe5V4UgEct6/?=
 =?us-ascii?Q?WKGmph9r95ApgbGcma72XJ5iKEnCmUkXIg4LORH4n2XvY6RCEJA7Hk8xmqH/?=
 =?us-ascii?Q?rD0e3tI2ABMdlFCEzvYYB1a/cwjwnMQ+PQzgH1mS1j9xW3Ey0C0h+ywPeYYu?=
 =?us-ascii?Q?1TZt/GWiDlnytJ3/BUUHc5X1JpbEvuqK3RXN1ardU58bK0BkA0sYGk3vjQfa?=
 =?us-ascii?Q?h0wg60ZSVVK3euw/kT9Rue3MpIuxO3sNDqk3zAyXBY5JYAN/KfSUjgOiyvnT?=
 =?us-ascii?Q?A2TpQEH+H7Yfmx/4LI6VSVsFahAF5scay7ssOpDhjqCo6a3u2eOhtjhr/0bO?=
 =?us-ascii?Q?QA=3D=3D?=
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9320845a-a264-4d73-61de-08dc6812b70b
X-MS-Exchange-CrossTenant-AuthSource: NT0PR01MB1182.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 06:07:57.1709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOypm/fFQ6gHL4Xz8W6p7MTYi5156gkbi2gJ7grPJm5PZEYZDT6ZzyrbpD1lQRazR4xdFg+joNh85yyav8XZImKHZie+mQEubZFXKPJttkk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: NT0PR01MB1278

Skip sw fallback allocation if RSA module failed to get device handle.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 drivers/crypto/starfive/jh7110-rsa.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c
index e642e948d747..4d7eb3d1e764 100644
--- a/drivers/crypto/starfive/jh7110-rsa.c
+++ b/drivers/crypto/starfive/jh7110-rsa.c
@@ -537,16 +537,14 @@ static int starfive_rsa_init_tfm(struct crypto_akcipher *tfm)
 {
 	struct starfive_cryp_ctx *ctx = akcipher_tfm_ctx(tfm);
 
+	ctx->cryp = starfive_cryp_find_dev(ctx);
+	if (!ctx->cryp)
+		return -ENODEV;
+
 	ctx->akcipher_fbk = crypto_alloc_akcipher("rsa-generic", 0, 0);
 	if (IS_ERR(ctx->akcipher_fbk))
 		return PTR_ERR(ctx->akcipher_fbk);
 
-	ctx->cryp = starfive_cryp_find_dev(ctx);
-	if (!ctx->cryp) {
-		crypto_free_akcipher(ctx->akcipher_fbk);
-		return -ENODEV;
-	}
-
 	akcipher_set_reqsize(tfm, sizeof(struct starfive_cryp_request_ctx) +
 			     sizeof(struct crypto_akcipher) + 32);
 
-- 
2.40.1