Received-SPF: pass (google.com: domain of linux-crypto+bounces-3921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH -next 3/4] crypto: starfive: Do not free stack buffer
Date: Mon, 29 Apr 2024 14:06:39 +0800
Message-Id: <20240429060640.2451685-4-jiajie.ho@starfivetech.com>
In-Reply-To: <20240429060640.2451685-1-jiajie.ho@starfivetech.com>
References: <20240429060640.2451685-1-jiajie.ho@starfivetech.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?p4ATjdDrJnF7n2MB705/DQBrQTC8zzSKCcOSopCCYVBLBCUIIgM4wBTeRA/c?=
 =?us-ascii?Q?zYo3X5jT/71uVMqCZ7i32I4hXUxiOVAtEvp37tUWPKC5TIAZwtIpGvs+cVPH?=
 =?us-ascii?Q?LkAgksjpr3cb1r46+ydAlRb9MIkpg8pwG4pajB55fYJlULEUvQFer5B6OLtT?=
 =?us-ascii?Q?eLqodblnLTbBC3xeMK1jdZq9XqJxrJPU7LEHJ2Zb7elgwn2PVmeiEkbxqsOf?=
 =?us-ascii?Q?G+xIvtSEg27r5qFYF+QlaZdBXsIndsvU5x7+OuDcbvUWdeBrLObLp5gyufn2?=
 =?us-ascii?Q?tQG5As8sr1qiVkP59cyAZAcQzlLEwBGFursEzkcc16g9cMhHbNWpAr485RhC?=
 =?us-ascii?Q?Iclgr2ydsVYyhtoxFxBIOVRrLak7jlq3TQHzUF8fKn3hjzk8mGtXUqoAzAX6?=
 =?us-ascii?Q?M/8TY4X9EenSSFD5N3VWLLL3yldefbtOSAUeoQEWaQZSF+lEWLzYxqX8xtFJ?=
 =?us-ascii?Q?Gxu4bWr7SVuPbEwSvbK7JLB0cZ/KHy9x/5/p4JFFmerDP0/zANRAjOOJuFOu?=
 =?us-ascii?Q?O9mAwYTRrmC+yPKUZHySrvYb5aDDMr4cTgpnGRR1+5rspHXUskRrdkvjt31B?=
 =?us-ascii?Q?CBkmT1Y/+ziMvugNLWs7AGZlOQWogC10yoJPBSwE3EG+8u1qZAjIAxGW6w+l?=
 =?us-ascii?Q?+dUMyIiEaGMnBdkRVSdCyLuF9BmKfMIQd7buXmL42NN8EoLP0A4vQgu2zs1E?=
 =?us-ascii?Q?nzylwv2hAhIcVRcN346tcZhywW01el6ruMdIJy3INVVXSkj5bdkqOB4SnP5f?=
 =?us-ascii?Q?npIjLVvUFGubnKQXMYksF8qrY+pNa3hbZZnVQwl1wZTgJOpKypZIfPmmZAH0?=
 =?us-ascii?Q?AL3ioJGvoZlU7F3AoL4uvIMq47sH2FFsIUc5rBd3g5OzLiws6B5YxmdE9oKc?=
 =?us-ascii?Q?6T/AALG7mxVohPbNPlraXtt3sIlEpcogWUxZxcAHUL4pniPwKE6W1g21NnQP?=
 =?us-ascii?Q?yWu7MCskHB40Pcrgf8wLwNh7IYrASLmhQTJu3UhCxpIWaoHUuePn1wkHASzW?=
 =?us-ascii?Q?oUh1gyUPczpW/yNMgBsA48y97Zc/dugHcIF9MJCpUnJigrNrbU353XFkLzsf?=
 =?us-ascii?Q?E7SAF8ZvNSFeiueT+zsA2F3TCWMHVPZQ8dxPGnMeDQEEE037S+Xdsto7c+NA?=
 =?us-ascii?Q?Mq1Be0711D+RAn50iGAwg44eDYuxbaOUjOnDsfHiLsgs4/+n2w5BdEKZtfE+?=
 =?us-ascii?Q?Bt+hhu4ZFrg1/5pzDi1TKwB9mlrHkoBDhHTiVrQ1AvNMtgnohqr+swcCnWKU?=
 =?us-ascii?Q?F4Xm1kpZg2AlA0bQIz3hdzfaPr1G+1MxY1/UP24vN4qDtjdk3ONWa7FPiae3?=
 =?us-ascii?Q?v8G+eeW4WtH3JdsHtJmMGFf7o4/myQxATplh/AmbV7/dMjo6oI96dQ44hcfb?=
 =?us-ascii?Q?z4B6UmdBrT6uAkoxRfobYdr46BgbVwI+upl03fyGlAEdWXGYI6lXRdp5TUXz?=
 =?us-ascii?Q?Vm6x8g2Dqo8CTqi1kWAjQJ2eV9E0sit6+wlnXnJGImm5ZhBtfHuLpEJqLSV3?=
 =?us-ascii?Q?/Ym7xq06EScTrihrEvkphxpYNKUF0mCi307iC/NwyGwRjjQTVCaautndq7md?=
 =?us-ascii?Q?IjsVp/K74IkHJdcYYAzS0I42ThYHl2RuSX8VBljGSTp5qNsOObUaE7WyeWqg?=
 =?us-ascii?Q?SA=3D=3D?=
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4862c3-3634-45d3-26dd-08dc6812b7d2
X-MS-Exchange-CrossTenant-AuthSource: NT0PR01MB1182.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 06:07:58.3851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e+mQlKvQXLQtcUIjqA6wtYoPLxWkAFZ6MGw5nK7Em3CeYPBOVb473jzCqw79sEIPWieB3TSAB3If5hXjCzvCvcFP8EIHH0J4zGiU3sNgTAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: NT0PR01MB1278

RSA text data uses variable length buffer allocated in software stack.
Calling kfree on it causes undefined behaviour in subsequent operations.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 drivers/crypto/starfive/jh7110-rsa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c
index 4d7eb3d1e764..33093ba4b13a 100644
--- a/drivers/crypto/starfive/jh7110-rsa.c
+++ b/drivers/crypto/starfive/jh7110-rsa.c
@@ -276,7 +276,6 @@ static int starfive_rsa_enc_core(struct starfive_cryp_ctx *ctx, int enc)
 
 err_rsa_crypt:
 	writel(STARFIVE_RSA_RESET, cryp->base + STARFIVE_PKA_CACR_OFFSET);
-	kfree(rctx->rsa_data);
 	return ret;
 }
 
-- 
2.40.1