Received-SPF: pass (google.com: domain of linux-crypto+bounces-3963-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Akhil R <akhilrajeev@nvidia.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: "thierry.reding@gmail.com" <thierry.reding@gmail.com>, Jon Hunter
	<jonathanh@nvidia.com>, Mikko Perttunen <mperttunen@nvidia.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH v7 0/5] Add Tegra Security Engine driver
Thread-Topic: [PATCH v7 0/5] Add Tegra Security Engine driver
Thread-Index: AQHaha3gsfDBlfEn5kWsP3WoOvnfvbFkS2CAgB2iPLA=
Date: Wed, 1 May 2024 04:52:05 +0000
Message-ID:
 <SJ1PR12MB63391878683E395E6A3641FAC0192@SJ1PR12MB6339.namprd12.prod.outlook.com>
References: <20240403100039.33146-1-akhilrajeev@nvidia.com>
 <ZhjjNWKexg8p8cJp@gondor.apana.org.au>
In-Reply-To: <ZhjjNWKexg8p8cJp@gondor.apana.org.au>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?wHcV1K5c1kuu+GhfKfkM+a3WeTyNlsc+i9bwvcKsQiWkdcciwCfx0PxlApxI?=
 =?us-ascii?Q?1fWYli6BckGK6PLP7anAfmzrzYiUb8xp6lwfor3VRBceXloq3K5Q/2NArd2g?=
 =?us-ascii?Q?/cPB29OG70LEq9nVT9iAItWPgaFdNG6sCk16zFYdpXyWoF3PS4lRNc/y4agS?=
 =?us-ascii?Q?DWFxnBe56OqxS/4E37F3MeqIplg83wmvoFGXErux1nJsBgKUDEi9fdd82ba+?=
 =?us-ascii?Q?N3Xs2t6Oh/XqC6cnundDUF/bvEV1swRlrbFrX+UiRxkaLdcFupdHiCHnohvn?=
 =?us-ascii?Q?Cjj9YmOsfL5Um8rPhD+UOuZx28CJYVEr3ezlQPl9MjsHo3rm89JAuW9XKuTx?=
 =?us-ascii?Q?szqDALh5ID54LnlMLWwhWAbc/FPqRKULQJrjinf6zCUWJMwiSqW9b8vt3m0B?=
 =?us-ascii?Q?oYrmeTXXGNF46JK7+CHHo1CW8JZtwsHsjVEEkjptNBYp4tBIZBuzN/YDPO10?=
 =?us-ascii?Q?cWeeHOylvWLupDi8WUU84kvyUEmljC1Ij/cat/0PvW+0E4Qk8c8i6pdIdzWk?=
 =?us-ascii?Q?tHiIAsmhKPqeV+6Ko75V8PNbzAUQ1ujZ99YqhORBC1TYCCs23ndsi7Dz45Td?=
 =?us-ascii?Q?Zgie/6FjtoKXFa6mm222nLVs6gJBtcUaPD0EXdv9+x7RRFZNh/lPYOz7TATS?=
 =?us-ascii?Q?aFJ5jkHBUXvYIm4tWZOtQ45JU3GNVGd8P/zA1NmlQeuttoaNUrWoPswTogpp?=
 =?us-ascii?Q?uSdlTFvChUPXrZyG42aHZ4ag18r9sliuh/lRwpq+xhJowfXWqMOFX+1Hztpc?=
 =?us-ascii?Q?v7mJTQnNMf+0+MxoESuaTcfpRytBvLMrzEuUrSwgyFh4V1UE+0vQgJra0c+k?=
 =?us-ascii?Q?0fPE216kHHZbr7IQWH3SQflS0+8Btt4mAzkuJdE7cOej69rQPcfSYKzQsRqe?=
 =?us-ascii?Q?3IVXcFDuSNZGlDW7/fFaW2sj2lHVQLOYsXF4P5Fg7Fy1zZAXAdY7mrAwVECu?=
 =?us-ascii?Q?jNM2Ce656n77vkkXXXXHQ63Vtp7wG+nEjBOzcBy8pN/xzlqEZuftmtzQQ+dN?=
 =?us-ascii?Q?ZmVT1wIUonCGMOTECPBQuHnz0HndxB0EuJr3KBfZuxbo+pL6AHad82JqWtyL?=
 =?us-ascii?Q?Cxy/wXPD4RbhsAW6uiUB/fCUtrF/2TYttYRJMFIYzfZ7rQ0Crgwc0cwEUUYI?=
 =?us-ascii?Q?+Uh8+PXJG60+/5tupO9N9s5yAP5blHUOLlkG+r1dJv3BBMNR8TKz+rTgqcAf?=
 =?us-ascii?Q?ifbe3d8TmIQvWk6iwG44Abn5dganH7N+9syWcz7H8DiOdWyXM6zJcIRKobEy?=
 =?us-ascii?Q?l0HZ07VoEoMxlJ0HPCKLFZ3qKRIMOWrpDoKrQ4OTI3Wc8PTF8BUA11Nw692q?=
 =?us-ascii?Q?uXYzgHf3jzzA3LmHKvwaxCslIYz6sc/vhlZ1LycPUXcdok9pPviMqDf1lbvS?=
 =?us-ascii?Q?JYwzjbTzyZeXrFWlaoMXpEa3N4OBGRW8YC7bhwBfM0OlFHWksNdBJdoFFGj8?=
 =?us-ascii?Q?PbP036+rmyha8E467WoJ+UMFT7wG0B4A3Qbiq1Zq6y0VvkhGLdJmMMIuRcri?=
 =?us-ascii?Q?bmK7rn6q6D/GoOLbMug9YiJORWPn3wqyVhv5ovwXYny0jXxLK3AKlcmF4FIU?=
 =?us-ascii?Q?J8UFqEVNsQatB3NOxwh7MZBalllZOq4+WsZ8voEOFWQ0gGHA5lJdgTO4uyTe?=
 =?us-ascii?Q?Ow9ENGWFgbYwISNRrgFpzeFQxhnH6ZBTTKp++ckU3hk6?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ec65128-6772-4af9-5960-08dc699a72f9
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 04:52:05.4096
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bH+s0/uqC+JTzr2UfqoFMfXdMY+Ohwr5cuYjto/IPzNAkTDkzDrZclMA5qDuJ7H4D+gX7XDYn/wyipXiJT9YGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4295

> On Wed, Apr 03, 2024 at 03:30:34PM +0530, Akhil R wrote:
> > Add support for Tegra Security Engine which can accelerates various
> > crypto algorithms. The Engine has two separate instances within for
> > AES and HASH algorithms respectively.
> >
> > The driver registers two crypto engines - one for AES and another for
> > HASH algorithms and these operate independently and both uses the
> > host1x bus. Additionally, it provides  hardware-assisted key
> > protection for up to
> > 15 symmetric keys which it can use for the cipher operations.
> >
> > v6->v7:
> > * Move fallback_tfm and fallback_req to end of struct
> > * Set reqsize and statesize based on fallback_tfm
> > * Remove ofb(aes)
> > v5->v6:
> > * Move copy/pase of intermediate results in export()/import() to
> >   'update()' callback for CMAC as well.
> > * Check for rctx size when using fallback alg.
> > * Updated blocksizes to align with generic implementation
> > * Combined GCM and CCM init into aead_cra_init
> > * Updates to handle invalid cases better
> > * Reduce log levels for invalid cases to dev_dbg
> > v4->v5:
> > * Move copy/paste of intermediate results in export()/import() to
> >   'update()' callback
> > v3->v4:
> > * Remove unused header in bindings doc.
> > * Update commit message in host1x change.
> > * Fix test bot warning.
> > v2->v3:
> > * Update compatible in driver and device trees.
> > * Remove extra new lines and symbols in binding doc.
> > v1->v2:
> > * Update probe errors with 'dev_err_probe'.
> > * Clean up function prototypes and redundant prints.
> > * Remove readl/writel wrappers.
> > * Fix test bot warnings.
> >
> >
> > Akhil R (5):
> >   dt-bindings: crypto: Add Tegra Security Engine
> >   gpu: host1x: Add Tegra SE to SID table
> >   crypto: tegra: Add Tegra Security Engine driver
> >   arm64: defconfig: Enable Tegra Security Engine
> >   arm64: tegra: Add Tegra Security Engine DT nodes
> >
> >  .../crypto/nvidia,tegra234-se-aes.yaml        |   52 +
> >  .../crypto/nvidia,tegra234-se-hash.yaml       |   52 +
> >  MAINTAINERS                                   |    5 +
> >  arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   16 +
> >  arch/arm64/configs/defconfig                  |    1 +
> >  drivers/crypto/Kconfig                        |    8 +
> >  drivers/crypto/Makefile                       |    1 +
> >  drivers/crypto/tegra/Makefile                 |    9 +
> >  drivers/crypto/tegra/tegra-se-aes.c           | 1933 +++++++++++++++++
> >  drivers/crypto/tegra/tegra-se-hash.c          | 1060 +++++++++
> >  drivers/crypto/tegra/tegra-se-key.c           |  156 ++
> >  drivers/crypto/tegra/tegra-se-main.c          |  439 ++++
> >  drivers/crypto/tegra/tegra-se.h               |  560 +++++
> >  drivers/gpu/host1x/dev.c                      |   24 +
> >  14 files changed, 4316 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-aes.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-hash.yaml
> >  create mode 100644 drivers/crypto/tegra/Makefile  create mode 100644
> > drivers/crypto/tegra/tegra-se-aes.c
> >  create mode 100644 drivers/crypto/tegra/tegra-se-hash.c
> >  create mode 100644 drivers/crypto/tegra/tegra-se-key.c
> >  create mode 100644 drivers/crypto/tegra/tegra-se-main.c
> >  create mode 100644 drivers/crypto/tegra/tegra-se.h
> >
> > --
> > 2.43.2
>=20
> All applied.  Thanks.

Hi Herbert,

Thanks for applying the patches. I see that the driver is in -next now.

I had a question based on some of our customer feedback with this driver.
While running tcrypt mode=3D10 with Tegra SE driver, it shows errors for lr=
w(aes),
rfc3686(ctr(aes)) etc. which it does not support.=20

I was wondering if there is an option to skip unsupported algorithms in the
Tcrypt test. I don't see any vendor specific test modes in tcrypt as well.=
=20
Could you share any suggestion on the best way to handle this? Or is this a=
n
expected output of the test?

Thanks and Regards,
Akhil