Received-SPF: pass (google.com: domain of linux-crypto+bounces-4010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fb10f878-fced-4e2d-9491-c3555e50b822@nvidia.com>
Date: Fri, 3 May 2024 10:15:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 0/5] Add Tegra Security Engine driver
To: Akhil R <akhilrajeev@nvidia.com>, Herbert Xu <herbert@gondor.apana.org.au>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
 Mikko Perttunen <mperttunen@nvidia.com>,
 "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
References: <20240403100039.33146-1-akhilrajeev@nvidia.com>
 <ZhjjNWKexg8p8cJp@gondor.apana.org.au>
 <SJ1PR12MB63391878683E395E6A3641FAC0192@SJ1PR12MB6339.namprd12.prod.outlook.com>
 <ZjH3zzInVjY+qOH4@gondor.apana.org.au>
 <SJ1PR12MB6339E3A141B161F28E5C76B4C0182@SJ1PR12MB6339.namprd12.prod.outlook.com>
From: Jon Hunter <jonathanh@nvidia.com>
Content-Language: en-US
In-Reply-To: <SJ1PR12MB6339E3A141B161F28E5C76B4C0182@SJ1PR12MB6339.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cE85S2Y5anlWTVJRMnhuekRUNUdsKzVtOTA5bUJ0M05HT0dKeWlKTXE3L3ND?=
 =?utf-8?B?UWdvajBRM08rWVplMkI1cm9rQzhrek5xd3c4YUp5RWNwTUN3K1gveHNHU0kr?=
 =?utf-8?B?SmNTejhpVmVSZkQrM3pyWUdWR2NnSDdVWGtwTUV5ampMeXpHeWFTczJjTkts?=
 =?utf-8?B?dHpTaG1ycElHVjZHVy9rWFBjS0JSbGFIQTIwOFhSMHJBSFZEeFdFTzI3dmM0?=
 =?utf-8?B?b0NXUHdCWjZGZlJ0MnBRUzhkMHgxdy9WRmxUT1dTdjJXRWVXUW5jOTdhSVZx?=
 =?utf-8?B?NWxnTEFzTit4ZjFDYW9UY2lMbUxDSnJNK0VVdFVvdHlIbzBHSnc4TnVGanhi?=
 =?utf-8?B?Z1NvYThPbDc0bWVEZjJ0dEozczBVd29xRVhjNzVHd1ZtWEQwZjF6WTBHT093?=
 =?utf-8?B?OHBKb2U5TUd1b2hqUGo2WjcyaEhTSy9Jc2ltOU5lejd0MjROL3JUR0xzRGYr?=
 =?utf-8?B?TVF4WjV6cm15OHhNRGkwU0tQV21xV3RaN2xyTGE3ekxvay9xK3paOVY0YXRL?=
 =?utf-8?B?SWdDMkUrUElzVENZd1ZaMmtFMVdQVTJTNjMwTmhGcCtkUENUOUlYZXJheFpz?=
 =?utf-8?B?UUxieHhlVnNJWlo4azZ1WHg5U0QyK3RFV0RpK3Q5TkF4RU5aYmVnYWxmS1Jy?=
 =?utf-8?B?ek5ZNDZIOUl0Wm56T2RYOG1pb1EzZ3ZtVlhLTXZQb21ITlhvaFM1Y0s5SDJV?=
 =?utf-8?B?VmRtTm1WSzR6UzMxaXlpYlVEL29HbTZKZFBwRWFZRUg5YzBBVyt0ckhsRFVH?=
 =?utf-8?B?UE82azJjTlpWZ0hhUG1QY0pZams4OGtnUHNkNFh1YTl0b0t3ZVN5TTU3aDlr?=
 =?utf-8?B?ejZidmI0K1ljcUtrQ1VIVnQrd3hqMHM5SWkrQ2xXak5HZGEwaEdyemc5WGMr?=
 =?utf-8?B?K3Q2cEswOS8yQnR5WVVEL3A3NDE0VG5rWUJ1eFdVRmpaWmR6TnRiWTZ1Nk95?=
 =?utf-8?B?QXBuQXE4a2tDUXB2aFZER21VUHR1Y08vN3BaeURuQy83Z2pWNWplbk9UQWw2?=
 =?utf-8?B?eWZaOGt0RnQrTWU2SjdCYzYreW5QRk5mbjhiOVFVV1luTUh1dEhvdzF5RnR6?=
 =?utf-8?B?SVRKQXVQN3M2cjJNRSt1K3Q4UjZWT1RFNFU1T1VlWGZQZ01XRmhyaG80ZE5h?=
 =?utf-8?B?bXZvNUdMcXJYQmtyV1I2eW1xSkRmaUZwTnFNL0F5Lzg0VWRDWWQ0dnZHRjZO?=
 =?utf-8?B?YXNZQUhtNTNQcDNLbFBrc3NpeGpVWUljK2FSNFFkODN2dG92U1M2cDRBMURB?=
 =?utf-8?B?VVhXcEpWeWNncFpLRXozRXlPLzl4L004QStBYnRDVmI3K05YNXExdjhnWWJr?=
 =?utf-8?B?TllYbkRyZjNYQTk5NlBLcXlBMENjMGxad1o5UDNpOHV2cFczaTg3allkU1J3?=
 =?utf-8?B?QmpsL25aNWVKMGVjczhsMFd0RUdlNDNEeVkyY3NsTlpQaWNJNjRNUEduV0s1?=
 =?utf-8?B?SnVzV0NwNm9aZFliK2drSFVRTDBsb25mZ0N5SVA0SE56eU1LQ1Z3VUNDbHl1?=
 =?utf-8?B?dDB4KzRTNG5WQ0dqOTVRTUlFRURTbzBTK3dYVFZucjdtd2tVajUreUVWR3RM?=
 =?utf-8?B?TjVod1RISDE5K2FaTlduQjAvWXpuZDdaNm1nV1VNbFRzZTQxMVl5ZnVkSm1a?=
 =?utf-8?B?a3B6TndRWE52Q0d6YUx0djJvT3dZc0VndU1ReEMrbkZ2aVpBZlZTK0tncXIx?=
 =?utf-8?B?V0NmYVA4ODY1M0pMbkFjL0UvRVdsYmF4NjVHNVl0RlgvOHlCcGpoY0JvQ0I2?=
 =?utf-8?B?Qmt1bWpsTEM0a3RFMXZkcER2NWVKZEp5djF3SE1HUVFoTHpoU3hVMDJIWjZy?=
 =?utf-8?B?ZUdXalZSUDEzUzFTQ2VsZTEwd2xNVFMyOER3S3laRVJNSmxSNERFQWJLVmFn?=
 =?utf-8?B?dWcxTng3ZUVKeDRaMXZWRW5RSG13dk53b1hqV2N1cUtpQVpyNzQ1TGM1Zk94?=
 =?utf-8?B?eXRBbkpMeDdsZXBFL2dkaU1TdDRwaDVoYnRrWjU2TzdOamRHV3IxUEhNTW1y?=
 =?utf-8?B?QWY5ZFhyUzh1dnFJNkVtNEVLSGZpYk9LcUlrN0IwU3ZNVXA5clVzL1NQY1Vo?=
 =?utf-8?B?bThjYXpab3NxNG9lNnJjWDBKT1NPNUtRRmVxa0VURHZtUVQ5Ujd6ekZMWTI5?=
 =?utf-8?B?cHh6OEVtS0Q1dVVIMmRJMFcwaEpodnVJTDVQamFHSHRkMmdaMGYzWEVWTVU0?=
 =?utf-8?B?Qjc3YUpOTmdVV0J2ZnZMblBQOHNyMWhwRitibTVVcmNzZ01vSGwrUStsSHl2?=
 =?utf-8?B?N1kxZkFISFBtMFgyNTA4b1hObUFRPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47f78ae3-ba75-4d8f-4fc2-08dc6b519980
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 09:15:39.4014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cLP2a05KvfOrXofJJ4Uy8f1WG5BCY43AKJ3od5MYABAlGjtuSBcnTtL3r/iHHMirsgHll7po9ecCKD1Wa0Oueg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7609


On 02/05/2024 15:56, Akhil R wrote:
>> On Wed, May 01, 2024 at 04:52:05AM +0000, Akhil R wrote:
>>>
>>> I had a question based on some of our customer feedback with this driver.
>>> While running tcrypt mode=10 with Tegra SE driver, it shows errors for lrw(aes),
>>> rfc3686(ctr(aes)) etc. which it does not support.
>>
>> Algorithms that are not supported by your driver should automatically
>> be routed to software implementations.  What errors are you getting?
> I get the below error. But this is because we don't have CONFIG_LRW
> enabled in our defconfig.
> 
> [ 1240.771301] alg: skcipher: failed to allocate transform for lrw(aes): -2
> [ 1240.778308] alg: self-tests for lrw(aes) using lrw(aes) failed (rc=-2)
> 
> So, I suppose enabling the defconfig is the right and only fix here?

Should we be selecting for option for Tegra so there is a clear dependency?

Jon

-- 
nvpublic