Received-SPF: pass (google.com: domain of linux-crypto+bounces-4037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <fcff2634-21ba-4fe8-bb96-2c097adb0656@amd.com>
Date: Mon, 6 May 2024 10:08:45 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] fpga: zynq-fpga: use 'time_left' variable with
 wait_for_completion_timeout()
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
 linux-crypto@vger.kernel.org
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
 Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
 linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20240502210038.11480-1-wsa+renesas@sang-engineering.com>
 <20240502210038.11480-3-wsa+renesas@sang-engineering.com>
Content-Language: en-US
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240502210038.11480-3-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2RyNndIcFY0UitKZDZUVTNZQStEZjVOUHVjTXFXWmxOTkM3OXhtQVZIN0Yz?=
 =?utf-8?B?MnFVV1hxY2NmTUtxc2hIQ2pnUjE3YzVuUGhmblpDbHNhRW10Sjd5cU1DWUdR?=
 =?utf-8?B?VUQwSTdDM3IzNFg1VmpWbDlONXh1TCtpQmlMWXEvNFZkcHdSMUErVG9NSnA5?=
 =?utf-8?B?ZUhpOXNVazZ3dkZxejBPYVQ2dm0zYjZhYzV0WGpqREdPM0NjVDFrVmZrZlZP?=
 =?utf-8?B?bWFQTDI2alNlUjdtbEY3Z2Z2MWVhRytneDV3Um4vWk5ONWRGTmhiQWNQdzhn?=
 =?utf-8?B?VVRldDBvTE5HemY0aGpYT2JWcTQ1Z3BUTjFubVAxM2Y4RFlnWnM3V2dXYjNv?=
 =?utf-8?B?Ny9qd1d6Z2w0MzVFcys1Q01xSXhTZjF0NENHeWN4MXpPZExrK21jV084Y0ZO?=
 =?utf-8?B?eWxQMHU2Z3BONUpOc2pnU2JCWkdDWUk0SGFPSmc0Y3lCUEszczIzUXRNdXpJ?=
 =?utf-8?B?TXZCYkoyMjd3T3pqYk9GM3ZRdit2T0xpY2hGTWNqVWRhOVk4cUw4a3JSSTIr?=
 =?utf-8?B?NVpqQ3doSFdLUlo0MFMvZUlQMlV1N0xjdHd2Rkx0RFFoa0J0RkhPUWIyUWRT?=
 =?utf-8?B?YU12YnVqMm0wb0U1RFd2UGtMeEJGMm4xUlh2cjJiQkdoSm9wU01mTkxZNUVw?=
 =?utf-8?B?TjZlTjd6ZXVxMHlRajgvMUwyTVQvZjZaRExBM0ZXbWNTN2hZSEE2WU1YSFd5?=
 =?utf-8?B?WGNUYXc2a05BSGx6aWVPQ2VPeEZ5Y0lUSmVOeHJBU1FmTTRETTRmazYzZjhz?=
 =?utf-8?B?VXorM0xCOVVhd1R2S0pWbE54UVZYYzVvQ2dzRXMyZW5zVHdsRzFKU3Jqc2xk?=
 =?utf-8?B?bE94UWNlRzk2bzVHRksyZElzdzZUdHFnZDNHNkQrOG95ZzhDcW8vM2loSnRH?=
 =?utf-8?B?ZldEQXplSDZSYnZqcEc2ZUYzV0IwUkFodGcycVRZM05HZStjVXE2WnVIVUEw?=
 =?utf-8?B?OEhheVlxc09yM3V3NENXVnlpWVErdGo2cTV0dkZHY0xCRWtHQVdjY0xobW0w?=
 =?utf-8?B?cEZ2dkRoMk9uNkF6N1pmcFkwOFZHSkIwdVFwZUdqeXd5Z1VSaTNDK2lnbHMy?=
 =?utf-8?B?Vi8zTG82dWlER2YyMUgvTkJIVTNnUXpRVjVJeld3dUVPRkpFMXJkT0FndVJI?=
 =?utf-8?B?SlcyRDI3VTI3T1hFc0xqVE95dERpb3NMSDM0YWJxNzJoZ2lzQ0lXMWJIWDNo?=
 =?utf-8?B?SFVRTDZxTDhSaEZaTGN0bHRJME9qNVZRZ25oV2ZzRTF4WEdGRGJnMGtFMFlm?=
 =?utf-8?B?K2NXeG13SXMvaktxN0wwRk9OSjJGWEZ0L2FSa0RvRGRwMXlrMHFtaEh0NnZO?=
 =?utf-8?B?TlpmeG5EakxXeUJSSFpveWZwa1lGNDR1MFVqOWtvK2RCdkkwOHI2YzlFV3pt?=
 =?utf-8?B?Skd2N3BvcC9QZnN6QXEwazR1VzNuZUxvaWdoT2pWVks5YUhLNlFsMGE2elho?=
 =?utf-8?B?QmxDaFRwODFQZG1oMlo2bDU4bmNKQXE4NDUxdXZPV2NFbXZCNlZTNVJpNHlT?=
 =?utf-8?B?cGlod2hUUDlPVHNmbWZDR0dtRXV0ZFJudG9PVkxveEtTazBZcXZ5RVVJVGNC?=
 =?utf-8?B?MUQybURUQW9SOVRib1pPYVNaTHJGQUpoS0lEaVNnbm54YkI5Q0xSNEVER2FP?=
 =?utf-8?B?QXdNdnYvY2ZkSC9EQlZwMmI2aGJsNmtYNks5YzI4WTVubk8raktuRktaSm5J?=
 =?utf-8?B?Z0FxTFFIZjlKdkVjVXlySnRqNytVSHpnSkYydVpYNFhKcHNIVzJNZE02anlI?=
 =?utf-8?B?dVJWcDZBa0RQMjNjMDFmSXI5bHVKc0lhczkrQkFQRi9nTDB5R2xXakJnRWUy?=
 =?utf-8?B?cVdpbHNHUzBZWWRxT1VOWm9PUmFiY0daVHpwb3RLU3dKQytoZ21iVlIycWUz?=
 =?utf-8?B?SU8rMWpkcFlwT01ydCtkZ1dJL2RNVTI0OHhqaHdmNWozaHpRR3N5dTNOaTYw?=
 =?utf-8?B?WGE2dHJJempGK3Jmam1GS1JmVzVMa2g5bFoxNmtWRW8wQWhnY3pPYzBVM0tI?=
 =?utf-8?B?SytvSm5FbFBad0xrbXdENTFsVi9jZEw2NkZUTnFEMUhtSTVVNkRxUFRNa1lT?=
 =?utf-8?B?SENvalVWSmViMklsdCtZTlcwVmRJWVhnNVNSTlFjL3pKUUYxYUU2WkJUM28r?=
 =?utf-8?Q?zr7djLCe+ilOY/uiD0hAPeTwW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 430ddaf0-7829-42ba-8677-08dc6da3c7ad
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 08:08:57.9338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NlDe+YME2YxiPdymKY7JU6NC4QGplQQE/1xSk1rqr3skqc+z6byJN+FxzK0S95LT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9109


On 5/2/24 23:00, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
> 
> 	timeout = wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>   drivers/fpga/zynq-fpga.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 0ac93183d201..4db3d80e10b0 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -387,7 +387,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
>   	const char *why;
>   	int err;
>   	u32 intr_status;
> -	unsigned long timeout;
> +	unsigned long time_left;
>   	unsigned long flags;
>   	struct scatterlist *sg;
>   	int i;
> @@ -427,8 +427,8 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
>   	zynq_step_dma(priv);
>   	spin_unlock_irqrestore(&priv->dma_lock, flags);
>   
> -	timeout = wait_for_completion_timeout(&priv->dma_done,
> -					      msecs_to_jiffies(DMA_TIMEOUT_MS));
> +	time_left = wait_for_completion_timeout(&priv->dma_done,
> +						msecs_to_jiffies(DMA_TIMEOUT_MS));
>   
>   	spin_lock_irqsave(&priv->dma_lock, flags);
>   	zynq_fpga_set_irq(priv, 0);
> @@ -452,7 +452,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, struct sg_table *sgt)
>   
>   	if (priv->cur_sg ||
>   	    !((intr_status & IXR_D_P_DONE_MASK) == IXR_D_P_DONE_MASK)) {
> -		if (timeout == 0)
> +		if (time_left == 0)
>   			why = "DMA timed out";
>   		else
>   			why = "DMA did not complete";

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal