Received-SPF: pass (google.com: domain of linux-crypto+bounces-4056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240426042544.3545690-1-pavitrakumarm@vayavyalabs.com>
 <20240426042544.3545690-4-pavitrakumarm@vayavyalabs.com> <ZjS8fQE5No1rDygF@gondor.apana.org.au>
In-Reply-To: <ZjS8fQE5No1rDygF@gondor.apana.org.au>
From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
Date: Tue, 7 May 2024 09:49:57 +0530
Message-ID: <CALxtO0m2wC3=yP5zE3_2nboVBVRVuhwuHx9Pdfj25wynky3E-A@mail.gmail.com>
Subject: Re: [PATCH v3 3/7] Add SPAcc ahash support
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Ruud.Derwig@synopsys.com, 
	manjunath.hadli@vayavyalabs.com, bhoomikak@vayavyalabs.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Herbert,
  Yes, we have enabled the CRYPTO_MANAGER_EXTRA_TESTS and
all tests are passing with the default 100 iterations. We bumped
the iterations to 500 and verified that as well for all our algos.

About the export function, yes its hash state that's present inside
"spacc_crypto_ctx".
which also holds the intermediate digest. The SPAcc IP supports
multiple hashes,
ciphers and aeads. We use the same context structure across all algos. Do l=
et me
know if that needs to be modified.

Warm regards,
PK


On Fri, May 3, 2024 at 3:59=E2=80=AFPM Herbert Xu <herbert@gondor.apana.org=
.au> wrote:
>
> On Fri, Apr 26, 2024 at 09:55:40AM +0530, Pavitrakumar M wrote:
> .
> > +static int spacc_hash_export(struct ahash_request *req, void *out)
> > +{
> > +     const struct spacc_crypto_reqctx *ctx =3D ahash_request_ctx(req);
> > +
> > +     memcpy(out, ctx, sizeof(*ctx));
> > +
> > +     return 0;
> > +}
>
> Did you test this with CRYPTO_MANAGER_EXTRA_TESTS enabled?
>
> When a hash exports its state, it's meant to write out the actual
> partial hash state, not a bunch of kernel pointers.
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt