Received-SPF: pass (google.com: domain of linux-crypto+bounces-4077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Sergey Portnoy <sergey.portnoy@intel.com>,
        "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>
CC: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "qat-linux@intel.com" <qat-linux@intel.com>
Subject: RE: [PATCH] crypto: tcrypt - add skcipher speed for given alg
Thread-Topic: [PATCH] crypto: tcrypt - add skcipher speed for given alg
Thread-Index: AQHaof0Xe/RFI8D1nUuFu7qbncfH47GPTHNw
Date: Thu, 9 May 2024 19:58:23 +0000
Message-ID: <MW5PR84MB1842E5564DD90B9599AFD5E2ABE62@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20240509113703.578583-1-sergey.portnoy@intel.com>
In-Reply-To: <20240509113703.578583-1-sergey.portnoy@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vMrzpGUfCfrH85fFFpRGCIUgR3wu7H48vOqFFuWvs72b2KA6yyVAz8M4JC2U?=
 =?us-ascii?Q?vHvS/6g7mTKsXMS022i8YsrGXpK9D101Dnb2By4iWoqzeqdRB/YI4QsSB2ct?=
 =?us-ascii?Q?8XKCHIaVztLsxJWZY2XrWhxOnKBwwgygLmALs2UMsqEMUzb0SEd9n6JzGL1m?=
 =?us-ascii?Q?xVWYaHxfPd0F76o9YmgOzEYB0S6KiHJSMBQhroXxtDIqumoAhOiJTaxnmMLz?=
 =?us-ascii?Q?5xQ/d7E1YGmZQfVs5ayCOgZGjnfSpCp6VnJ9qn+pCPklIXF+LXHFdHtLfcoA?=
 =?us-ascii?Q?+I0PR/s+jDdO3gIV/AFcC9EeMOhtru0CFNc4YnKzz+55qC3///HrUCAzeqD6?=
 =?us-ascii?Q?eF95tL9CuVmuuOoWc3IC7UODaK4GTFsJVnle9abnsIxBF53XA0r6ow7zj3tB?=
 =?us-ascii?Q?Fj0UFWIRfSQL8mlXm/8RxWU1rS0JZPpcaoxfME4M8tavuLDZUDUbYpqArfg1?=
 =?us-ascii?Q?uaWlC/BSs9NtDNdJWN9kJkrA243OWaD19Vdcyp7WJatiKKwBcWIPBEnp8C+t?=
 =?us-ascii?Q?AlJDsv3u/e2YP6PQx1BpgoXsEpreCBmBd6Z5AEZWKRO/Lck+Tyxl1HBCaADs?=
 =?us-ascii?Q?tViSQPGgzM+tQRU/5+LE4AOGstnBOmtSA3WaKBMi1BCUpneP0zd3n70H2zdo?=
 =?us-ascii?Q?OLx/QkbX9ZvDVHPEdZSn3Ohwfqw+BSzER7loRTVHc6iBWILDVMP6jEoLALKO?=
 =?us-ascii?Q?dHoOkeok/rFQEauc7yGKPpS8KesxE4cTO+t4Ry7Gs1UVps6OCB5D7TrCme6b?=
 =?us-ascii?Q?Ima04n4WPtk0fz8NUI0POwbH9+F/KtCu466YYWhbCqBhoFDqdFMVQrfFMf4z?=
 =?us-ascii?Q?PBxW082fWnHWoezL4cxb5qKCnv6xQHdJqZZagzMFMSyvBSnFfskVaUsTPJPV?=
 =?us-ascii?Q?nzueL2bxioirMA0QLngsmauooPv5UYbaJhRInCrcMzyDVwSXo3GNuF70z3t2?=
 =?us-ascii?Q?yLFu2Y35SIGSrWXTee/C8d+ZF7TJ8KdFZxwIH9DfmMakc8+HPDX469DC1N+c?=
 =?us-ascii?Q?ALMN8Vy9EpfRXEAUQnHPzybsaNXulEQAHJ7fCcMDnOBueXmKfcpAUEKh2Djo?=
 =?us-ascii?Q?Xd40DepLaAWIik2AXPizTlSwukfiniXsnS5hzlZBzoyNZkYhHuHt+M0gDBus?=
 =?us-ascii?Q?D0vbXH/oTFlSLoc0bHgilTvWbNuPCOTEDpXvwLat+89rYV5rP3vqYiCzCASz?=
 =?us-ascii?Q?QGseQGQSJaep4x7/RML99kIvb2VoVKegNeKNJFSs7J54huZQHDVt0Ai5MZfO?=
 =?us-ascii?Q?j8rRuSfw536IHN9C59kicirSUSWOKCn8sGfKvtuE72LDT856aaV/P8b/RLcV?=
 =?us-ascii?Q?Z4Hi+/4ETGk/WkbrslV4q3YF1xrSA1+VUGmI9sz/HiRdrcVC5aNWmN/mbcwC?=
 =?us-ascii?Q?QKTyshkzFjL9xMSgCREhzPh9YF6wb5ws6B4g4FatWBILAA7x3DrRQz3mvY3z?=
 =?us-ascii?Q?d1LavHXZbj13nMTDj52OAG+FH27m/YJTCiHLUZly0J/GAQAAEZ3vwaNn4iXh?=
 =?us-ascii?Q?huCnguaryvvK30JeND0hq/Z1o0PRirWS2PB3RpV1A00FcN9XTnMGnVtshzX/?=
 =?us-ascii?Q?egbu/O3gtGKLgPaiUAg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: e003afa4-1843-47ba-92a7-08dc7062622a
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 19:58:23.5549
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9kKooe0NYIvR11opiVVWrBviKoCnSk8rEpd6YflkoJ1gj4kU8jyHL2A1rReDWtOO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR84MB3953
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: vYbLnB7HWL0B0yEdBiO63YO_z82gzC4q
X-Proofpoint-ORIG-GUID: vYbLnB7HWL0B0yEdBiO63YO_z82gzC4q
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-09_11,2024-05-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0
 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1011
 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405090140


> -----Original Message-----
> From: Sergey Portnoy <sergey.portnoy@intel.com>
> Sent: Thursday, May 9, 2024 6:36 AM
> To: herbert@gondor.apana.org.au
> Cc: linux-crypto@vger.kernel.org; qat-linux@intel.com
> Subject: [PATCH] crypto: tcrypt - add skcipher speed for given alg
>=20
> Allow to run skcipher speed for given algorithm.
> Two separate cases are added to cover ENCRYPT and DECRYPT
> directions.
>=20
> Example:
>    modprobe tcrypt mode=3D611 alg=3D"qat_aes_xts" klen=3D32
>=20
> If succeed, the performance numbers will be printed in dmesg:
>    testing speed of multibuffer qat_aes_xts (qat_aes_xts) encryption
>    test 0 (256 bit key, 16 byte blocks): 1 operation in 14596 cycles (16
> bytes)
>    ...
>    test 6 (256 bit key, 4096 byte blocks): 1 operation in 8053 cycles
> (4096 bytes)
>=20
> Signed-off-by: Sergey Portnoy <sergey.portnoy@intel.com>
> ---
>  crypto/tcrypt.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> index 8aea416f6480..73bea38c8112 100644
> --- a/crypto/tcrypt.c
> +++ b/crypto/tcrypt.c
> @@ -68,6 +68,7 @@ static int mode;
>  static u32 num_mb =3D 8;
>  static unsigned int klen;
>  static char *tvmem[TVMEMSIZE];
> +static char speed_template[2];

u8 would better match the source:
    static unsigned int klen;
    module_param(klen, uint, 0);
    MODULE_PARM_DESC(klen, "Key length (defaults to 0)");

and use as the keysize argument in:
    static void test_mb_skcipher_speed(const char *algo, int enc, int secs,
                                   struct cipher_speed_template *template,
                                   unsigned int tcount, u8 *keysize, u32 nu=
m_mb)

and the other constant speed test arrays like:
    static u8 speed_template_8[] =3D {8, 0};
    static u8 speed_template_16[] =3D {16, 0};
    static u8 speed_template_24[] =3D {24, 0};

...
> +	case 611:
> +		speed_template[0] =3D klen;
> +		if (alg)
> +			test_mb_skcipher_speed(alg, ENCRYPT, sec, NULL, 0,
> +					       speed_template, num_mb);
> +		break;
> +	case 612:
> +		speed_template[0] =3D klen;
> +		if (alg)
> +			test_mb_skcipher_speed(alg, DECRYPT, sec, NULL, 0,
> +					       speed_template, num_mb);
> +		break;

Since it's only two bytes, perhaps it should just be an on-stack variable
inside each of those if blocks, not a file-scope variable.