Received-SPF: pass (google.com: domain of linux-crypto+bounces-4111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240508103118.23345-1-kabel@kernel.org> <20240508103118.23345-8-kabel@kernel.org>
 <Zjti-FkUCAQzMmrQ@smile.fi.intel.com> <20240509205729.09728cbb@thinkpad>
In-Reply-To: <20240509205729.09728cbb@thinkpad>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 10 May 2024 16:19:57 +0300
Message-ID: <CAHp75VeW8P2S4i62NhcpwZ=tbpNfBtanz_1zXzBh2H2PCbHLUg@mail.gmail.com>
Subject: Re: [PATCH v9 7/9] platform: cznic: turris-omnia-mcu: Add support for
 digital message signing via debugfs
To: =?UTF-8?B?TWFyZWsgQmVow7pu?= <kabel@kernel.org>
Cc: Andy Shevchenko <andy@kernel.org>, Gregory CLEMENT <gregory.clement@bootlin.com>, 
	Arnd Bergmann <arnd@arndb.de>, soc@kernel.org, arm@kernel.org, 
	Hans de Goede <hdegoede@redhat.com>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, 
	Dan Carpenter <dan.carpenter@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 9, 2024 at 9:57=E2=80=AFPM Marek Beh=C3=BAn <kabel@kernel.org> =
wrote:
> On Wed, 8 May 2024 14:33:12 +0300
> Andy Shevchenko <andy@kernel.org> wrote:
> > On Wed, May 08, 2024 at 12:31:16PM +0200, Marek Beh=C3=BAn wrote:


...

> > > +#define OMNIA_MCU_CRYPTO_PUBLIC_KEY_LEN    33
> >
> > 33? Hmm... does it mean (32 + 1)?
>
> Rather (1 + 32), the first byte is 0x02 or 0x03, determining whether
> the y coordinate of the public key elliptic curve point is positive or
> negative, and the rest 32 bytes are the x coordinate.

I hope you used that in v10, i.e.  (1 + 32) with a summary of the
above in the comment.

--=20
With Best Regards,
Andy Shevchenko