Received-SPF: pass (google.com: domain of linux-crypto+bounces-4146-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Pankaj Gupta <pankaj.gupta@nxp.com>
To: Gaurav Jain <gaurav.jain@nxp.com>, Horia Geanta <horia.geanta@nxp.com>,
	Varun Sethi <V.Sethi@nxp.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, "davem@davemloft.net" <davem@davemloft.net>,
	Iuliana Prodan <iuliana.prodan@nxp.com>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
Thread-Topic: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
Thread-Index: AQHaj7/jd4TDxURXIUidF1KPvahm+7GU2IkA
Date: Mon, 13 May 2024 06:09:49 +0000
Message-ID:
 <AM9PR04MB86046A94F0CF06AFFE5DE3B895E22@AM9PR04MB8604.eurprd04.prod.outlook.com>
References: <20240416053303.421259-1-pankaj.gupta@nxp.com>
 <20240416053303.421259-2-pankaj.gupta@nxp.com>
In-Reply-To: <20240416053303.421259-2-pankaj.gupta@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ER5QDCX2Pz1gDXRomwoBchqU938BPIeZL7xFRMK03knOE7t2mLIaZoA6XzyI?=
 =?us-ascii?Q?+5XCZXxQD5xQ6ZjovqBR/8cYoYqGT57k0xQqYsOzuU7SoEQ12KCMZ49jRKEv?=
 =?us-ascii?Q?tP2ielXh6PDCy9AHa+t32kB982n1Xop//SJ76s9wSefrDTV7YtW+slXxqY1Z?=
 =?us-ascii?Q?XzK+XqvVgIIO8geh4/tjXuPHKhvJAHwjzGKEOroZW/V+xbg3MVY75DDveEO1?=
 =?us-ascii?Q?DXDel5fPjfBYeMI8xvuxDqIMBBDQkFBIFtnTNnTV31KZNrGJKsblZvuPtlDj?=
 =?us-ascii?Q?JEC0uegcOpgQyKVnbMjCCHQiirCdXucPdUy6VF8RnG6DyWDXiWZec+Qwg1i0?=
 =?us-ascii?Q?Y3WOfbvAzzN3Gub5kl8rF4GqTRB3lJZqyqnLsGcsapjqXehO88p8TF3SuEz8?=
 =?us-ascii?Q?f0+KQ2PzBfk4GxiEGqq8hVnaO/U1U30EDk+PMPmRYVN7kwUbUJFNB87+yoIC?=
 =?us-ascii?Q?spoKw5SXFOV6xw34FLqNUzkVnasdjXB244JBTLjoEvEUITLxUkyFMntGrNze?=
 =?us-ascii?Q?tVyv1k/KH6vjZKLGt5v//XrDaB3QQtBwKwb7nuCao1SipGlXE1E/Fsb8t6MT?=
 =?us-ascii?Q?i7w9lvwycJOutCf7F7poVp8RHDBFCcS+HCizaiwC52y8tM+XLTOKl9yqAVPF?=
 =?us-ascii?Q?vChSP7iLN4Aj7LX3p+mNxBoJrb3r1jqTbzB9lhqYgLahY7cEyCnC+YbB/hAT?=
 =?us-ascii?Q?IUMriczl0T4GJuT1r3rQ9nxtbNRDNh91ZnUIPxBwSjuSpBEXkO9M/a2sazR3?=
 =?us-ascii?Q?ruEN0RfJSxA+Lk4l0jnq6HS85e9ydLS8ElD4EgtBNJhUqj+QJvKQdMmhDQEk?=
 =?us-ascii?Q?NfrR6SXN5UzE2BhqI/ThOVQDUBuhOyiRweXD51zPs0+n+sTRY+kAru6ZfTFt?=
 =?us-ascii?Q?yNw4QAFdZyBVCkDCyVhMZEpgvca+qT8q9ENhMDSDKbBCGAFFLO92IsTxRUC1?=
 =?us-ascii?Q?Ury7Xi0Wf5oLdeWHud2tZwOnwYE6Tr79TVL4p29tOIVBJvdjxwA37QNAvReu?=
 =?us-ascii?Q?j1rywXagGhss2WBu6HwBdr8quiO+0sP0b+Sd0WViGCDSQytp5atd9iE3D7QU?=
 =?us-ascii?Q?P1C3tIw7zN73SlwfaHIyi1Mht7vwMl/bavMADN31/IFsIdkVzg+oZOrl9DTH?=
 =?us-ascii?Q?oadFPJ6jhqO3Y9GSsTw9K+C463ps+jTEE46qp5iZ27UfIr5Cf4SwtNzvXQ1T?=
 =?us-ascii?Q?KkVE8Z4dewD/MU/TFDcLHqlMEE550J2qFvzwwqYbq2nTuiMo6oUVJyb0unG0?=
 =?us-ascii?Q?CsW+MA4fpeK6ZtgcOQ0KBGQu570TIdoAv9dFHmFrL/y8pGZNheEnRqAvaA4H?=
 =?us-ascii?Q?xZoMOLu2oh9LI2zTOK4/agHR5+JGbRV+UDrk3gmNnviPVbyPaK4FALe14VHz?=
 =?us-ascii?Q?/WXmXx2NAGOtc1ubN4cYeStoZrI2GVdlUupoXHLpMRE5WTiCdE+2zJFIF6hv?=
 =?us-ascii?Q?1DQAXUxBf4/ZAqFZmCKup/WkoiMr7IIEnT6a8xxsOsbZTPBrYJ6VQkrcmMjM?=
 =?us-ascii?Q?HIFDnbV1dtupDlwodcq14kw6CwkzzjLoN+EKawbzDiIaDzGPt957CMLBn5t7?=
 =?us-ascii?Q?0KELM8ODc8S15bAElU7tnDNo628IzvntwttO56PF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10acd133-89b9-4f08-63ef-08dc73134c29
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 06:09:49.9036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: js1bhQRG7uY3zWyIW3LEIP6i02K8L0eOV2jYPKY/1FLBlu6l4DRsGz9Rx3qmjcXA1a7Zl85bfqEG9kGKa7GicA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9568

If there are no further comments, request Herbert to merge the patch-set.

Regards
Pankaj


> -----Original Message-----
> From: Pankaj Gupta
> Sent: Tuesday, April 16, 2024 11:05 AM
> To: Gaurav Jain <gaurav.jain@nxp.com>; Horia Geanta
> <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
> herbert@gondor.apana.org.au; davem@davemloft.net; Iuliana Prodan
> <iuliana.prodan@nxp.com>; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Cc: Pankaj Gupta <pankaj.gupta@nxp.com>
> Subject: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
>=20
> CAAM clock initializat is done based on the basis of soc specific info st=
ored in
> struct caam_imx_data:
> - caam-page0-access flag
> - num_clks
>=20
> CAAM driver needs to be aware of access rights to CAAM control page i.e.,
> page0, to do things differently.
>=20
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> ---
>  drivers/crypto/caam/ctrl.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c inde=
x
> bdf367f3f679..247d42aa32df 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -512,6 +512,7 @@ static const struct of_device_id caam_match[] =3D
> {  MODULE_DEVICE_TABLE(of, caam_match);
>=20
>  struct caam_imx_data {
> +	bool page0_access;
>  	const struct clk_bulk_data *clks;
>  	int num_clks;
>  };
> @@ -524,6 +525,7 @@ static const struct clk_bulk_data caam_imx6_clks[] =
=3D
> {  };
>=20
>  static const struct caam_imx_data caam_imx6_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx6_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx6_clks),  }; @@ -534,6 +536,7 @@
> static const struct clk_bulk_data caam_imx7_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_imx7_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx7_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx7_clks),  }; @@ -545,6 +548,7 @@
> static const struct clk_bulk_data caam_imx6ul_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_imx6ul_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_imx6ul_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_imx6ul_clks),  }; @@ -554,6 +558,7
> @@ static const struct clk_bulk_data caam_vf610_clks[] =3D {  };
>=20
>  static const struct caam_imx_data caam_vf610_data =3D {
> +	.page0_access =3D true,
>  	.clks =3D caam_vf610_clks,
>  	.num_clks =3D ARRAY_SIZE(caam_vf610_clks),  }; @@ -860,6 +865,7
> @@ static int caam_probe(struct platform_device *pdev)
>  	int pg_size;
>  	int BLOCK_OFFSET =3D 0;
>  	bool reg_access =3D true;
> +	const struct caam_imx_data *imx_soc_data;
>=20
>  	ctrlpriv =3D devm_kzalloc(&pdev->dev, sizeof(*ctrlpriv), GFP_KERNEL);
>  	if (!ctrlpriv)
> @@ -889,17 +895,25 @@ static int caam_probe(struct platform_device
> *pdev)
>=20
>  		reg_access =3D !ctrlpriv->optee_en;
>=20
> -		if (!imx_soc_match->data) {
> +		if (imx_soc_match->data) {
>  			dev_err(dev, "No clock data provided for i.MX SoC");
>  			return -EINVAL;
>  		}
>=20
> +		imx_soc_data =3D imx_soc_match->data;
> +		reg_access =3D reg_access && imx_soc_data->page0_access;
> +		/*
> +		 * CAAM clocks cannot be controlled from kernel.
> +		 */
> +		if (!imx_soc_data->num_clks)
> +			goto iomap_ctrl;
> +
>  		ret =3D init_clocks(dev, imx_soc_match->data);
>  		if (ret)
>  			return ret;
>  	}
>=20
> -
> +iomap_ctrl:
>  	/* Get configuration properties from device tree */
>  	/* First, get register page */
>  	ctrl =3D devm_of_iomap(dev, nprop, 0, NULL);
> --
> 2.34.1