Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2283646lqo; Mon, 13 May 2024 13:26:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWASrbH0jjRDYXNICVCWgpf0EZfmrcY9S1j17iI/mMHk7DeyPt+OPWgshJBreaykfP7DtzM09p1h377/PF04S9FVJWJ7+umuVz5FaXlGg== X-Google-Smtp-Source: AGHT+IFfM/VFXjKeyNXC2hi2j7IZ2GOi2GHJoh+rcUbs2igIB+jrCqbo0ooYutBlbCGWktCgC5Mn X-Received: by 2002:a17:903:1cd:b0:1ee:8fb7:dce9 with SMTP id d9443c01a7336-1ef43d18246mr131182085ad.15.1715632000272; Mon, 13 May 2024 13:26:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715632000; cv=pass; d=google.com; s=arc-20160816; b=0DO76/KQtJAUpXPhXQMEmN3tJtChD/CpaJ/5ptrISQD1yF2BkBFFupySbj0AjCHXDa alYynHQO1UaqGBkJEFiYR0MaIYvBthMSCW5HoszJ0EG0gYzXgN2SEFf3X36/MumCYm2k 6+AAlid3x8k0s3JROruyTAOXS8kTF23yYpr3fUAUZEJZsem6GcqiSewD8DHN/Ps8xBUF nWqJYBRjklv6fDNCp626ggTwcPlKHrWXSSsQONniPHQ5AJvb2+GdB4eAcIwwXXwzqqTX maTSVqrRGN59rm8aoVvkRsGtHQs02oEBYVcB4SOyRTvcs+6pCOM14Q/C4YEqiVlU2Psj CSCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=/+6c4SphXgAhCDVj7IPp4hIgsyOpK77biFL8MV/1kdo=; fh=G0Ci2vMcUd2EaZUwxneVlJUmjsx/bKBEVejgu1tXWG0=; b=hg4mMGTIPi6i8zylV6LtHEAFHk7+BrNfoz1JLSoqNlnbCKn3EB3rbLzegN9JC8G9yM JB/PL5qPayDymznlqh2Lku9FwAaZyJeMgr2Cgcut63c1kEp8QWVffJfoDukSMNAzw89k IUPIko3rJBuyRJjrhmt6sek3s1pn9Bias8qdqvOiQ4TLBhR21tAGdN5TuDlPZwuVD+lX IDEYiunil+wh/mgZcORSvSj6V6bE4MWdW5UG/seQ+jsf4ihhEb83IxBQmpV2Z/GsPHrg ZwZV4yL9JaaSlKVzmDq+oAuH6CR466R+/xFN9uWBERRekbZHLTJGE+4hgPywD/d3E+il yCsg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XEtil62+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-4148-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0bf32e6bsi100858125ad.228.2024.05.13.13.26.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 13:26:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-4148-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XEtil62+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-4148-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6269F281124 for ; Mon, 13 May 2024 20:26:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A18ED7E567; Mon, 13 May 2024 20:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XEtil62+" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616817AE5D for ; Mon, 13 May 2024 20:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715631996; cv=none; b=rndkZfBXL5q0r8s/uF6vGwk5zhSseP8nsdih+v6xD4fLOQuiFhmHXLDTeIp1gxFDkPcJbxP4GJmfGaPxZJKj4sPYMQLU8z/Ztg6DDggsvaGmyxFGJyd6YJRpH1NToxyt8erh2j7dRANIfbu72PrtTe3uR8qo8hBTykBuJJrmuWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715631996; c=relaxed/simple; bh=cNGeaflSmAEnCGZR1rkFunly5KPHgcR29cpK6hQnl4U=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=uI1u32fmbbX79bOFFWYLoZdkn3MnNKsJ6cBiUL/caTY1mpt0+OJWBvQyEarQRoCCrxTZoLcp0YdijePLnN9TAX5MgIR/AiNZBWwOofNydgOQVHL5OOM22EFoSQZS18TVF/bmT2mfgyaYiBwfXjD1VWHLhRo8J5ho6tRXUiMJsYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XEtil62+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F14FC113CC; Mon, 13 May 2024 20:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715631995; bh=cNGeaflSmAEnCGZR1rkFunly5KPHgcR29cpK6hQnl4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XEtil62+umRIZkQUA/SkzEcVMjG/WI/LL4rM5jEX1EsYP0y0DARc32sVZxriVgQ2F EY1Jrq4VOH1IanEZDrUziZUw+nuKgs1lY6ip3VdIqLVnKYjaP2SAtpgfdCBOgiS4Fp x0KNUIjrjvZi9zgsmUp3niRTedtrSlQXep/q1oOxdDwL+AU0KT0rMUZD6Hw0zrJFM/ ShJ8XfblfJEKYZ+7M+dPQNKFpho5y2vxwwY/2lQ7h3shf0NNrbKOU+8IPCKpeiSzlR B5U3xy/i8N9FUS5zyPicsxvG3XxTEQGXCOeUg+6cXKbLzcwGK+XILPJ1bcpDUxTY4e 2ZiEegwtsekkQ== Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 May 2024 23:26:32 +0300 Message-Id: From: "Jarkko Sakkinen" To: "Joachim Vandersmissen" , , "Herbert Xu" Cc: "David Howells" , "Simo Sorce" , "Stephan Mueller" Subject: Re: [PATCH v5 1/2] certs: Move RSA self-test data to separate file X-Mailer: aerc 0.17.0 References: <20240513045507.25615-1-git@jvdsn.com> In-Reply-To: <20240513045507.25615-1-git@jvdsn.com> On Mon May 13, 2024 at 7:55 AM EEST, Joachim Vandersmissen wrote: > + pkcs7 =3D pkcs7_parse_message(sig, sig_len); > + if (IS_ERR(pkcs7)) > + panic("Certs %s selftest: pkcs7_parse_message() =3D %d\n", name, ret); Off-topic: wondering if Linux had similar helpers for PKCS#1 padding (and if not, are they difficult to add)? Anyway, looks good to me: Reviewed-by: Jarkko Sakkinen BR, Jarkko