Received-SPF: pass (google.com: domain of linux-crypto+bounces-4156-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d65279ed-20cb-4e23-866c-43b6291f51e2@jvdsn.com>
Date: Mon, 13 May 2024 21:36:55 -0500
Precedence: bulk
MIME-Version: 1.0
From: Joachim Vandersmissen <git@jvdsn.com>
Subject: Re: [PATCH v5 1/2] certs: Move RSA self-test data to separate file
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
 Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org,
 Simo Sorce <simo@redhat.com>, Stephan Mueller <smueller@chronox.de>
References: <20240513045507.25615-1-git@jvdsn.com>
 <D18SS8X9VV7L.28F9PNZ1PM96L@kernel.org>
Content-Language: en-US
In-Reply-To: <D18SS8X9VV7L.28F9PNZ1PM96L@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/13/24 3:26 PM, Jarkko Sakkinen wrote:
> On Mon May 13, 2024 at 7:55 AM EEST, Joachim Vandersmissen wrote:
>> +	pkcs7 = pkcs7_parse_message(sig, sig_len);
>> +	if (IS_ERR(pkcs7))
>> +		panic("Certs %s selftest: pkcs7_parse_message() = %d\n", name, ret);
> Off-topic: wondering if Linux had similar helpers for PKCS#1 padding
> (and if not, are they difficult to add)?
PKCS#7 here refers to the message container format, rather than the 
padding. Internally, the PKCS#1 v1.5 padding scheme will be used (see 
software_key_determine_akcipher). Unless you are referring to PSS 
padding (also defined in PKCS#1)?
>
> Anyway, looks good to me:
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> BR, Jarkko