Received-SPF: pass (google.com: domain of linux-crypto+bounces-4192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240426042544.3545690-1-pavitrakumarm@vayavyalabs.com>
 <20240426042544.3545690-4-pavitrakumarm@vayavyalabs.com> <ZjS8fQE5No1rDygF@gondor.apana.org.au>
 <CALxtO0m2wC3=yP5zE3_2nboVBVRVuhwuHx9Pdfj25wynky3E-A@mail.gmail.com> <Zj3Ut7ToXihFEDip@gondor.apana.org.au>
In-Reply-To: <Zj3Ut7ToXihFEDip@gondor.apana.org.au>
From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
Date: Thu, 16 May 2024 08:41:57 +0530
Message-ID: <CALxtO0myn63AwPh4vck7fpuJcttPJYLBM3TpsyBAexCMSa4GcQ@mail.gmail.com>
Subject: Re: [PATCH v3 3/7] Add SPAcc ahash support
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Ruud.Derwig@synopsys.com, 
	manjunath.hadli@vayavyalabs.com, bhoomikak@vayavyalabs.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Herbert,
   The SPAcc crypto accelerator has the below design

   1. The SPAcc does not allow us to read internal context (including
the intermediate hash).
       The hardware context is inaccessible for security reasons.
   2. SPAcc has multiple hardware contexts and every request uses a hardwar=
e
       context that's obtained using 'spacc_open' and released with
'spacc_close'.

  The export/import is supposed to save the intermediate hash and
since SPAcc hardware
  does not provide that, I was using it to save my driver state. This
is redundant and I tested
  the same by removing it from export/import. An empty import/export
function is what I
  have in the latest driver code and that works for me.

  Appreciate your inputs.

Warm regards,
PK


On Fri, May 10, 2024 at 1:33=E2=80=AFPM Herbert Xu <herbert@gondor.apana.or=
g.au> wrote:
>
> On Tue, May 07, 2024 at 09:49:57AM +0530, Pavitrakumar Managutte wrote:
> >
> > About the export function, yes its hash state that's present inside
> > "spacc_crypto_ctx".
>
> Please show me exactly where the partial hash state is stored in the
> request context because I couldn't find the spot.  It can't be in
> spacc_crypto_ctx as that is the tfm context and shared by multiple
> reqeusts.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt