Received-SPF: pass (google.com: domain of linux-crypto+bounces-4281-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 21 May 2024 03:37:33 +0300
Message-Id: <D1EWI92F6AIH.3CFED3IMI10ZA@kernel.org>
Cc: <linux-integrity@vger.kernel.org>, <keyrings@vger.kernel.org>,
 <Andreas.Fuchs@infineon.com>, "James Prestwood" <prestwoj@gmail.com>,
 "David Woodhouse" <dwmw2@infradead.org>, "David S. Miller"
 <davem@davemloft.net>, "open list:CRYPTO API"
 <linux-crypto@vger.kernel.org>, "open list" <linux-kernel@vger.kernel.org>,
 "Eric Biggers" <ebiggers@kernel.org>
Subject: Re: [PATCH 0/6] KEYS: asymmetric: tpm2_key_rsa
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>, "Herbert Xu"
 <herbert@gondor.apana.org.au>
References: <20240520184727.22038-1-jarkko@kernel.org>
 <D1ERDC16XLUO.578U4ZE7VXW@kernel.org>
In-Reply-To: <D1ERDC16XLUO.578U4ZE7VXW@kernel.org>

On Mon May 20, 2024 at 11:36 PM EEST, Jarkko Sakkinen wrote:
> On Mon May 20, 2024 at 9:47 PM EEST, Jarkko Sakkinen wrote:
> > ## Overview
> >
> > Introduce tpm2_key_rsa implementing asymmetric TPM RSA key. This key ty=
pe
> > can be enabled with CONFIG_ASYMMETRIC_TPM2_KEY_RSA_SUBTYPE config optio=
n.
> > Carves groundwork for similar modules in future, such as tpm2_key_ecdsa=
.
>
> Cc to Eric (forgot).

Also my idea is to take the (working) model from tpm_tis. At this point
it is just tpm2_key_rsa but it would be easy to lay out tpm2_key later
on and make the different key types as submodules. That would be a kind
of model, which would support algorithmic agility side of TPM2.

So there might tpm2_key at some point with tpm2_key_rsa and tpm2_key_ecdsa=
=20
as its submodules.

BR, Jarkko