Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp869910lqb; Fri, 24 May 2024 17:07:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXtrrLjDw3++bnzSRhcBxK74OctbJ3DGRyTfXiYgD8WhXfuIuCpZkW5CL6/bWVxi8m0BYJIUoRz6NyJYRd0BN/uq18wWVBLPPlYfg0I+Q== X-Google-Smtp-Source: AGHT+IELxw35jABXUSxlvbscoMYyks3X/lPQWOo0JV7HYNXZDph3wfD2Ojz1y21MXJYNYNglZFN6 X-Received: by 2002:a17:906:3014:b0:a59:9ef3:f6df with SMTP id a640c23a62f3a-a62642e9af5mr217231766b.22.1716595641817; Fri, 24 May 2024 17:07:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716595641; cv=pass; d=google.com; s=arc-20160816; b=g39kIQoQudYkwnrYPw3NbBlMMp4kumjbNzkl8clxYdcMlcARvwt1vPe7B2AS7HpiaU QHsJl3RnwrJcBVBvCYtegjwSIQ3Ky/pIBWv4nV4YBOMm4UaTeAv8ogaBmvu2uHQkyldb E880amddJea5bN/fyd2hmeZwdLctuUbsB1KcXWTDFFn5SxK1sbagAkRV8RPm77DkmYIp mjivlH6DEA7XE48M4gTW88hCGZpOsh71eluOoH2V3uzxUhlMEPdfEDLqDq9bZuQvWJ5+ ErPjXj7+NvHlw6VBNAMHmDhCDaCcwAz4aNwqUGQbjeqgxKKRRq3jSrQB/57Eh4EYZbKl RZDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=/NsSx95Bs+fPVa9db7gdA+rBRPf+SHgkqbU0mYfNc8I=; fh=JTA2lkmoZsT/uiDYtCSCSadw3DchEaP9zZNTJXoyEjs=; b=h/csnoZE2Wfu3J4ghl0SUpX5ivesFhfdngBuaPJLZtSWANIA1DV5g2O9wO/69IlpaG cGqaCET4DGFqwx6qvgHGKHoHiREwbckWq+FG+HFqcelhfJU6LreIj6s84ge+bfCQK3a6 CVX4lZCstrUq/G2IK2kUiI05+rXJgodK9fPsl0UoBcAMZ4bxPbO1xv7KXYL00He/1SlT 1t5yn3+p4PcpGQHRo+xfBqPOyoSVhu3md2Ness+wk07IYxhrifJHR38oejgtONcFoEBZ 7lhjE/9BKfvrs3Z1TrLtZGyWsUUpO6TISb53fB4AqIoodG/HWXaYcTWCHrdBWrR/cXUq Y5qg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@treblig.org header.s=bytemarkmx header.b=ikRgGvRx; arc=pass (i=1 spf=pass spfdomain=treblig.org dkim=pass dkdomain=treblig.org dmarc=pass fromdomain=treblig.org); spf=pass (google.com: domain of linux-crypto+bounces-4384-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4384-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=treblig.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a626cd927f9si127627866b.782.2024.05.24.17.07.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 17:07:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto+bounces-4384-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@treblig.org header.s=bytemarkmx header.b=ikRgGvRx; arc=pass (i=1 spf=pass spfdomain=treblig.org dkim=pass dkdomain=treblig.org dmarc=pass fromdomain=treblig.org); spf=pass (google.com: domain of linux-crypto+bounces-4384-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-4384-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=treblig.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 83D941F23BF8 for ; Sat, 25 May 2024 00:07:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F17F919E; Sat, 25 May 2024 00:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="ikRgGvRx" X-Original-To: linux-crypto@vger.kernel.org Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 703D120ED; Sat, 25 May 2024 00:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716595635; cv=none; b=t5aHbaMj4hE5OQk8sh+n1kKarFg2HTnzJFGKumNwO0ICzfpHG/10sIO3ENTDS4yCbEFNOPFjl0IjDM7EyCpc0uz4LTgNhZfbAfMzhwSO1N7rO6r7sY2x+XvK+mQIioa/NSfkdQRAaGq8YPF668gy/TaMq3hwJOcTTtqiIp0kUNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716595635; c=relaxed/simple; bh=i7c0xrLGjRLjOfnTFWEM02by6TC1LzF474GBRQlEAfo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fgQKn+fyKyK7qMtd8AdlAjesLud+0qi1ta+RCb2W0Nw2DkZlSA1TRFhnsKkRhvX3oNX/yLWVz7eQd1qI85NgU0fpCVuYrdDtepkOki23diPgehTtyXwnvgftkwRpaUMFq4+1SHt21aeExDZ4lv/l86uLBPbBiMIsTio3O9JB+5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=ikRgGvRx; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=/NsSx95Bs+fPVa9db7gdA+rBRPf+SHgkqbU0mYfNc8I=; b=ikRgGvRxX3EObEiL DJLIw0GnFT3Lwt+m0cFJUPkYlODNCnFFBca+zg5BaERFdvTGCFd7q8FivLjU/TrqKAamlNFeLDfYn UZozYHUG0Ys7CYEw3mHM9M2pqpQO+9vhDm45GCBdWApG4I9zom+/uzSgeb+sEr4MKfm43lunxOMK2 ex0pbe0Xhx6sFwoTiE+FtkHGJoUEA5b0NNBIClHyQ7uc0KNHMdfquVri4VQPQvU0kfbdXYqPlylUb 30COAqHX8fJBV929SjTfxi/1oRfi7ea8w8JB4VfgspFJSl/Oe5jCxcJCocFqA8nP608eCDJXeqJK7 8ps75CgqTo6SMqQvcQ==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1sAewI-002TQU-25; Sat, 25 May 2024 00:07:10 +0000 Date: Sat, 25 May 2024 00:07:10 +0000 From: "Dr. David Alan Gilbert" To: gilad@benyossef.com, herbert@gondor.apana.org.au Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys' Message-ID: References: <20240511145200.226295-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20240511145200.226295-1-linux@treblig.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 00:06:36 up 16 days, 11:20, 1 user, load average: 0.00, 0.01, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) * linux@treblig.org (linux@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'tdes_keys' appears unused. > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Ping. > --- > drivers/crypto/ccree/cc_cipher.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c > index cd66a580e8b64..3fb667a17bbb1 100644 > --- a/drivers/crypto/ccree/cc_cipher.c > +++ b/drivers/crypto/ccree/cc_cipher.c > @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm) > kfree_sensitive(ctx_p->user.key); > } > > -struct tdes_keys { > - u8 key1[DES_KEY_SIZE]; > - u8 key2[DES_KEY_SIZE]; > - u8 key3[DES_KEY_SIZE]; > -}; > - > static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num) > { > switch (slot_num) { > -- > 2.45.0 > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/