Received-SPF: pass (google.com: domain of linux-crypto+bounces-4463-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <946a0fed-a3a0-8d67-8620-b58ce413cd12@amd.com>
Date: Tue, 28 May 2024 10:28:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: Mario Limonciello <mario.limonciello@amd.com>,
 Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@vger.kernel.org>, Richard Hughes <hughsient@gmail.com>,
 open list <linux-kernel@vger.kernel.org>
References: <20240527152649.3722-1-mario.limonciello@amd.com>
 <20240527152649.3722-5-mario.limonciello@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 4/5] crypto: ccp: Add support for getting security
 attributes on some older systems
In-Reply-To: <20240527152649.3722-5-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dmlPUGJMeE1PY3Z6K2MwcExZcmx3MDJkbW1TZitKSUpPS2J4eERaK0lXeUNQ?=
 =?utf-8?B?ZFB6eHNBZDNQMGJ3S2dBYlV1ZHI3MUpFWC9BSHdhNkpUa2FXdCtGTkRvOE5w?=
 =?utf-8?B?RUVPZTZVdERJNGM0TTVlRXpacXA2RmxrcXJJY1RKeG9sK2JYMmUzWGF2aWdp?=
 =?utf-8?B?Y2lzZ2tEQ09GcEJmRi9iMzdJdC9vZEo3T2pRbHlXSENOTzBBNVpmMnpIcEox?=
 =?utf-8?B?YzNBOWJOUFFXVjY0a2o0OHgvcE5RV1VsL2hScGZadlhiK0ZkWXZPb0J0M0Vi?=
 =?utf-8?B?YWhVVFBINmpGL0ZoSTZ0QVpxeWhyZllWbktUQnVxL0Yrb3hLU1ZrT3lJaXVq?=
 =?utf-8?B?MTNIclB4U1U3Zk01dmRWZnZRYk04UkxTYjczS3k0ODhRV3VHMTZld1hDdWdU?=
 =?utf-8?B?SVBReHVGMzBXWFhyc2hZZVoyZXFrK2pqM3lLdUNGVkVTWHQxeUdsNko3SU1V?=
 =?utf-8?B?U2ZaeHU2aDJJNTRhVUFhRlpsNzMrRDQ1a1UzVVhNbmJBclZzQnZDaTR5M3pz?=
 =?utf-8?B?VDBnSjhhaHRVVUNSUy9pZVZDUmhsWXhYZjFkTVlUSDA2TW5iOEVoM1FrMWth?=
 =?utf-8?B?QWVUUmdibG5IK0RUN3RveVRKQ3dFZS9JRHlSQUNUcDdaSXVsaWpROXBlT0pK?=
 =?utf-8?B?RXh2Yi9zaUl6SCtFM3BGNlo1SEpxajlTejJTMkRUV0xGcVhualVxLzN1REt1?=
 =?utf-8?B?Znp0R3RROFI3R0xmSXdDVEF2bW9uVnlBMTBNclVOcVZaV1pqcGZJQ0hIQUts?=
 =?utf-8?B?Z2IyY1ljQnZ0TjM1TmVUOVFnVDNsaVNCSWhFd2prOFpObFRvb0ZpK3UwcVZu?=
 =?utf-8?B?TUFtSjRrV051QUcxdVlabHRZVkszeGtFVmlRRkR1WXJ5UExBRGs0QjdPUTk1?=
 =?utf-8?B?SHdJN1ZKMjdZVDNUaGYvQ2tKUTZNbTZQMXYyZ0F2WHNHeXBhYWg2d2UxNDlG?=
 =?utf-8?B?NERXWXVKc2MxRW5ZNHhlWmdJSC9lSnhydk15SGJ4dXIrTFBLTHU1aGxCNXFI?=
 =?utf-8?B?Yi84TmNhcDkxMFdYWS9Mdm1GL09GRXY5WThjamhLT1FlUmNNaFlQK0hQUnho?=
 =?utf-8?B?VHl6YXhXTkNnT1RkdXg5SFRST25oZWVGNkRycUNxNHlSckVGblVkYnFZeWwx?=
 =?utf-8?B?MUVZUEw2NGc0VUk3T3JBYnozRUFINEFEcE1qQStGYnRrdjJ3Wk1icFhoVWZZ?=
 =?utf-8?B?UzY4elNJMDh4c0dIZldGb1RvNWxUa2NnU0gvODBnTnF0N1YzTjJlV1JzcTln?=
 =?utf-8?B?bVhWVGtkMHNFaDN1THIybUg5MzhjQnpqTllrUnlkb3U3WlhUakc1SVB4WVZU?=
 =?utf-8?B?WTFOUGhKQ1BXQTJYK2NEY2lHVzVFL1RBbkExOCtScU91d2duWlAwOFZWWENE?=
 =?utf-8?B?V0p1d3U5aUQ5Z0VxWXlSWXdRNUkybVA0OGFZOE94T2swQVUyd3BmY01DMWJL?=
 =?utf-8?B?TGZzOEFGWk4wdjMrWlhFQnMxeFJzckdoM0xqM01qaklaR0tMMWliMFJodUc2?=
 =?utf-8?B?VVl6OEh0dUQ3UFB6UDYzNWhBZjhKWkxzcXJaN1BvVzB0SXh3S1orRitBelBX?=
 =?utf-8?B?YjhLSXpxbElhekRHK1RLbHhRcURLUk9VSEM5MWpNTVZLdUR3eHY3aDF5cEpT?=
 =?utf-8?B?a1dBTGFOWHRqNkx0OVRkUis0M1lBVEpHOHZmTUtCZ25EbkRsemJISXhVQ0N3?=
 =?utf-8?B?YW94UDNCR1N1RUFqelZYYXdHcHQvMFRtZXRSREN3NEU2UmJkUlVHNFViMmFn?=
 =?utf-8?B?RGZTMWlOWDNDMU5XbFpVMUxwSUozYWFVS0Ixb3pvRzVrRnZuMmo5V2E3TFdu?=
 =?utf-8?B?QlZZelUwUGFvYkh3dmx0bEYxd1J2cGlSdjZTamlQNTY2OGdzNmNrRDhVWXJI?=
 =?utf-8?B?em9MOUV4aWtoWVgvajRtZ0NRMTdZRHRpQ0FlYk1aR2ZYdVlaOWpwTkdGd01N?=
 =?utf-8?B?cXF6NjJ6SklzYWJMcnF2YUFPNTBYNEJsM1ovN1Z2UldoZkxSdC83Y0NqU09F?=
 =?utf-8?B?ZDJmT3Y2ZzNPS2pvSnVKK3RUVjJzcXZiVHh3ZXN5SnFZUFlOQ2t0M1o1aUNl?=
 =?utf-8?B?TG1BRXVLOHZvOEdLc0ZsSUhEZDdMWS84ajEvZzFBOG1xeDNlSy8zNDl3OG9T?=
 =?utf-8?Q?q3Y4wfWaguXptyaBhdH6Y/L6e?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93a26e6e-8be3-437e-7a72-08dc7f2aca00
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 15:28:13.5779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X5jS012fcDX/aYBmKoO94soomyvwx2cte43waSp2GZL8vTySSAoAGsjOLe1rJ6oWxzAi6Gwh8sfqqI6HR55nfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6902

On 5/27/24 10:26, Mario Limonciello wrote:
> Older systems will not populate the security attributes in the
> capabilities register. The PSP on these systems, however, does have a
> command to get the security attributes. Use this command during ccp
> startup to populate the attributes if they're missing.
> 
> Closes: https://github.com/fwupd/fwupd/issues/5284
> Closes: https://github.com/fwupd/fwupd/issues/5675
> Closes: https://github.com/fwupd/fwupd/issues/6253
> Closes: https://github.com/fwupd/fwupd/issues/7280
> Closes: https://github.com/fwupd/fwupd/issues/6323
> Closes: https://github.com/fwupd/fwupd/discussions/5433
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/crypto/ccp/hsti.c           | 63 +++++++++++++++++++++++++++++
>   drivers/crypto/ccp/hsti.h           |  2 +
>   drivers/crypto/ccp/psp-dev.c        |  5 +++
>   drivers/crypto/ccp/psp-dev.h        |  2 -
>   drivers/crypto/ccp/sp-dev.h         |  1 +
>   drivers/crypto/ccp/sp-pci.c         |  5 ++-
>   include/linux/psp-platform-access.h |  1 +
>   7 files changed, 76 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/hsti.c b/drivers/crypto/ccp/hsti.c
> index 076c1d175b2b..8f583902d786 100644
> --- a/drivers/crypto/ccp/hsti.c
> +++ b/drivers/crypto/ccp/hsti.c

> +int psp_init_hsti(struct psp_device *psp)
> +{
> +	int ret;
> +
> +	if (PSP_FEATURE(psp, HSTI)) {
> +		ret = psp_poulate_hsti(psp);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	/*
> +	 * At this stage, if security information hasn't been populated by
> +	 * either the PSP or by the driver through the platform command,
> +	 * then there is nothing more to do.
> +	 */
> +	if (!psp->capability.security_reporting)
> +		return 0;

This should really be part of patch #5, since it doesn't make a lot of 
sense at this stage.

Thanks,
Tom

> +
> +	return 0;
> +}