Received-SPF: pass (google.com: domain of linux-crypto+bounces-4493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Akhil R <akhilrajeev@nvidia.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Herbert Xu
	<herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>,
	Thierry Reding <thierry.reding@gmail.com>, Jon Hunter <jonathanh@nvidia.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, Mikko Perttunen
	<mperttunen@nvidia.com>
Subject: RE: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Topic: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Index: AQHarrZLeawWiYOujkiA3zLjv6FXT7GtuQzg
Date: Wed, 29 May 2024 06:40:56 +0000
Message-ID:
 <SJ1PR12MB63391A3077F369FBF9BCB2D2C0F22@SJ1PR12MB6339.namprd12.prod.outlook.com>
References:
 <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr>
In-Reply-To:
 <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?rlLEmhA7cBasb3RL2dxT0/Ji6BW/iNu4SoAxlEwmlACfaGnHXtPxGuYYrdwm?=
 =?us-ascii?Q?KDvicmcGij+tYpuyT6/5lXLXfd7/z9SwAgF7kWiWuNZvLiltvErPFKS4xkDl?=
 =?us-ascii?Q?gNm3Cg+6x3IoaXYhJG54oNr43X120Au7fvIQ9acVDQwi5P56W33iuUX4vfzZ?=
 =?us-ascii?Q?BZR2HW5DYvA4KAMDz4jKhVUg96NVh+xTwnymXdL+nb0HmGFThlBnsAM9XP5y?=
 =?us-ascii?Q?vE5CKTkS0mVNlu6EjA7SZNWL9m/eIoTu0Zw2shkdOyA7VsuDjrkKaBv0L5Ht?=
 =?us-ascii?Q?znnXvLHncQePOdy2F+u0Ll5wnnI3I6tI5LUb1ahkFk/EU+uK2HrlpQ+8RP5E?=
 =?us-ascii?Q?kjQKRIGNDg+MS7nsn7BgRB/kJW1JeGw5UjOlqPFHv4jZknRi+rCybw8kt5w0?=
 =?us-ascii?Q?mLi6/UEKQuIYFgCIRvUMV9rDujFg2UQXO7TG/17TcdEMeorgdG7HZy+VY30E?=
 =?us-ascii?Q?9iJfXcoruU1RksAIXwjpRwBMLQY2mKrpc0d2lGw6TLDT79CFPSRPIDbDTQlv?=
 =?us-ascii?Q?RmPSyhAMXEAmflMZgvGQb0O7LEUTRuZBHT+WBq6A41ckT3T9qVD3f+jADucJ?=
 =?us-ascii?Q?lSBJSWm2lE0GDWqSThsdDkyjUKnXjRxy8JEJvBSAcgbNaS0sjyamKJue+gMg?=
 =?us-ascii?Q?F/hDil7c+uhMVl+siVXtyAPwNRK0RqaU2C6u1Oq314vI/nv1SB3jpPF/6Dax?=
 =?us-ascii?Q?y5UwuXePxhSRpYKFDvcRK12+CL0EejWgAEBoYk+qPs0ABv/SKAqrfjwgmaDt?=
 =?us-ascii?Q?2+hgPcWJkSH06Cbkm2kh7GiDyy7r4rODa7c7PUDKMQaQ8PLePJ2zlbf7sN6z?=
 =?us-ascii?Q?fCfEVlXF9+pxIoT2j7JeiHhhHxMaHn2zJqV4+zs3cJs1tajDYB9dUjrPg2ll?=
 =?us-ascii?Q?67YVqVNa8U5n4lMQgkmySkhFvlsA7cqHJzr9TJez7a/tLFm0b7LYilecU/VR?=
 =?us-ascii?Q?uTrLwmYLbLr6Vx0OfZrAyR6E7o+O1sr3pTl+0M+ITpQnGLfQhbQSmsouvZYB?=
 =?us-ascii?Q?YSQ/uH8BgKXqvA+yhe1GCiKkBsQagVKkuRHWjHWvcQYRJC3gSOu0BpFuFCVH?=
 =?us-ascii?Q?A0lDhPSYHv+Jp8Vll97e2MlUKWrAo9ydJlVcDz+LYtMss9imKrDTyOVLjJCN?=
 =?us-ascii?Q?v58/bT0whw3oV0ZmZzFVrgrKO3wHGetM9K5ZmNyw4BKxeBePhjBwDS0XSToL?=
 =?us-ascii?Q?ckhvmwc/h5soeM6v2iQmwS3spSXlv/piKVA+p/Af5xgandiLE5HYB875hmfk?=
 =?us-ascii?Q?WwUMcCVJADURuBDuL30YPN9uV9uGFjY912ux6oqFtJNbK1xow/+S9RHAgeaS?=
 =?us-ascii?Q?XlUXwFDOhc0Ax2mP1JAY61mkDBWN2xGu0G1+5vtyByD+kCx6syBnurJvzw73?=
 =?us-ascii?Q?Cl+04s7W1bM3+T5kDiPgt2ZewRSEDUrE106UXavio1eARA/mMlyDkPO9jusd?=
 =?us-ascii?Q?CpAwBeYW5iOdzS/mr5aHvTDJoYmyR0wTfqXZ2gP7b+2DF15Mth/zBCoK/S7g?=
 =?us-ascii?Q?6zO3tIEC2kmdc9tvN3miSDl0hNYUH6F+96b7eZ230JYg3WEqEC/U8RhFxxyY?=
 =?us-ascii?Q?zlFV5VVMiYXGlu4hOY2MsKP4uBG2wuBvDl7tXXjZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5bfaca1-b66b-435c-c641-08dc7faa4ba1
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 06:40:56.9682
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Su1QbDkZF/oFnL13mUXd8l0OHa/wZhHm+YVFjm6rHy3YoKZig/oJq0eR6LjgG8W/8K4zaoH8PgqvgPuRkTq5UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8465

>=20
> The only iommu function call in this driver is a
> tegra_dev_iommu_get_stream_id() which does not allocate anything and does
> not take any reference.
>=20
> More-over, what is freed is "se->dev" which has been devm_kzalloc()'ed in=
 the
> probe.
>=20
> So there is no point in calling iommu_fwspec_free() in the remove functio=
n.
>=20
> Remove this incorrect function call.
>=20
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
>=20
> This patch is completely speculative. *Review with care*.
> ---
>  drivers/crypto/tegra/tegra-se-main.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/crypto/tegra/tegra-se-main.c b/drivers/crypto/tegra/=
tegra-se-
> main.c
> index 9955874b3dc3..f94c0331b148 100644
> --- a/drivers/crypto/tegra/tegra-se-main.c
> +++ b/drivers/crypto/tegra/tegra-se-main.c
> @@ -326,7 +326,6 @@ static void tegra_se_remove(struct platform_device
> *pdev)
>=20
>         crypto_engine_stop(se->engine);
>         crypto_engine_exit(se->engine);
> -       iommu_fwspec_free(se->dev);
>         host1x_client_unregister(&se->client);
>  }
>=20

This was a futile attempt to fix a kmemleak warning in host1x_client_unregi=
ster() in a very old kernel.
I don't see it anymore, either with or without this change. So,

Tested-by: Akhil R <akhilrajeev@nvidia.com>
Acked-by: Akhil R <akhilrajeev@nvidia.com>

Regards,
Akhil