Received-SPF: pass (google.com: domain of linux-crypto+bounces-4494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Akhil R <akhilrajeev@nvidia.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Herbert Xu
	<herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>,
	Thierry Reding <thierry.reding@gmail.com>, Jon Hunter <jonathanh@nvidia.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Topic: [PATCH] crypto: tegra - Remove an incorrect iommu_fwspec_free()
 call in tegra_se_remove()
Thread-Index: AQHarrZLeawWiYOujkiA3zLjv6FXT7GtyrXA
Date: Wed, 29 May 2024 06:53:42 +0000
Message-ID:
 <SJ1PR12MB633943D654272A0612695F1DC0F22@SJ1PR12MB6339.namprd12.prod.outlook.com>
References:
 <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr>
In-Reply-To:
 <ea775b351a3dbe4cef4056ea89da25084f73df22.1716650050.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?UbzZyYCBOmWpkh9BcMUPVF/xss2iU10KKXObq8B9TCOKPrD2ktiZjL6oBIa2?=
 =?us-ascii?Q?yUSYGxBLM76Ixf0YHEhDVTqZzG9UuwioFOYiSAEpXN6xVF5HRTXL6tEI4GSz?=
 =?us-ascii?Q?qln9At0FuD0rCHGVudJOjhkQwQY9G7f6R2lZWuV1+oJ7LQfmgcOBAxLywHsx?=
 =?us-ascii?Q?JKYFXZFLjyGHrWk5gTvurAQgXVTaahA49XCfeiKCb2rzQjLVwSBV+L8G+RYY?=
 =?us-ascii?Q?RVIOmqAhgtuQdScp3fGB85HWCplyYIoT0/sJCYhE1LMtEIk3QzxFO0dlT8if?=
 =?us-ascii?Q?+4fEaZVv08JqBXejbE0z6sLC7Tzb7fYNpfF3rV8an4dN+gg+FeIAbt17nu3l?=
 =?us-ascii?Q?5eEQ/tBhWVMwilrHL8PJgyugB3FlIYm0Nj2F5l8bvR+j9HHYY0e96T935hkR?=
 =?us-ascii?Q?lX1k0mmIwoj3lKADSe9/9JPzJX4aIomOTDFFDixL+GCcdUDjFl5fi8qLZs9B?=
 =?us-ascii?Q?Ojy9vy69fH9ADFwM6UsVEJJB5ko1C5X4qCYy0kxQxuomKpF9JfGfJXhAmKS0?=
 =?us-ascii?Q?Z1c7y25PB8DEeklrnlpfWVJ/6FLGc4MiKnoECQsRcbcvdwGpv6ovPpYOQNsq?=
 =?us-ascii?Q?Yl6JD4hPlvrAaBha2gD/sod0BkIBJPIw6mozDL8kKGy34pQg6GfVVR0Spf9m?=
 =?us-ascii?Q?gh4HNSpW9D2LRuS5HPoF8Y4lOBOg1ZwU6eo5X8oaVUGktDylTYZQr0+ugi5P?=
 =?us-ascii?Q?E/MATmvIki9/FwtKVaMy0UFOODfVHp5JNX89UG2wkWCQK5YbZ+xF2FBGZGmp?=
 =?us-ascii?Q?dAV7Gn5NhoKnymK0TPngjpBVzzM5S+qbfvgFOwUvChnQXDJHMnO9qiFHF5An?=
 =?us-ascii?Q?4VHEhj8zLj9KKK4mTU8c0EFLyr99JYl51fY2DEZMfU5uw+9smagSTllRuL25?=
 =?us-ascii?Q?XHODfV0GNIVrr7JwaWWiFsOgedoeNZLqdvYZ+UO0RwzjiXQ4zB+v2scqxzJ/?=
 =?us-ascii?Q?dRq1H0M96dRHv66quH036AjUbft7O/gTbAh63xkVq1HoCD78VyDXs+KxmZzp?=
 =?us-ascii?Q?rgVcoRdoUl2YzIdM6LL/Vco9Wnodj52WA8JDIF7LqLOTfeqg/ezTXECvD+6U?=
 =?us-ascii?Q?CoSuVjqf4axQtC6cREQmN5MWyL9uLNEyztK/z/8Xf588cxkMAeYubq2GaKmq?=
 =?us-ascii?Q?qF9oM2PJOZJB4fs9w7wl5O3eN7U0/30G4ZJ6OQ8wFuMZag/Pwsz6udZoAQ8Q?=
 =?us-ascii?Q?128K6If6Y+pr2p7YHb4y1L5OZhnN2B7id7IiKtK9aEd8m3EOHX96XIzuTSR9?=
 =?us-ascii?Q?kk3RPgwua56A+iTlcVfPOwOYpCb2E8719lES86S1f2e9m8NEwud/FupbUcqt?=
 =?us-ascii?Q?6H99a2M9CxowuWaKfvnvnXoS82+CgJqqUU+sZ+wVptLUOcSIL350iZqfTzTe?=
 =?us-ascii?Q?nmpW728DQpCV+C1frU5mfT0pNIdQIhiPndZ0P5a12DI1XjJozCFi5zU939/E?=
 =?us-ascii?Q?Nv7so1hiNwyeJKRUffuSdJLm3FBFohGxtitQQYZ8oytLU/ttZRj0r+Lq60O7?=
 =?us-ascii?Q?pHc6AJNxDbAlxn99BDN8v42QmYRM/fxJH1EqamYi3vMa+RH9KlroYTU4HexU?=
 =?us-ascii?Q?QQhzlogs8vMtwado2tpXqH3gD/r7W7UtKeraGeCB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d3a83d4-8631-4f32-42ff-08dc7fac13c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 06:53:42.2665
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VArepHBIJ5K5HWW26phhkM21hOheyWmv3Y7dwxjSrxJlMK5wRcXPvl1htMcvftc0NvnArmLLsmnLemabjr66Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7081

> The only iommu function call in this driver is a
> tegra_dev_iommu_get_stream_id() which does not allocate anything and does
> not take any reference.
>=20
> More-over, what is freed is "se->dev" which has been devm_kzalloc()'ed in=
 the
> probe.

I did not completely understand what is being tried to convey here.
If I understand it right, iommu_fwspec_free() does not do anything
with the "devm_kzalloc"ed variable.=20

It would probably be a good idea to remove this line from the commit messag=
e.

>=20
> So there is no point in calling iommu_fwspec_free() in the remove functio=
n.
>=20
> Remove this incorrect function call.
>=20
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>