Received-SPF: pass (google.com: domain of linux-crypto+bounces-4501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
Date: Wed, 29 May 2024 10:20:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: Mario Limonciello <mario.limonciello@amd.com>,
 Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@vger.kernel.org>, Richard Hughes <hughsient@gmail.com>,
 open list <linux-kernel@vger.kernel.org>
References: <20240528210712.1268-1-mario.limonciello@amd.com>
 <20240528210712.1268-3-mario.limonciello@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own
 file
In-Reply-To: <20240528210712.1268-3-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OE1SbVZpTEFKREF4SHZKTmtnZitncDVYS2d4cmVTRmtDZ1BIelpNbVJqSHNC?=
 =?utf-8?B?QmRGNlI1YUIrcTVvUUdwMzdRc05uS1FNT1U2NHJJTDEvSXNZc2s4MjVDZGlB?=
 =?utf-8?B?WFVpSkt0QUUrb2tXb0QxVndwaVcwUkxpN2Fyd1l4ck1YeW53bzR4dUc1Yk1W?=
 =?utf-8?B?K1FGZHkwSHcrSTJ5cmlIM2FpYlliTVlzY1ViSFY0cGYrNEpyWmRoTzZ1eDV0?=
 =?utf-8?B?OFhRRWdNMnBzK1d2K3VFa0hQaFA4a1hrcDEyMUljRndPbE94aXJtZEFwOXo5?=
 =?utf-8?B?UHo5K21pMmNZWC96bXo3VVNuQzBrQTdDRDhpcENzVGlXWjVCL1UyNkRJb0lD?=
 =?utf-8?B?c0daQjRtajM5UUNHU3NnaTFaVVhyclc3T3JUc1dGZmNndVJGWlR3endzMjAx?=
 =?utf-8?B?L1VnWmU2VUZmOTE3V1JNM2lmVkloVEYxdFhCZFoyTVYzY2h6MlJMNXNIcXAr?=
 =?utf-8?B?Ty9UTDZOMG1heXlFNS9PVTJubFhScTg2c2o5bU1QSDFjejNhV21jSVFULzMz?=
 =?utf-8?B?T1V4d1lrVmRmenlvYnF1bnRmbkpBM2dFaTJlMUd3NVNmdERoVjZ3YkloWWtj?=
 =?utf-8?B?SEU2cUdVeS85YUloTVNmVDRzMUwvRnA3WGN3Vzg3QXNUVDhZaFBDUG93Um9q?=
 =?utf-8?B?VUZCK3dmYkZ6aDNHWlZzWmZrbHVwb0RvV3F2ZjBjTUREWjJjOHhQelRrbitH?=
 =?utf-8?B?NHAybXB1dEFWalZyemR6TnJzcDBXSHY4ZnBRRGtRYTUwRjI4WWYxd3E0TTVK?=
 =?utf-8?B?RXJXNHBuZzdZZ3htVFlnL1RpM3JNcHZsaEFRMVZ3Z1hYalRaRU9XWXJici9C?=
 =?utf-8?B?NCtRWENoQkZ4bXFTdHRoUVd2SXJ2RnNHa1NML2FWdHhHaU1LNlVuWmg0c2RX?=
 =?utf-8?B?WVZpR3RMeDh1clRTYVFRaW15c0gxT2hkWkhKSUlSaFA1VnRncG1tay9zMHQx?=
 =?utf-8?B?c2ZSbE1UdU5EdlVnVkgvclR2NDRFWlpxWnlZSXVuMXkyeHEvNjBsRXhHV3F5?=
 =?utf-8?B?M1R6Y1FxSXN2ektnY0JWRGgzcW1sN0ViWnQzNzJiNHpjTW5qMUV3V2dhN2ds?=
 =?utf-8?B?UktyQUZ1akNLc0NNV0h0TmNRbEJJMXFoNnh1SHpvSHZuUkRQMDlMTmtnVk1E?=
 =?utf-8?B?eHlnUzFFclc0ZzJHeks1Mk1HclZCUjFZY2RDQnhvYTV0YmRnQ2ZBK0hRbS93?=
 =?utf-8?B?QUJNM0UrTFBqZGJUT1FaVlFCSldLNUpidHRmSUZDL1RxK01ISy9oSm40NmJX?=
 =?utf-8?B?Unpkai9jWUc0QnJYQ295Sm1FQWkwdjBYS0dEcnlwZkxNb2RJRDdqZU5jb1U5?=
 =?utf-8?B?VXEyWFZDYkV5ZUxQaGpDNW92SDVsNzVRNG93UEpRZUVJdXhQSEpTeTBXeGxG?=
 =?utf-8?B?MkpETVNkOHVHV0JQZmxIblRHY0ZUaExHYlMvNXVRV0tNVTFzS0VWU0E4UXY0?=
 =?utf-8?B?OEtKMlk4U3oxc0FRajk4WUhzaGNUeEY4UkhnbTU4YmV3eUszeS9ROXpMTStu?=
 =?utf-8?B?SHV4dDVlb3grVkNCZ1kzWFIzTHZBN0FGRStLUEt2WThKNHZuZG50S3lmMzdw?=
 =?utf-8?B?aVhEeGFWNlRSYzZ1VlBTVUVUZUdUd0Qyb3I4TjlkZU5QUisxckcwS05PTmY1?=
 =?utf-8?B?V2RkdTM1NC82Nm9BNWozMGFRaTFCNEpzU0JhMVhHbEYzOVdDZXd2Mk1ETHBm?=
 =?utf-8?B?ZGZQMHJZeTRUeWlwWW1nby9Lc1dBb2NPSUVqK0gyc3J0T3ZCYlpJTGdsOGlr?=
 =?utf-8?B?aXZpdTVDaEQ1c1VZeG1sZm51c0pQc1k4QTNZWjAzN0pSRjNoV3NzaDNuVXNy?=
 =?utf-8?B?NjdycFgvNTYwTU1Sa1hiNmJzbmlmUVhhSHdsN1ByNGF6SFZ6MHdyZTRzSDhk?=
 =?utf-8?B?VE1UUFh0T014Vm5nRk84TzRKeHorNnpNVlJxaGRIVCtlNEw2aEtqRndPNW9L?=
 =?utf-8?B?cW1uSVdFSHAxOXJ6bFMzOC82eENINExBNUsrd2c0bzlSa0phQWFzMUtHTXRt?=
 =?utf-8?B?VEFqNGdkUkhUQk44V1hDM2IrUi9xOElkSUFSdmhvTWVjSU81TnM5VFNEbjRO?=
 =?utf-8?B?QU94eFVoeVRPcENLblhNNHRqajZXZXA1d09JL0YxbUJmRFZDTUh3VmQyVElr?=
 =?utf-8?Q?MnW234xL0ua7Jj/zYpP0XG+tD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebf7e518-ddf4-4f9f-330c-08dc7ff2e009
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 15:20:29.8573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FxARVtIpAvfE8fQxGxbxIr2W8wKiSDNW6jaR2xPbFcvKGa7PEVxE3dK5epZA605R6pjHvnt1k8+T5g5jFzCMvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4097

On 5/28/24 16:07, Mario Limonciello wrote:
> To prepare for other code that will manipulate security attributes
> move the handling code out of sp-pci.c. No intended functional changes.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>   * Only add psp_security_attr_group when PSP support enabled
>     (Fixes lkp robot reported Kconfig issue)

Just verifying that there's no change in behavior in regards to whether 
the attributes are shown. Previously the attributes were not shown if 
CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would be NULL in 
psp_security_is_visible(), right?

Thanks,
Tom

> ---
>   MAINTAINERS                  |  6 ++++
>   drivers/crypto/ccp/Makefile  |  3 +-
>   drivers/crypto/ccp/hsti.c    | 68 ++++++++++++++++++++++++++++++++++++
>   drivers/crypto/ccp/hsti.h    | 15 ++++++++
>   drivers/crypto/ccp/psp-dev.c |  1 +
>   drivers/crypto/ccp/sp-pci.c  | 58 ++----------------------------
>   6 files changed, 95 insertions(+), 56 deletions(-)
>   create mode 100644 drivers/crypto/ccp/hsti.c
>   create mode 100644 drivers/crypto/ccp/hsti.h
>