Received-SPF: pass (google.com: domain of linux-crypto+bounces-4502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <5bb969c4-5d73-80ba-7aac-fb47105a1f40@amd.com>
Date: Wed, 29 May 2024 10:21:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 4/5] crypto: ccp: Add support for getting security
 attributes on some older systems
Content-Language: en-US
To: Mario Limonciello <mario.limonciello@amd.com>,
 Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@vger.kernel.org>, Richard Hughes <hughsient@gmail.com>,
 open list <linux-kernel@vger.kernel.org>
References: <20240528210712.1268-1-mario.limonciello@amd.com>
 <20240528210712.1268-5-mario.limonciello@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240528210712.1268-5-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkIrUmY4dzhhdDJOcEdzRjBqWHZTbk16Q0FjclduelhjMTc1cmNjditaUXZT?=
 =?utf-8?B?d25CMXhxaUVSSGswWDNxcHBZSnhEdnFQSVpRS2s0UlZGLzRmZEZYdUEzOTBS?=
 =?utf-8?B?SVI5bS91Tzk0SzJTRDlGTlRacG8yUzRYYzRBSXJwZkwxbm9kRjNIZjhFdXFn?=
 =?utf-8?B?QjZodjBPak9lS056Tk04aFRtU2EwbTN1ck1xZklwR2JYd0R0OW80RFN2K1Za?=
 =?utf-8?B?U2RxbTRVeitneHprWWRwcUEzM1huN0FLUzlVYjdmZWRiL3h4RjcvNW52VWJv?=
 =?utf-8?B?OTdEM2xHVUR0dzlEOUVZZ1QxQ3hhenp5MVIyMDFGWlFxN1dKdDRvOHhDM2h6?=
 =?utf-8?B?SnhGOFVDRXRwSzRWZXp0NTVuTVRONXJWSVc2T01vaEthVkdFeGN2Y3NBQkxy?=
 =?utf-8?B?a3RvK0pKeXVnM3l3c2hhSzlXZ0oyWDJJaDNiYVprT3NoaVI4UVVqUWNsdm0z?=
 =?utf-8?B?a2thcGhiZFRIeWxWOUtMUGovZmcrUjNQVTE3RlhEcTVUUFdKQ3VFMWVMVldu?=
 =?utf-8?B?RTFKZ3hJa2sweWxTVWdXM0IrRzg3VXhIMExKckc3dUFWRkFNZmVEWFdCVEF5?=
 =?utf-8?B?YXl4M2ZpOGdnUTRVbUZDRUdkUTV2RHN3V1ByTTdTV0dHTkNxeFcxZ0M2cjZq?=
 =?utf-8?B?K21xWTMwVHIyZFlKd05JRlVNVGt1Y1RPMG5uZkVReHkwOWN3M0tudGhZazFD?=
 =?utf-8?B?cWUxNWYyWExlbG5MWmlLVFFGT1E4U1BUNzR5ZURHNTRxTlQzTnU5STdScm1q?=
 =?utf-8?B?NDcvUjBBRkVKOXpseWxyVDJOZ05SRkpUKy9tUVdFVEwzTVNUcW9kR3hZQWpn?=
 =?utf-8?B?RnRzZVkraEJRMFdDaC9tc0poc29CVFNiMGdUVmFIRWU1Z1JlbXJEcTcrbzVj?=
 =?utf-8?B?VzFvREI5cDR5ZzBZZTJueXN0ZlRWaENaWWVlcjh5MmF1RktubmlJRzRPLzZ4?=
 =?utf-8?B?Mm5lQTdYekYxRXRVbGcrc0xENmYzamlybzVqSW1KR1pYaTk4OGtaNVhTRjlp?=
 =?utf-8?B?VWNpbWZYUklaZHZvbzFWQ09nZS8xM2R0cFNKMHliWUxqVm9kdXBkUkxzMStZ?=
 =?utf-8?B?bGF1ZjdESU53SjkvYlU5Vng5aTFweFFURnFnRllNMXJPOGgwZ0FQSDE1dlFO?=
 =?utf-8?B?eHA2Vjkrd25reHgrRmx3dFZsdUlHU1N0Z0dsd1kvMFluTnhldDcvZHVlc21P?=
 =?utf-8?B?bTlUSmhoTjJ1NFlqTnJYbUt4Y3VJTnZBS05aTHNhaHlUVjV0dFBhMk4wZ3dz?=
 =?utf-8?B?eWxEdDlralZ6Q3hiS2FGcWh1cHpPWlNWNGtjUXJpM2lWMzVIcVZsbFZmWkpT?=
 =?utf-8?B?QUpCNzZJOW9RRDN6SkhUOExETmJ5cVdHMWkxMVZJWCtKT2U2TUM0OXRNREZq?=
 =?utf-8?B?a3NISkN1QXZFRDRza2ZSZXV6dVpyZGRzVDZlQVMxV1poUkZ5NEQ4ZU9saVA5?=
 =?utf-8?B?cktrV1hrVHhUWURmN0MzQk50YkZFeStkOXprcUNPUVJLYUNwSFBIQmt6SUNG?=
 =?utf-8?B?UGtBWG5qbUdBK1RWa0hYYTRzWkxxSm95dmFHRWk0SGthRDhuVVY1TXhYZmgy?=
 =?utf-8?B?cUZQTURDTEdrelJJdWpnM3ZIcy9sZzNLczVFMkRLNDJ2SUUwODBlVytSeHRI?=
 =?utf-8?B?RkMxemlDZytyU2NzTStPVVJ0M0VrejFhZDE2alhKbm1EdE9Zb1plZE9xSHlS?=
 =?utf-8?B?VXU5QXcxK2gyRnk0MUsrSE5wWnMwZU1PanArdm5UTU5VcWZmZG83ZC9ZZmxC?=
 =?utf-8?B?SWl4T04zTi9CdHEvMHZZa1BISGFTS1dQQXI3ZCszaUhvb01jRHA3ZllxOHVu?=
 =?utf-8?B?WDZ1cWxHWFdMV1AvK0FsZVJlTGNpUmZmbitMQlZPdGN5bkZ3ek9xYXNPMFBu?=
 =?utf-8?B?TDYwMHVSNlFZQmJVa09hZ1FSYnRTQUhnR3pXdWpBUXZEVmt4dXA0Z3ArSUtv?=
 =?utf-8?B?R3JHTlo0TFA3R1JCZlhaajYwZHU5cUIvQnE5T0J6T2h1VmFHUjBpR3VJLzFh?=
 =?utf-8?B?dnQ3R2VJYjRxd1JDTzVvK1o3b2wxMWxrUklaUDEvV2V6RWRmUEV6Z1RnZDFF?=
 =?utf-8?B?djFJOGZRMEdKMWxiMi84TFFIaUxKRzZqeUx3MjhBaUdxU0dPVXAwUTVSY2R0?=
 =?utf-8?Q?j/Nc1IiDue1IsADQhIcF2fgaF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d57da52-c8b9-45b8-2f13-08dc7ff2fb49
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 15:21:15.5541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XEN3rnZ+0yo7B+WrX4YpmWqHmjOJQaBWXxwAvXlhYMItwe8c5T2F3J2cEGvkDh8absiQLojhc6+btJjBSX7jNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9337

On 5/28/24 16:07, Mario Limonciello wrote:
> Older systems will not populate the security attributes in the
> capabilities register. The PSP on these systems, however, does have a
> command to get the security attributes. Use this command during ccp
> startup to populate the attributes if they're missing.
> 
> Closes: https://github.com/fwupd/fwupd/issues/5284
> Closes: https://github.com/fwupd/fwupd/issues/5675
> Closes: https://github.com/fwupd/fwupd/issues/6253
> Closes: https://github.com/fwupd/fwupd/issues/7280
> Closes: https://github.com/fwupd/fwupd/issues/6323
> Closes: https://github.com/fwupd/fwupd/discussions/5433
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> v1->v2:
>   * Move code to patch 5
> ---
>   drivers/crypto/ccp/hsti.c           | 55 +++++++++++++++++++++++++++++
>   drivers/crypto/ccp/hsti.h           |  2 ++
>   drivers/crypto/ccp/psp-dev.c        |  5 +++
>   drivers/crypto/ccp/psp-dev.h        |  2 --
>   drivers/crypto/ccp/sp-dev.h         |  1 +
>   drivers/crypto/ccp/sp-pci.c         |  5 ++-
>   include/linux/psp-platform-access.h |  1 +
>   7 files changed, 68 insertions(+), 3 deletions(-)
>