Received-SPF: pass (google.com: domain of linux-crypto+bounces-4506-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e29a975a-cb63-43cb-a421-8d7dd5ca36a6@amd.com>
Date: Wed, 29 May 2024 11:22:04 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/5] crypto: ccp: Move security attributes to their own
 file
To: Tom Lendacky <thomas.lendacky@amd.com>,
 Herbert Xu <herbert@gondor.apana.org.au>
Cc: "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..."
 <linux-crypto@vger.kernel.org>, Richard Hughes <hughsient@gmail.com>,
 open list <linux-kernel@vger.kernel.org>
References: <20240528210712.1268-1-mario.limonciello@amd.com>
 <20240528210712.1268-3-mario.limonciello@amd.com>
 <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <7f9db4de-635f-6204-d261-3bcd0aac1c25@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bjBBZ0IzS09mS01ncXFQREZ3QVlMTUxMdElzRXZ4WllsM2g3Yjhad2dkcXBK?=
 =?utf-8?B?ZXcxQWpLREVqT2NMeWxPSUJTTGJCTFhQalpTRE5Hb29mMStHRERTb0VWNDJU?=
 =?utf-8?B?cVAzd0RPT0dZdlF2d3FyQ0RYN29QT01pekpTRUdiK3N6aXhFS3dWYkZUdWw1?=
 =?utf-8?B?Rmhab2NvZlVoVmtjdGVpM0J5ZEkwTE9NRjJKQlRqSkN4dDhaVU50dHBiT0tl?=
 =?utf-8?B?cHowQlczYVczRGFLL2k4L0hWa2ovNERRZGNUWEwzb2tnVk9INVJ0MmY5cHhl?=
 =?utf-8?B?VEpsb2h1SUtzeSt6NGZMU3ZGTi9FTG5KZzdkSWhhK2lRWGhETzhFMDdLY0Nq?=
 =?utf-8?B?enlWS1pmVEIzSjZ6cW15eWhEN2w2RWZJbSsvZ3hOVmp0YUJLakNJdDE4WWE4?=
 =?utf-8?B?dC9oRHVxam9RNUdvZFZzbUw0MVpFUGthVkJjRlVOcldFRGhtNHh2dlE0eG94?=
 =?utf-8?B?QzdiQUVGckpubVJBQkEyK2UvQm1GTjk4NFhtclE2UHlIOXVDOFBXcEl0cHhC?=
 =?utf-8?B?bGpoNTJrdkhKT1VCWUVEaTdlWmUweW9RQ3NEcWozZnVadXdMejhRU3Jza1Bn?=
 =?utf-8?B?cmh2ME1VYXpsRmZGaExoN3h0L0ZnalcwM2pFU2h5ZUlpOERMZEQ4OGZqY0Yv?=
 =?utf-8?B?WGtDc3R3MTNiSW1wV2tPVUVkSFpPRHk4S1pZTTRWL0hDOTRiTERyaHlrVlMx?=
 =?utf-8?B?UzV1UXdua3BpMCtYMVhBMEhpYzkvd3Jxa1lmbklhVjlQdEtzWlgwbUpnanU5?=
 =?utf-8?B?UlhPc3lpMWk2UGduemFpTTJ2c015c1JUUWxuZ1lDRjQ4MGM1S1BZa01jczBK?=
 =?utf-8?B?K0hzVWw1QTZsdVg4eG1pNFFQdXhLSWg0dWNrUzN2MzI2dWRrSHg3UmhYMS9K?=
 =?utf-8?B?eDUva21kc3VJL2dqL3hJbkhxcUdUQXZYK05QUVlLSFZvSFNPVFdqV1JMWVBU?=
 =?utf-8?B?VWh4THpGWFY5aTh1RFRRWmlWZXA0VnVyRW5NYzFtelFCRFZ1WVZQbE42a3FM?=
 =?utf-8?B?STIvKytJalhRSy9Od2dkY2orVjhDSkZhTHVKbFJUSjFEaS9CRE1JV2toMlpI?=
 =?utf-8?B?V2Q1dG5XUnV1S081UzlOTHVNZHdUVU5DeERYc05IQnMzMDBlQkxxcHZjd2NO?=
 =?utf-8?B?eWVlWU16aXN4cmZLbkRvbHFCQ3pEdFdnKzdlOWx0emtDTVdILzIzNGdIZFov?=
 =?utf-8?B?eElwWG93VzJzQlRodDc4WE5YOXliYms2eHNRMCtEamJraWR1YUNwSmhhODFy?=
 =?utf-8?B?VGwzZ0htQVgvN0xOYmR5cDliWHY2QzRFSXlRY1c3bm5QRktONWhEcWRrenJG?=
 =?utf-8?B?T0t3aENHMkt6UTZmOEUzS0N1TmNucjdMdm9PZXZUcXlRcENQQVU1bFpNMlFn?=
 =?utf-8?B?YzFITWtLVHZNWTRJbW1va2NXdlVwVlZ0T2FhWjVOeVdtbmtZdU1BQlNUUTRB?=
 =?utf-8?B?OFNWb0ZPbWpsSytBdUUxOVFlVXROTDY2Z3hsNGhFdU82N0E2ZTYrQnFmY1N2?=
 =?utf-8?B?MjJwaFpveUl3NlhZeUJCNVRBRGVBelkzWjR4MHFWYzVZQ0pXQzRJZkJnY3hY?=
 =?utf-8?B?UjljMkNCKzBPeWtZMkZHbk5JeDN0bytEc042T056TXVlVVJQL0Fya3o5QnJP?=
 =?utf-8?B?c3ZEZDdORHorRjhqVElqTUNqYU16Y1B0Q1pZM0lZNlF5Mm1VNFNsQ1pidW0y?=
 =?utf-8?B?cFFFb0JHSGphOXVYN21zUHlLU01nUGU5V0lwTzUwakM5Z0xTOFBFVVVlNnEr?=
 =?utf-8?B?T2NQTzNRaFFRQ3JVRmRqSFJVS0Q4eFBSRTU5a2ZoVmNkazh4aFRQMm9QRGIx?=
 =?utf-8?B?SjZpVnhTQldlU2szbVMzWjNWRFIxQ1o2UHF3bWFOTWxrcTJZY09ybkwzRUNK?=
 =?utf-8?B?NGg3UldBdlJjZ0dFUjJkS09FSk81c01mQXg2ZTZJOWtxcGhtZGI3OHFSb2Jv?=
 =?utf-8?B?VTUzMEtnVlFjOXJ5UitodWdwWDVyaVpMVFNoMmpBY0dZd1BzREZlWW4rMXdT?=
 =?utf-8?B?cUg3MFNVa09BWHVtOEl0ZFJib2hGTG11ZXc2N0QxRUZQVmZGa2prZjluVTRm?=
 =?utf-8?B?L3c5ZVRtSXowblIwQ3BLNjJpWkFRYmZya0Zub0xmS0laNFl5Q2JXQkJLUFB2?=
 =?utf-8?Q?xPC5RZUuE9qbgElZe4YRG5pph?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 869f2014-d013-45fe-7392-08dc7ffb7ac2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 16:22:05.4392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o9+85DSJ0s5IaRtPnfJpqo6HGWTenZOpwItnWKQ7w1DIOFCcF3eg3o3CR5Q5UC+Zn+E4WvDH9m90pJdsWozUBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4341

On 5/29/2024 10:20, Tom Lendacky wrote:
> On 5/28/24 16:07, Mario Limonciello wrote:
>> To prepare for other code that will manipulate security attributes
>> move the handling code out of sp-pci.c. No intended functional changes.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v1->v2:
>>   * Only add psp_security_attr_group when PSP support enabled
>>     (Fixes lkp robot reported Kconfig issue)
> 
> Just verifying that there's no change in behavior in regards to whether 
> the attributes are shown. Previously the attributes were not shown if 
> CONFIG_CRYPTO_DEV_SP_PSP was "n" because the psp value would be NULL in 
> psp_security_is_visible(), right?

Yes; that's right.